Skip to content

refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in functions - #147472

Merged
bors merged 1 commit into
rust-lang:masterfrom
AMS21:remove_llvm_rust_atomics
Oct 8, 2025
Merged

refactor: replace LLVMRustAtomicLoad/Store with LLVM built-in functions#147472
bors merged 1 commit into
rust-lang:masterfrom
AMS21:remove_llvm_rust_atomics

Conversation

@AMS21

@AMS21AMS21 commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

This simplifies the code and reduces the burden of maintaining our own wrappers.

Work towards #46437

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 8, 2025
@rustbot

rustbot commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

nikic
nikic reviewed Oct 8, 2025
View reviewed changes
Comment threadcompiler/rustc_llvm/llvm-wrapper/RustWrapper.cpp
@AMS21
AMS21force-pushed the remove_llvm_rust_atomics branch from 01d09e1 to 1aed495CompareOctober 8, 2025 11:54
@nikic

nikic commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 1aed495 has been approved by nikic

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 8, 2025
Merged
bors added a commit that referenced this pull request Oct 8, 2025
@bors
Auto merge of#147475- matthiaskrgr:rollup-iyrkv0g, r=matthiaskrgr
7a52736
Rollup of 6 pull requests
Successful merges:
- #144006 (clarify wording of match ergonomics diagnostics (`rust_2024_incompatible_pat` lint and error))
- #147386 (some more `proc_macro` cleanups)
- #147412 (Convert impossible cases in macro resolution into assertions)
- #147464 (prefer repeat_n() over repeat().take())
- #147469 (Add rustdoc crate name in error)
- #147472 (refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 359bfa9 into rust-lang:masterOct 8, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Oct 8, 2025
@rust-timer
Unrolled build for#147472
41632e3
Rollup merge of #147472 - AMS21:remove_llvm_rust_atomics, r=nikic
refactor: replace `LLVMRustAtomicLoad/Store` with LLVM built-in functions
This simplifies the code and reduces the burden of maintaining our own wrappers.
Work towards #46437
@rustbotrustbot added this to the 1.92.0 milestone Oct 8, 2025
@AMS21
AMS21 deleted the remove_llvm_rust_atomics branch October 8, 2025 19:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nikicnikicnikic left review comments

Assignees

@davidtwcodavidtwco

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@AMS21@rustbot@nikic@bors@davidtwco