Skip to content

Fix ICE caused by associated_item_def_ids on wrong type in resolve diag - #147680

Merged
bors merged 1 commit into
rust-lang:masterfrom
chenyukang:yukang-fix-ice-147325
Oct 15, 2025
Merged

Fix ICE caused by associated_item_def_ids on wrong type in resolve diag#147680
bors merged 1 commit into
rust-lang:masterfrom
chenyukang:yukang-fix-ice-147325

Conversation

@chenyukang

@chenyukangchenyukang commented Oct 14, 2025

Copy link
Copy Markdown
Member

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2025
@estebank

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c00b4ba has been approved by estebank

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
…r=estebank
Fix ICE caused by associated_item_def_ids on wrong type in resolve diag
Fixesrust-lang#147325
r? `@estebank`
This was referenced Oct 14, 2025
bors added a commit that referenced this pull request Oct 14, 2025
Rollup of 12 pull requests
Successful merges:
- #146187 (Unstably constify `ptr::drop_in_place` and related methods)
- #146503 (std: improve handling of timed condition variable waits on macOS)
- #147526 (Move computation of allocator shim contents to cg_ssa)
- #147630 (Bitset cleanups)
- #147638 (bpf: return results larger than one register indirectly)
- #147666 (Replace manual implementation with `carrying_mul_add`)
- #147669 (fix missing link to `std::char` in `std` docs)
- #147673 (pretty print u128 with display)
- #147677 (Fewer exceptions in `span()` on parsed attributes)
- #147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- #147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- #147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 3856d0b into rust-lang:masterOct 15, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 15, 2025
rust-timer added a commit that referenced this pull request Oct 15, 2025
Rollup merge of #147680 - chenyukang:yukang-fix-ice-147325, r=estebank
Fix ICE caused by associated_item_def_ids on wrong type in resolve diag
Fixes#147325
r? ``@estebank``
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Oct 15, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Nov 3, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE missing associated_item_or_field_def_ids for DefId

4 participants

@chenyukang@estebank@bors@rustbot