Skip to content

convert rustc_main to the new attribute parsing infrastructure - #147682

Merged
bors merged 1 commit into
rust-lang:masterfrom
jdonszelmann:convert-rustc-main
Oct 15, 2025
Merged

convert rustc_main to the new attribute parsing infrastructure#147682
bors merged 1 commit into
rust-lang:masterfrom
jdonszelmann:convert-rustc-main

Conversation

@jdonszelmann

@jdonszelmannjdonszelmann commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2025
@jdonszelmannjdonszelmann changed the title convert to the new attribute parsing infrastructureconvert rustc_main to the new attribute parsing infrastructureOct 14, 2025
@jdonszelmannjdonszelmann mentioned this pull request Oct 14, 2025
Open
9 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwerJonathanBrouwer mentioned this pull request Oct 14, 2025
Open
JonathanBrouwer
JonathanBrouwer reviewed Oct 14, 2025
View reviewed changes
Comment threadtests/ui/feature-gates/issue-43106-gating-of-builtin-attrs-error.stderr
|
LL - #![rustc_main]
LL + #[rustc_main]
|

@JonathanBrouwerJonathanBrouwerOct 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this "perhaps you meant to use an outer attribute" is nice to have, but we can re-add that to the general target checking logic (so it works for all attributes) later, no need to block the PR on this
Made it into an issue so we don't forget: #147688

@JonathanBrouwer

JonathanBrouwer commented Oct 14, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 14, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 047c37c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147682- jdonszelmann:convert-rustc-main, r…
75aed0a
…=JonathanBrouwer
convert `rustc_main` to the new attribute parsing infrastructure
r? `@JonathanBrouwer`
This was referenced Oct 14, 2025
Closed
Merged
bors added a commit that referenced this pull request Oct 14, 2025
@bors
Auto merge of#147692- matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
235a4c0
Rollup of 12 pull requests
Successful merges:
- #146187 (Unstably constify `ptr::drop_in_place` and related methods)
- #146503 (std: improve handling of timed condition variable waits on macOS)
- #147526 (Move computation of allocator shim contents to cg_ssa)
- #147630 (Bitset cleanups)
- #147638 (bpf: return results larger than one register indirectly)
- #147666 (Replace manual implementation with `carrying_mul_add`)
- #147669 (fix missing link to `std::char` in `std` docs)
- #147673 (pretty print u128 with display)
- #147677 (Fewer exceptions in `span()` on parsed attributes)
- #147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- #147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- #147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ea0c8d8 into rust-lang:masterOct 15, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 15, 2025
rust-timer added a commit that referenced this pull request Oct 15, 2025
@rust-timer
Unrolled build for#147682
79ef4ef
Rollup merge of #147682 - jdonszelmann:convert-rustc-main, r=JonathanBrouwer
convert `rustc_main` to the new attribute parsing infrastructure
r? ``@JonathanBrouwer``
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Oct 15, 2025
@bors
Auto merge of #147692 - matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
548dcbb
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Nov 3, 2025
@bors
Auto merge of #147692 - matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
a284987
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #147692 - matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
57ec426
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147692 - matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
60755d2
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147692 - matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
87639b2
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147692 - matthiaskrgr:rollup-bqhlwyw, r=matthiaskrgr
1bdd33a
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#146187 (Unstably constify `ptr::drop_in_place` and related methods)
- rust-lang/rust#146503 (std: improve handling of timed condition variable waits on macOS)
- rust-lang/rust#147526 (Move computation of allocator shim contents to cg_ssa)
- rust-lang/rust#147630 (Bitset cleanups)
- rust-lang/rust#147638 (bpf: return results larger than one register indirectly)
- rust-lang/rust#147666 (Replace manual implementation with `carrying_mul_add`)
- rust-lang/rust#147669 (fix missing link to `std::char` in `std` docs)
- rust-lang/rust#147673 (pretty print u128 with display)
- rust-lang/rust#147677 (Fewer exceptions in `span()` on parsed attributes)
- rust-lang/rust#147680 (Fix ICE caused by associated_item_def_ids on wrong type in resolve diag)
- rust-lang/rust#147682 (convert `rustc_main` to the new attribute parsing infrastructure)
- rust-lang/rust#147683 (only check duplicates on old/unparsed attributes)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerJonathanBrouwer left review comments

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@jdonszelmann@rust-log-analyzer@JonathanBrouwer@bors@rustbot