Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Rollup of 2 pull requests by Zalathar · Pull Request #148022 · rust-lang/rust · GitHub
Skip to content

Rollup of 2 pull requests - #148022

Merged
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u
Oct 23, 2025
Merged

Rollup of 2 pull requests#148022
bors merged 5 commits into
rust-lang:masterfrom
Zalathar:rollup-3m6ty9u

Conversation

@Zalathar

@ZalatharZalathar commented Oct 23, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

joshlfand others added 5 commits September 21, 2025 04:29
Co-authored-by: Ralf Jung <post@ralfj.de>
Edited-by: TC
Let's rewrite this for better clarity. In particular, let's document
our language guarantees upfront and in positive form. We'll then list
the caveats and the non-guarantees after.
reorder impl block
changed is_bless to is_bless_enabled
Document MaybeUninit bit validity
Partially addresses rust-lang/unsafe-code-guidelines#555 by clarifying that it is sound to write any byte values (initialized or uninitialized) to any `MaybeUninit<T>` regardless of `T`.
r? `@RalfJung`
Add TidyFlags and merge DiagCtx
Adds a struct `TidyFlags` and merges it with `DiagCtx` into `TidyCtx`. Removes the need to pass `bless` into individual check functions in tidy.
@rustbotrustbot added A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@Zalathar

Copy link
Copy Markdown
MemberAuthor

Rollup of everything not in #148014.

@bors r+ rollup=never p=5

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5ff30d3 has been approved by Zalathar

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5ff30d3 with merge 11d2046...

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Zalathar
Pushing 11d2046 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 11d2046 into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#140463Document MaybeUninit bit validity41f21b40a0062dea51fc0993001b723499c6f607 (link)
#148017Add TidyFlags and merge DiagCtxa8f2ac052078ab066dcb35489f0a6f9a92d415a9 (link)

previous master: 469357eb48

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 469357e (parent) -> 11d2046 (this PR)

Test differences

Show 160 test diffs

160 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 11d2046fe9962720558cb15f72541f7fd170dec9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-2: 2576.2s -> 2164.0s (-16.0%)
  2. dist-x86_64-apple: 8250.5s -> 7072.6s (-14.3%)
  3. aarch64-gnu-llvm-20-1: 4003.6s -> 3433.6s (-14.2%)
  4. i686-gnu-2: 6364.5s -> 5554.2s (-12.7%)
  5. dist-aarch64-apple: 7136.7s -> 6319.1s (-11.5%)
  6. x86_64-gnu-gcc: 3462.7s -> 3071.2s (-11.3%)
  7. x86_64-gnu-llvm-20: 2726.5s -> 2449.4s (-10.2%)
  8. x86_64-gnu-miri: 4797.9s -> 4332.9s (-9.7%)
  9. x86_64-rust-for-linux: 2980.6s -> 2693.4s (-9.6%)
  10. x86_64-gnu-tools: 3597.2s -> 3267.6s (-9.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (11d2046): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)--0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
3.5%[1.7%, 5.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.4%[-2.4%, -2.4%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.879s -> 474.995s (0.02%)
Artifact size: 390.43 MiB -> 390.51 MiB (0.02%)

@Zalathar
Zalathar deleted the rollup-3m6ty9u branch October 23, 2025 22:39
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 2 pull requests
Successful merges:
- rust-lang#140463 (Document MaybeUninit bit validity)
- rust-lang#148017 (Add TidyFlags and merge DiagCtx)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tidyArea: The tidy toolmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Zalathar@bors@rust-timer@rustbot@joshlf@traviscross@simp4t7