Skip to content

Rollup of 3 pull requests - #148014

Merged
bors merged 6 commits into
rust-lang:masterfrom
jhpratt:rollup-aglren3
Oct 23, 2025
Merged

Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom
jhpratt:rollup-aglren3

Conversation

@jhpratt

@jhprattjhpratt commented Oct 23, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

WilliamVennerand others added 6 commits October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 23, 2025
@jhpratt

jhpratt commented Oct 23, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=3

@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5d55418 has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2025
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 5d55418 with merge 469357e...

@ZalatharZalathar mentioned this pull request Oct 23, 2025
Merged
@bors

bors commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 469357e to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 23, 2025
@bors
bors merged commit 469357e into rust-lang:masterOct 23, 2025
12 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 23, 2025
@rust-timer

rust-timer commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)

previous master: 4b3ba5844e

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actionsBot commented Oct 23, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)

Test differences

Show 120 test diffs

Stage 1

  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)

Stage 2

  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)

Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@borsbors mentioned this pull request Oct 23, 2025
Merged
@rust-timer

rust-timer commented Oct 23, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (469357e): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		0.1%[0.1%, 0.1%]1
Regressions ❌
(secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1

Max RSS (memory usage)

Results (primary -0.4%, secondary -1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.0%[2.0%, 2.0%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅
(secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3

Cycles

Results (primary 2.1%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[2.1%, 2.1%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)

@jhpratt
jhpratt deleted the rollup-aglren3 branch October 23, 2025 14:28
@github-actionsgithub-actionsBot mentioned this pull request Oct 30, 2025
Closed
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Rollup of 3 pull requests by jhpratt · Pull Request #148014 · rust-lang/rust · GitHub
Skip to content
Rollup of 3 pull requests - #148014
Merged
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Oct 23, 2025
Merged
Rollup of 3 pull requests#148014
bors merged 6 commits into
rust-lang:masterfrom 
jhpratt:rollup-aglren3
Conversation
@jhpratt
@jhprattjhpratt
commented
Oct 23, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
WilliamVennerand others
added 6 commits
October 21, 2025 16:11
@WilliamVenner@zachs18
Add String::replace_first and String::replace_last
8ed7fca
Rebased and modified by zachs18.
Co-authored-by: zachs18 <8355914+zachs18@users.noreply.github.com>
@clarfonthey
Revert inference failure from AsRef constification
cb7fb35
@cjgillot
Retire ast::TyAliasWhereClauses.
15c91bf
@jhpratt
Rollup merge ofrust-lang#134316- zachs18:string_replace_in_place_re…
4491efb
…base, r=joshtriplett
Add `String::replace_first` and `String::replace_last`
Rebase of rust-lang#97977 (cc `@WilliamVenner)`
> Convenience methods that use `match_indices` and `replace_range` to efficiently replace a substring in a string without reallocating, if capacity (and the implementation of `Vec::splice`) allows.
The intra-doc link to `str::replacen` is a direct url-based link to `str::replacen` in `std`'s docs to work around rust-lang#98941. This means that when building only `alloc`'s docs (and not `std`'s), it will be a broken link. There is precedent for this e.g. in [`core::hint::spin_loop`](https://doc.rust-lang.org/nightly/src/core/hint.rs.html#214) which links to `std::thread::yield_now` using a [url-based link](https://github.com/rust-lang/rust/blob/master/library/core/src/hint.rs#L265) and thus is a dead link when only building `core`'s docs.
ACP: rust-lang/libs-team#506
@jhpratt
Rollup merge ofrust-lang#147713- cjgillot:where-cfg, r=fmease
0185feb
Retire ast::TyAliasWhereClauses.
`ast::TyAliasWhereClauses` is a tentative to avoid forgetting predicates when manipulating the AST.
It is incompatible with `cfg` attributes on where clauses.
This PR uses a regular `WhereClause` for the "second" clause.
Fixesrust-lang#138010
cc rust-lang#138037
@jhpratt
Rollup merge ofrust-lang#148011- clarfonthey:const-convert-revert, …
5d55418
…r=oli-obk
Revert constification of `AsRef for Cow` due to inference failure
Reported issue: rust-lang#147964
Original PR: rust-lang#145279
`const AsRef` tracking issue: rust-lang#143773
Should have additional crater run to verify this fixes the issue.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustfmt
Relevant to the rustfmt team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 23, 2025
@jhpratt
jhpratt
commented
Oct 23, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=3
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 5d55418 has been approved by jhpratt
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 23, 2025
@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 5d55418 with merge 469357e...
@ZalatharZalathar
mentioned this pull request
Oct 23, 2025
 Merged

@bors
bors
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jhpratt

Pushing 469357e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 23, 2025
@bors
bors
merged commit 469357e
into
rust-lang:masterOct 23, 2025

12 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 23, 2025
@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#134316Add String::replace_first and String::replace_lastb14dfec6484e1986bea1f06780eb440d3a73d5ff (link)
#147713Retire ast::TyAliasWhereClauses.a309d0136b09c891ab29627879b175579eccc297 (link)
#148011Revert constification of AsRef for Cow due to inference f…6ae63b7059954ee4d7adec6ba973621b339ba3f9 (link)
previous master: 4b3ba5844e
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 23, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4b3ba58 (parent) -> 469357e (this PR)
Test differences
Show 120 test diffs

Stage 1
  • string::test_replace_first: [missing] -> pass (J0)
  • string::test_replace_last: [missing] -> pass (J0)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J3)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J3)
Stage 2
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-1.rs: [missing] -> pass (J1)
  • [ui] tests/ui/where-clauses/cfg-attr-issue-138010-2.rs: [missing] -> pass (J1)
  • string::test_replace_first: [missing] -> pass (J2)
  • string::test_replace_last: [missing] -> pass (J2)
Additionally, 112 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 469357eb48d1c1b583386785ed0f846b9e7e0904 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6096.5s -> 8250.5s (35.3%)
  2. dist-aarch64-apple: 5767.2s -> 7136.7s (23.7%)
  3. pr-check-1: 1762.9s -> 1507.3s (-14.5%)
  4. dist-various-2: 1967.1s -> 2189.1s (11.3%)
  5. i686-msvc-1: 10440.6s -> 9428.9s (-9.7%)
  6. pr-check-2: 2350.1s -> 2570.5s (9.4%)
  7. dist-apple-various: 3467.7s -> 3766.1s (8.6%)
  8. x86_64-gnu-llvm-20-2: 5960.0s -> 5460.8s (-8.4%)
  9. aarch64-apple: 6923.8s -> 7469.2s (7.9%)
  10. dist-aarch64-msvc: 6133.2s -> 5676.6s (-7.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@borsbors
mentioned this pull request
Oct 23, 2025
 Merged

@rust-timer
rust-timer
commented
Oct 23, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (469357e): comparison URL.
Overall result: ❌ regressions - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		0.1%[0.1%, 0.1%]1
Regressions ❌ 
 (secondary)		0.1%[0.1%, 0.1%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)0.1%[0.1%, 0.1%]1
Max RSS (memory usage)
Results (primary -0.4%, secondary -1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.0%[2.0%, 2.0%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-1.6%[-2.1%, -1.1%]2
Improvements ✅ 
 (secondary)		-1.1%[-1.1%, -1.1%]1
All ❌✅ (primary)-0.4%[-2.1%, 2.0%]3
Cycles
Results (primary 2.1%, secondary -3.2%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-3.2%[-3.9%, -2.5%]2
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.933s -> 474.879s (-0.01%)
Artifact size: 390.48 MiB -> 390.43 MiB (-0.01%)
@jhpratt
jhpratt
deleted the

rollup-aglren3

branch
October 23, 2025 14:28
@github-actionsgithub-actionsBot
mentioned this pull request
Oct 30, 2025
 Closed

flip1995 pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 31, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8d15b5f
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 8, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
8c08165
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
fc71a0c
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Nov 30, 2025
@bors
Auto merge ofrust-lang#148014- jhpratt:rollup-aglren3, r=jhpratt
0b11b9b
Rollup of 3 pull requests
Successful merges:
- rust-lang#134316 (Add `String::replace_first` and `String::replace_last`)
- rust-lang#147713 (Retire ast::TyAliasWhereClauses.)
- rust-lang#148011 (Revert constification of `AsRef for Cow` due to inference failure )
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustfmtRelevant to the rustfmt team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jhpratt@bors@rust-timer@rustbot@WilliamVenner@clarfonthey@cjgillot