Skip to content

dangling pointer from temp cleanup - #148490

Merged
bors merged 1 commit into
rust-lang:mainfrom
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged

dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom
hkBst:dangling-ptr-lint-2

Conversation

@hkBst

@hkBsthkBst commented Nov 4, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Continuation of #148348
r? @Urgau

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 4, 2025
@rustbot

rustbot commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau reviewed Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl Outdated
Comment threadcompiler/rustc_lint/messages.ftl Outdated
Comment threadcompiler/rustc_lint/messages.ftl Outdated
@UrgauUrgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2025
@hkBst

hkBst commented Nov 5, 2025

Copy link
Copy Markdown
MemberAuthor

BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels

Should probably change a lot of these helps to notes...

@hkBst

hkBst commented Nov 5, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2025
Urgau
Urgau reviewed Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl Outdated
.note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
.note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement

@UrgauUrgauNov 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?

dangling pointer created because {$ty} temporary is dropped at end of statement

@hkBsthkBstNov 7, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?

@UrgauUrgauNov 7, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.

@hkBsthkBstNov 28, 2025

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@UrgauUrgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed the dangling-ptr-lint-2 branch 2 times, most recently from cf34e89 to 6d9c94cCompareNovember 28, 2025 12:22
@hkBst

hkBst commented Nov 28, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2025
@rustbot

rustbot commented Dec 14, 2025

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@Urgau

Urgau commented Dec 14, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Dec 14, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit cab9114 has been approved by Urgau

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 14, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 14, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 14, 2025
Closed
@hkBst

hkBst commented Dec 14, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 14, 2025
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 14, 2025
Merged
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit d7a18fc into rust-lang:mainDec 15, 2025
11 checks passed
@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 15, 2025
@rustbotrustbot added this to the 1.94.0 milestone Dec 15, 2025
rust-timer added a commit that referenced this pull request Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst deleted the dangling-ptr-lint-2 branch December 15, 2025 09:02
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
dangling pointer from temp cleanup by hkBst · Pull Request #148490 · rust-lang/rust · GitHub
Skip to content
dangling pointer from temp cleanup - #148490
Merged
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Dec 15, 2025
Merged
dangling pointer from temp cleanup#148490
bors merged 1 commit into
rust-lang:mainfrom 
hkBst:dangling-ptr-lint-2
Conversation
@hkBst
@hkBsthkBst
commented
Nov 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
Continuation of #148348

r? @Urgau
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 4, 2025
@rustbot
rustbot
commented
Nov 4, 2025

Copy link


Copy Markdown

Collaborator
r? @lcnr
rustbot has assigned @lcnr.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@rustbotrustbot
assigned Urgau and unassigned lcnrNov 4, 2025
Urgau
Urgau
reviewed
Nov 4, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

Comment threadcompiler/rustc_lint/messages.ftl
Outdated

@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 4, 2025
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
BTW help vs note: help should be used to show changes the user can possibly make to fix the problem. note should be used for everything else, such as other context, information and facts, online resources to read, etc. -- https://rustc-dev-guide.rust-lang.org/diagnostics.html#diagnostic-levels
Should probably change a lot of these helps to notes...
@hkBst
hkBst
commented
Nov 5, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 5, 2025
Urgau
Urgau
reviewed
Nov 7, 2025
View reviewed changes
Comment threadcompiler/rustc_lint/messages.ftl
Outdated

 .note_safe = a dangling pointer is safe, but dereferencing one is undefined behavior
 .note_more_info = for more information, see <https://doc.rust-lang.org/reference/destructors.html>

lint_dangling_pointers_from_temporaries = dangling pointer because temporary `{$ty}` is dropped at end of statement
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a native English speaker but I think it's missing a word that links "dangling pointer" and "because temporary [...]", maybe "created" or "made"?
dangling pointer created because {$ty} temporary is dropped at end of statement
@hkBsthkBstNov 7, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there is an implied "there is a" at the beginning, but I suppose instead of "dangling pointer", "pointer is dangling" is not that much longer. Would that make it better?
@UrgauUrgauNov 7, 2025

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that works to.
@hkBsthkBstNov 28, 2025

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@rust-cloud-vms
rust-cloud-vmsBotforce-pushed
the
dangling-ptr-lint-2
branch
2 times, most recently
from
cf34e89 to
6d9c94cCompareNovember 28, 2025 12:22
@hkBst
hkBst
commented
Nov 28, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 28, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@UrgauUrgau
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 3, 2025
@rustbot
rustbot
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@Urgau
Urgau
commented
Dec 14, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup
@bors
bors
commented
Dec 14, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit cab9114 has been approved by Urgau
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Dec 14, 2025
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
768fefc
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? `@Urgau`
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#148490- hkBst:dangling-ptr-lint-2, r=Urgau
1a53c25
dangling pointer from temp cleanup
Continuation of rust-lang#148348
r? ``@Urgau``
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Closed

@hkBst
hkBst
commented
Dec 14, 2025

Copy link


Copy Markdown

MemberAuthor
@rustbot ready
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 14, 2025
bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr
mentioned this pull request
Dec 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit
that referenced
this pull request
Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit d7a18fc
into
rust-lang:mainDec 15, 2025

11 checks passed

@rustbotrustbot
removed
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Dec 15, 2025
@rustbotrustbot
added this to the 1.94.0 milestone
Dec 15, 2025
rust-timer added a commit
that referenced
this pull request
Dec 15, 2025
@rust-timer
Unrolled build for#148490
3626059
Rollup merge of #148490 - hkBst:dangling-ptr-lint-2, r=Urgau
dangling pointer from temp cleanup
Continuation of #148348
r? `@Urgau`
@hkBst
hkBst
deleted the

dangling-ptr-lint-2

branch
December 15, 2025 09:02
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@UrgauUrgauUrgau approved these changes

Assignees

@UrgauUrgau

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

6 participants

@hkBst@rustbot@rust-log-analyzer@Urgau@bors@lcnr