Skip to content

Cleanup of attribute parsing errors - #149949

Merged
bors merged 6 commits into
rust-lang:mainfrom
JonathanBrouwer:error_cleanup
Dec 15, 2025
Merged

Cleanup of attribute parsing errors#149949
bors merged 6 commits into
rust-lang:mainfrom
JonathanBrouwer:error_cleanup

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Dec 13, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Removes the specific UnknownMetaItem and IllFormedAttributeInputLint errors.
Note that IllFormedAttributeInputLint is not a lint, contrary to its name

r? @jdonszelmann

@rustbot

rustbot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2025
jdonszelmann
jdonszelmann reviewed Dec 13, 2025
View reviewed changes
Comment threadcompiler/rustc_attr_parsing/src/attributes/macro_attrs.rs Outdated
jdonszelmann
jdonszelmann reviewed Dec 13, 2025
View reviewed changes
Comment threadtests/ui/attributes/invalid-macro-use.stderr Outdated
jdonszelmann
jdonszelmann reviewed Dec 13, 2025
View reviewed changes
Comment threadtests/ui/attributes/malformed-attrs.stderr Outdated
jdonszelmann
jdonszelmann reviewed Dec 13, 2025
View reviewed changes
Comment threadtests/ui/attributes/malformed-must_use.stderr
jdonszelmann
jdonszelmann requested changes Dec 13, 2025
View reviewed changes

@jdonszelmannjdonszelmann left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

View changes since this review

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025
@rustbot

rustbot commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@JonathanBrouwer

JonathanBrouwer commented Dec 13, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@jdonszelmann Good idea, I improved a bunch of the spans :)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
jdonszelmann
jdonszelmann reviewed Dec 13, 2025
View reviewed changes
Comment threadtests/ui/link-native-libs/link-attr-validation-late.stderr
| |
| expected this to be a list
|
= note: for more information, visit <https://doc.rust-lang.org/reference/items/external-blocks.html#the-link-attribute>

@jdonszelmannjdonszelmannDec 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm we don't give any actual usage examples here 🤔

@jdonszelmannjdonszelmannDec 13, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only the link

@JonathanBrouwerJonathanBrouwerDec 13, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is because of #149917
#[link] has too many examples so it decides not to show any.
I'm currently actually working on improving this system, this PR is the first in a series. I want to give more contextual usage examples.
Lets fix this in a future PR

jdonszelmann
jdonszelmann requested changes Dec 13, 2025
View reviewed changes

@jdonszelmannjdonszelmann left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there

View changes since this review

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025
@JonathanBrouwer

JonathanBrouwer commented Dec 13, 2025

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
@jdonszelmann

jdonszelmann commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2025
@JonathanBrouwer

JonathanBrouwer commented Dec 13, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=jdonszelmann rollup

@bors

bors commented Dec 13, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit ae39d3d has been approved by jdonszelmann

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 13, 2025
@JonathanBrouwer
Rollup merge ofrust-lang#149949- JonathanBrouwer:error_cleanup, r=j…
168820d
…donszelmann
Cleanup of attribute parsing errors
Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors.
Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name
r? `@jdonszelmann`
@JonathanBrouwerJonathanBrouwer mentioned this pull request Dec 13, 2025
Closed
bors added a commit that referenced this pull request Dec 13, 2025
@bors
Auto merge of#149953- JonathanBrouwer:rollup-7gjplg3, r=JonathanBro…
acae308
…uwer
Rollup of 5 pull requests
Successful merges:
- #148755 (Constify `DropGuard::dismiss` and trait impls)
- #148825 (Add SystemTime::{MIN, MAX})
- #149894 (Update to mdbook 0.5)
- #149930 (std: small `sys` refactor)
- #149949 (Cleanup of attribute parsing errors)
r? `@ghost`
`@rustbot` modify labels: rollup
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 13, 2025
@JonathanBrouwer
Rollup merge ofrust-lang#149949- JonathanBrouwer:error_cleanup, r=j…
0d0cefa
…donszelmann
Cleanup of attribute parsing errors
Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors.
Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name
r? ``@jdonszelmann``
@JonathanBrouwerJonathanBrouwer mentioned this pull request Dec 13, 2025
Closed
bors added a commit that referenced this pull request Dec 13, 2025
@bors
Auto merge of#149956- JonathanBrouwer:rollup-97pdz0g, r=JonathanBro…
b8e7a40
…uwer
Rollup of 5 pull requests
Successful merges:
- #148755 (Constify `DropGuard::dismiss` and trait impls)
- #148825 (Add SystemTime::{MIN, MAX})
- #149894 (Update to mdbook 0.5)
- #149949 (Cleanup of attribute parsing errors)
- #149955 (Fix typo in armv7a-vex-v5 documentation)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of#149956- JonathanBrouwer:rollup-97pdz0g, r=JonathanBro…
429f5e1
…uwer
Rollup of 5 pull requests
Successful merges:
- #148755 (Constify `DropGuard::dismiss` and trait impls)
- #148825 (Add SystemTime::{MIN, MAX})
- #149894 (Update to mdbook 0.5)
- #149949 (Cleanup of attribute parsing errors)
- #149955 (Fix typo in armv7a-vex-v5 documentation)
r? `@ghost`
`@rustbot` modify labels: rollup
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Dec 14, 2025
@ChrisDenton
Rollup merge ofrust-lang#149949- JonathanBrouwer:error_cleanup, r=j…
c2ee29d
…donszelmann
Cleanup of attribute parsing errors
Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors.
Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name
r? ```@jdonszelmann```
@ChrisDentonChrisDenton mentioned this pull request Dec 14, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#149949- JonathanBrouwer:error_cleanup, r=j…
7ad4964
…donszelmann
Cleanup of attribute parsing errors
Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors.
Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name
r? ````@jdonszelmann````
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 14, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge ofrust-lang#149949- JonathanBrouwer:error_cleanup, r=j…
21974c5
…donszelmann
Cleanup of attribute parsing errors
Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors.
Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name
r? `````@jdonszelmann`````
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 14, 2025
Closed
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of#149993- matthiaskrgr:rollup-4jhq5oa, r=matthiaskrgr
c2c72b8
Rollup of 7 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148196 (Implement create_dir_all() to operate iteratively instead of recursively)
- #148490 (dangling pointer from temp cleanup)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
Failed merges:
- #148847 (Share Timespec between Unix and Hermit)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 14, 2025
Merged
bors added a commit that referenced this pull request Dec 14, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
0f12db2
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 15, 2025
@bors
Auto merge of#149999- matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
52fda2e
Rollup of 8 pull requests
Successful merges:
- #146794 (std: reorganize pipe implementations)
- #148490 (dangling pointer from temp cleanup)
- #149837 (Update `wrapping_sh[lr]` docs and examples)
- #149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- #149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- #149949 (Cleanup of attribute parsing errors)
- #149969 (don't use no_main and no_core to test IBT)
- #149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 185f7dc into rust-lang:mainDec 15, 2025
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Dec 15, 2025
rust-timer added a commit that referenced this pull request Dec 15, 2025
@rust-timer
Unrolled build for#149949
6385287
Rollup merge of #149949 - JonathanBrouwer:error_cleanup, r=jdonszelmann
Cleanup of attribute parsing errors
Removes the specific `UnknownMetaItem` and `IllFormedAttributeInputLint` errors.
Note that `IllFormedAttributeInputLint` is not a lint, contrary to its name
r? ``````@jdonszelmann``````
@JonathanBrouwerJonathanBrouwer mentioned this pull request Dec 15, 2025
Merged
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
@bors
Auto merge of #149999 - matthiaskrgr:rollup-irr8kqi, r=matthiaskrgr
705bbc9
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#146794 (std: reorganize pipe implementations)
- rust-lang/rust#148490 (dangling pointer from temp cleanup)
- rust-lang/rust#149837 (Update `wrapping_sh[lr]` docs and examples)
- rust-lang/rust#149864 (std: Don't use `linkat` on the `wasm32-wasi*` targets)
- rust-lang/rust#149885 (replace addr_of_mut with &raw mut in maybeuninit docs)
- rust-lang/rust#149949 (Cleanup of attribute parsing errors)
- rust-lang/rust#149969 (don't use no_main and no_core to test IBT)
- rust-lang/rust#149998 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdonszelmannjdonszelmannjdonszelmann requested changes

Assignees

@jdonszelmannjdonszelmann

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer@rustbot@jdonszelmann@bors@rust-log-analyzer