Add typo suggestion for a misspelt Cargo environment variable by chenyukang · Pull Request #148559 · rust-lang/rust

chenyukang · 2025-11-06T02:49:47Z

rustbot · 2025-11-06T02:49:52Z

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

chenyukang · 2025-11-06T02:49:47Z

Fixes#148439

rustbot · 2025-11-06T02:49:52Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

jieyouxu · 2025-11-06T05:04:18Z

+const KNOWN_CARGO_VARS: &[&str] = &[
+ // List of known Cargo environment variables that are set for crates (not build scripts, OUT_DIR etc).
+ // See: https://doc.rust-lang.org/cargo/reference/environment-variables.html#environment-variables-cargo-sets-for-crates


Discussion (non-blocking): I have two reservations about making this suggestion:
Wouldn't this depend on the specific cargo version?
Basically, what I was trying to get at, is that in principle I feel like rustc should not make assumptions about cargo (that is, rustc should not "know" about cargo's existence), because cargo isn't the only way to invoke rustc.
I guess I could be convinced by "well, most users do build with cargo", so don't consider this a hard-blocking concern.

I'm not sure, there is a similar list for this in rust-analyzer: https://github.com/chenyukang/rust/blob/702bf000a0b5062d8b5ced717a26d70919df6ba0/src/tools/rust-analyzer/crates/project-model/src/env.rs#L9-L49 , I guess there is a better and general way to keep it synced.
I agree rustc should not knowing details about cargo, I think it's ok since we need to check the prefix with CARGO_ of env:
https://github.com/rust-lang/rust/pull/148559/files#diff-0eaa1095d59f2f3d9c015005d15fd8f7cda13121a8404d77b2955fc5fcd40449R213, and it's a note but not code suggestions, it's maybe incorrect for rare scenarios.

Yeah, seems alright, was just curious to hear what you think.

Kivooeo

Some nits

View changes since this review

Kivooeo · 2025-11-06T18:01:53Z

@bors r+

bors · 2025-11-06T18:02:48Z

📌 Commit 3edd25f has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 12 pull requests Successful merges: - #145768 (Offload device) - #145992 (Stabilize `vec_deque_pop_if`) - #147416 (Early return if span is from expansion so we dont get empty span and ice later on) - #147808 (btree: cleanup difference, intersection, is_subset) - #148520 (style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`) - #148559 (Add typo suggestion for a misspelt Cargo environment variable) - #148567 (Fix incorrect precedence caused by range expression) - #148570 (Fix mismatched brackets in generated .dir-locals.el) - #148575 (fix dev guide link in rustc_query_system/dep_graph/README.md) - #148578 (core docs: add notes about availability of `Atomic*::from_mut_slice`) - #148603 (Backport 1.91.1 relnotes to main) - #148609 (Sync str::rsplit_once example with str::split_once) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

rustbot assigned fee1-dead Nov 6, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch 2 times, most recently from 48c2fbb to 1f8b6daCompare November 6, 2025 04:14

jieyouxu reviewed Nov 6, 2025
View reviewed changes

Urgau reviewed Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/messages.ftl Outdated

chenyukang force-pushed the yukang-fix-148439-env branch from 1f8b6da to ad471f4Compare November 6, 2025 09:44

This comment has been minimized.
Sign in to view

Kivooeo approved these changes Nov 6, 2025
View reviewed changes

Comment threadcompiler/rustc_builtin_macros/src/env.rs Outdated
Comment threadtests/ui/env-macro/env-cargo-var-typo-issue-148439.rs
Comment threadcompiler/rustc_builtin_macros/src/env.rs

chenyukang force-pushed the yukang-fix-148439-env branch from ad471f4 to 760e803Compare November 6, 2025 12:13

This comment has been minimized.
Sign in to view

chenyukang force-pushed the yukang-fix-148439-env branch from 760e803 to 553d580Compare November 6, 2025 12:24

This comment has been minimized.
Sign in to view

Add typo suggestion for a misspelt Cargo environment variable
3edd25f

chenyukang force-pushed the yukang-fix-148439-env branch from 553d580 to 3edd25fCompare November 6, 2025 15:11

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025

jhpratt mentioned this pull request Nov 7, 2025
Rollup of 12 pull requests #148624
Merged

bors merged commit 3186f21 into rust-lang:masterNov 7, 2025
11 checks passed

rustbot added this to the 1.93.0 milestone Nov 7, 2025

rust-timer added a commit that referenced this pull request Nov 7, 2025
Unrolled build for#148559
b7c7195
Rollup merge of #148559 - chenyukang:yukang-fix-148439-env, r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes#148439

Uh oh!

Uh oh!

Conversation

chenyukang commented Nov 6, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 6, 2025

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kivooeo commented Nov 6, 2025

Uh oh!

bors commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

chenyukang commented Nov 6, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 6, 2025

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Kivooeo commented Nov 6, 2025

Uh oh!

bors commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

chenyukang commented Nov 6, 2025•
edited by rustbot
Loading

Kivooeo left a comment •
edited by rustbot
Loading

chenyukang commented Nov 6, 2025•
edited by rustbot
Loading

Kivooeo left a comment •
edited by rustbot
Loading

chenyukang commented Nov 6, 2025•
edited by rustbot
Loading

Kivooeo left a comment •
edited by rustbot
Loading

chenyukang commented Nov 6, 2025•
edited by rustbot
Loading