Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Rollup of 12 pull requests - #148624

Merged
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r
Nov 7, 2025
Merged

Rollup of 12 pull requests#148624
bors merged 24 commits into
rust-lang:masterfrom
jhpratt:rollup-is5je9r

Conversation

@jhpratt

@jhprattjhpratt commented Nov 7, 2025

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

GrigorenkoPVand others added 24 commits October 23, 2025 23:43
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
Offload device
LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it.
This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled.
WIP
r? ```@ghost```
…op_if, r=Amanieu
Stabilize `vec_deque_pop_if`
Tracking issue: rust-lang#135889Closesrust-lang#135889
Also fixes a typo mentioned in rust-lang#135889 (comment)
FCP: rust-lang#135889 (comment)
`@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp
r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on
Fixesrust-lang#147255
The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side
r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35
style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one`
For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`.
```rust
assert_eq!(0x10_u64.highest_one(), Some(4));
```
Instead of:
```rust
assert_eq!(0b10000_u64.highest_one(), Some(4));
```
rust-lang#145203
…r=Kivooeo
Add typo suggestion for a misspelt Cargo environment variable
Fixesrust-lang#148439
…rect-precedence, r=hkBst,Kivooeo
Fix incorrect precedence caused by range expression
Fixesrust-lang#148344
The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang
Fix mismatched brackets in generated .dir-locals.el
This caused Emacs to throw errors when opening files.
Introduced in 3fe3edb.
…adme-link, r=chenyukang
fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se
core docs: add notes about availability of `Atomic*::from_mut_slice`
See rust-lang#76314 (comment)
r? libs-api
…=pietroalbini
Backport 1.91.1 relnotes to main
Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbotrustbot added T-release Relevant to the release subteam, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 7, 2025
@jhpratt

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit c932d7c has been approved by jhpratt

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit c932d7c with merge 0bbef55...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jhpratt
Pushing 0bbef55 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 0bbef55 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@jhpratt
jhpratt deleted the rollup-is5je9r branch November 7, 2025 09:50
@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c90bcb9 (parent) -> 0bbef55 (this PR)

Test differences

Show 1886 test diffs

Stage 0

  • errors::verify_builtin_macros_asm_attribute_not_supported_71: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_explicit_register_name_67: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_70: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_67: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_75: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_noreturn_75: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pos_after_74: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_pure_combine_68: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J1)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J1)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J1)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J1)
  • errors::verify_builtin_macros_env_not_unicode_59: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J1)
  • errors::verify_builtin_macros_expected_comma_in_list_83: [missing] -> pass (J1)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_62: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_positional_after_named_61: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J1)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J1)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_87: pass -> [missing] (J1)
  • errors::verify_builtin_macros_naked_functions_testing_attribute_88: [missing] -> pass (J1)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J1)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J1)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J1)
  • errors::verify_builtin_macros_takes_no_arguments_84: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_case_non_item_65: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J1)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J1)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J1)

Stage 1

  • errors::verify_builtin_macros_asm_attribute_not_supported_72: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_72: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_duplicate_arg_73: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_explicit_register_name_66: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_76: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_mayunwind_77: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_modifier_invalid_71: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_mutually_exclusive_68: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_no_matched_argument_name_76: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_noreturn_74: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_77: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_opt_already_provided_78: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pos_after_73: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_pure_combine_69: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_pure_no_output_70: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_79: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_clobber_abi_80: [missing] -> pass (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_78: pass -> [missing] (J0)
  • errors::verify_builtin_macros_asm_unsupported_option_79: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_90: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_no_matches_91: [missing] -> pass (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_91: pass -> [missing] (J0)
  • errors::verify_builtin_macros_cfg_select_unreachable_92: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_defined_58: [missing] -> pass (J0)
  • errors::verify_builtin_macros_env_not_unicode_58: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_comma_in_list_82: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_89: pass -> [missing] (J0)
  • errors::verify_builtin_macros_expected_other_90: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_duplicate_arg_61: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_no_arg_named_63: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_requires_string_59: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_requires_string_60: [missing] -> pass (J0)
  • errors::verify_builtin_macros_format_unused_arg_63: pass -> [missing] (J0)
  • errors::verify_builtin_macros_format_unused_arg_64: [missing] -> pass (J0)
  • errors::verify_builtin_macros_non_generic_pointee_88: pass -> [missing] (J0)
  • errors::verify_builtin_macros_non_generic_pointee_89: [missing] -> pass (J0)
  • errors::verify_builtin_macros_only_one_argument_83: pass -> [missing] (J0)
  • errors::verify_builtin_macros_only_one_argument_84: [missing] -> pass (J0)
  • errors::verify_builtin_macros_proc_macro_attribute_only_usable_with_crate_type_86: [missing] -> pass (J0)
  • errors::verify_builtin_macros_source_utils_expected_item_87: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_bad_fn_65: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_bad_fn_66: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_case_non_item_64: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_invalid_81: [missing] -> pass (J0)
  • errors::verify_builtin_macros_test_runner_nargs_81: pass -> [missing] (J0)
  • errors::verify_builtin_macros_test_runner_nargs_82: [missing] -> pass (J0)
  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/env-macro/env-cargo-var-typo-issue-148439.rs: [missing] -> pass (J2)
  • [ui] tests/ui/macros/macro-expansion-empty-span-147255.rs: [missing] -> pass (J2)

(and 44 additional test diffs)

Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 191.5s -> 296.8s (+55.0%)
  2. x86_64-rust-for-linux: 2937.0s -> 2544.0s (-13.4%)
  3. aarch64-apple: 10462.4s -> 9218.9s (-11.9%)
  4. x86_64-gnu-distcheck: 8110.3s -> 7217.3s (-11.0%)
  5. dist-aarch64-apple: 7344.7s -> 6568.6s (-10.6%)
  6. dist-aarch64-msvc: 5588.5s -> 6164.9s (+10.3%)
  7. dist-x86_64-apple: 8879.3s -> 7985.9s (-10.1%)
  8. pr-check-2: 2486.9s -> 2252.6s (-9.4%)
  9. x86_64-msvc-1: 9180.4s -> 8514.4s (-7.3%)
  10. dist-x86_64-illumos: 5893.7s -> 5486.7s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#145768Offload device64dc21ccb30428b6e7324567b82a9494ae7b06ac (link)
#145992Stabilize vec_deque_pop_iffe01a2cb16f933d25b7a99e1798641613c880b73 (link)
#147416Early return if span is from expansion so we dont get empty…b5e490b8f9cdeff391af28ef324e218d9a6973f5 (link)
#147808btree: cleanup difference, intersection, is_subset5c3d3275e6ebe39a376c373eae818716ccdef34f (link)
#148520style: Use binary literals instead of hex literals in docte…5c7e2fe54d9e117037e3fee6062fd33de2399fa5 (link)
#148559Add typo suggestion for a misspelt Cargo environment variab…b7c71958896063aabd4e32d043245ca9a0125c6c (link)
#148567Fix incorrect precedence caused by range expression394676a6e4e3f50dcc67ba48d6a2e8760bf4634c (link)
#148570Fix mismatched brackets in generated .dir-locals.el765bb88bb82dabdb3d6e6c0b2a63d70aad018b5b (link)
#148575fix dev guide link in rustc_query_system/dep_graph/README.md41056bbca19dd31322a2835c5d7b10a55514e33b (link)
#148578core docs: add notes about availability of `Atomic*::from_m…1d93179cac6a9cc42e9fb4754fdcf2db5c07ac0c (link)
#148603Backport 1.91.1 relnotes to main1f03f223b61513366dae4dd3f74b490693b369ae (link)
#148609Sync str::rsplit_once example with str::split_once9d954f0899c8e08429cd41ce848f10ab573ef752 (link)

previous master: c90bcb9571

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0bbef55): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.3%[-0.3%, -0.3%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.3%[-0.3%, -0.3%]1

Max RSS (memory usage)

Results (primary 0.8%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
4.1%[4.1%, 4.1%]1
Regressions ❌
(secondary)
0.9%[0.9%, 0.9%]1
Improvements ✅
(primary)
-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)0.8%[-2.4%, 4.1%]2

Cycles

Results (primary -2.6%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-2.6%[-2.6%, -2.6%]1
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)-2.6%[-2.6%, -2.6%]1

Binary size

Results (primary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.1%[-0.1%, -0.1%]1
Improvements ✅
(secondary)
--0
All ❌✅ (primary)-0.1%[-0.1%, -0.1%]1

Bootstrap: 475.185s -> 475.138s (-0.01%)
Artifact size: 390.81 MiB -> 390.81 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-releaseRelevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

15 participants

@jhpratt@bors@rust-timer@rustbot@GrigorenkoPV@hkBst@ZuseZ4@chenyukang@sorairolake@TomFryersMidsummer@vyacheslavhere@WaffleLapkin@emilyalbini@AMDmi3@Kivooeo