Skip to content

Constify ManuallyDrop::take - #148752

Merged
bors merged 2 commits into
rust-lang:mainfrom
nxsaken:const_manually_drop_take
Nov 17, 2025
Merged

Constify ManuallyDrop::take#148752
bors merged 2 commits into
rust-lang:mainfrom
nxsaken:const_manually_drop_take

Conversation

@nxsaken

@nxsakennxsaken commented Nov 9, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Feature: const_manually_drop_take
Tracking issue: #148773

This PR constifies ManuallyDrop::take.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 9, 2025
@rustbot

rustbot commented Nov 9, 2025

Copy link
Copy Markdown
Collaborator

r? @scottmcm

rustbot has assigned @scottmcm.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nxsakennxsaken mentioned this pull request Nov 9, 2025
Merged
@scottmcm

scottmcm commented Nov 9, 2025

Copy link
Copy Markdown
Member

As unstable? Deal 👍

@bors r+ rollup

@bors

bors commented Nov 9, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit fc4056e has been approved by scottmcm

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
@nxsaken

nxsaken commented Nov 10, 2025

Copy link
Copy Markdown
ContributorAuthor

@scottmcm I need to create a tracking issue before merging

@nxsakennxsaken mentioned this pull request Nov 10, 2025
Open
3 tasks
@nxsaken

nxsaken commented Nov 10, 2025

Copy link
Copy Markdown
ContributorAuthor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 10, 2025
@nxsaken

nxsaken commented Nov 10, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 10, 2025
@scottmcm

scottmcm commented Nov 17, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 1d9be66 has been approved by scottmcm

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025
JaclynCodes added a commit to JaclynCodes/rust that referenced this pull request Nov 17, 2025
@JaclynCodes
Rollup merge ofrust-lang#148752- nxsaken:const_manually_drop_take, …
092c13f
…r=scottmcm
Constify `ManuallyDrop::take`
Feature: `const_manually_drop_take`
Tracking issue: rust-lang#148773
This PR constifies `ManuallyDrop::take`.
@JaclynCodesJaclynCodes mentioned this pull request Nov 17, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 17, 2025
@Zalathar
Rollup merge ofrust-lang#148752- nxsaken:const_manually_drop_take, …
6c8a265
…r=scottmcm
Constify `ManuallyDrop::take`
Feature: `const_manually_drop_take`
Tracking issue: rust-lang#148773
This PR constifies `ManuallyDrop::take`.
@ZalatharZalathar mentioned this pull request Nov 17, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 17, 2025
@Zalathar
Rollup merge ofrust-lang#148752- nxsaken:const_manually_drop_take, …
e0dc8d0
…r=scottmcm
Constify `ManuallyDrop::take`
Feature: `const_manually_drop_take`
Tracking issue: rust-lang#148773
This PR constifies `ManuallyDrop::take`.
@ZalatharZalathar mentioned this pull request Nov 17, 2025
Merged
bors added a commit that referenced this pull request Nov 17, 2025
@bors
Auto merge of#149013- Zalathar:rollup-io1ddhc, r=Zalathar
cc328c1
Rollup of 11 pull requests
Successful merges:
- #148505 (add larger test for `proc_macro` `FromStr` implementations)
- #148752 (Constify `ManuallyDrop::take`)
- #148757 (Constify `mem::take`)
- #148855 (Error if an autodiff user does not set lto=fat)
- #148912 (add note to `lines` docs about empty str behavior)
- #148958 (Run codegen tests on a 32-bit target in PR CI)
- #148994 (Abi compatibility test cleanup)
- #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
- #149004 (compiletest: Avoid race condition in file deletion)
- #149008 (triagebot: remove jsha from notifications for rustdoc HTML)
- #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit dd9b8e6 into rust-lang:mainNov 17, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 17, 2025
rust-timer added a commit that referenced this pull request Nov 17, 2025
@rust-timer
Unrolled build for#148752
05f7da0
Rollup merge of #148752 - nxsaken:const_manually_drop_take, r=scottmcm
Constify `ManuallyDrop::take`
Feature: `const_manually_drop_take`
Tracking issue: #148773
This PR constifies `ManuallyDrop::take`.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 17, 2025
@bors
Auto merge of #149013 - Zalathar:rollup-io1ddhc, r=Zalathar
3ac1147
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations)
- rust-lang/rust#148752 (Constify `ManuallyDrop::take`)
- rust-lang/rust#148757 (Constify `mem::take`)
- rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat)
- rust-lang/rust#148912 (add note to `lines` docs about empty str behavior)
- rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI)
- rust-lang/rust#148994 (Abi compatibility test cleanup)
- rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
- rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion)
- rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML)
- rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)
r? `@ghost`
`@rustbot` modify labels: rollup
@rustbotrustbot added S-tracking-ready-to-stabilize Status: This is ready to stabilize; it may need a stabilization report and a PR and removed S-tracking-ready-to-stabilize Status: This is ready to stabilize; it may need a stabilization report and a PR labels Nov 17, 2025
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@Zalathar
Rollup merge ofrust-lang#148752- nxsaken:const_manually_drop_take, …
22ede45
…r=scottmcm
Constify `ManuallyDrop::take`
Feature: `const_manually_drop_take`
Tracking issue: rust-lang#148773
This PR constifies `ManuallyDrop::take`.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge ofrust-lang#149013- Zalathar:rollup-io1ddhc, r=Zalathar
9f54f0d
Rollup of 11 pull requests
Successful merges:
- rust-lang#148505 (add larger test for `proc_macro` `FromStr` implementations)
- rust-lang#148752 (Constify `ManuallyDrop::take`)
- rust-lang#148757 (Constify `mem::take`)
- rust-lang#148855 (Error if an autodiff user does not set lto=fat)
- rust-lang#148912 (add note to `lines` docs about empty str behavior)
- rust-lang#148958 (Run codegen tests on a 32-bit target in PR CI)
- rust-lang#148994 (Abi compatibility test cleanup)
- rust-lang#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
- rust-lang#149004 (compiletest: Avoid race condition in file deletion)
- rust-lang#149008 (triagebot: remove jsha from notifications for rustdoc HTML)
- rust-lang#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@scottmcmscottmcm

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nxsaken@rustbot@scottmcm@bors