Skip to content

compiletest: Remove the "wasm32-bare" alias for wasm32-unknown-unknown - #149010

Merged
bors merged 1 commit into
rust-lang:mainfrom
Zalathar:wasm32-bare
Nov 17, 2025
Merged

compiletest: Remove the "wasm32-bare" alias for wasm32-unknown-unknown#149010
bors merged 1 commit into
rust-lang:mainfrom
Zalathar:wasm32-bare

Conversation

@Zalathar

@ZalatharZalathar commented Nov 17, 2025

Copy link
Copy Markdown
Member

This "wasm32-bare" alias, understood by compiletest's //@ ignore-wasm32-bare and //@ only-wasm32-bare directives, dates all the way back to the original introduction of the wasm32-unknown-unknown target in #45905.

But there is no compelling reason to use an alias instead of the full target name.

r? jieyouxu

There is no compelling reason to use this alias instead of the full target
name.
@rustbot

Copy link
Copy Markdown
Collaborator

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rustbotrustbot added A-compiletest Area: The compiletest test runner A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jieyouxu

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 31902f3 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2025
@ZalatharZalathar mentioned this pull request Nov 17, 2025
bors added a commit that referenced this pull request Nov 17, 2025
Rollup of 11 pull requests
Successful merges:
- #148505 (add larger test for `proc_macro` `FromStr` implementations)
- #148752 (Constify `ManuallyDrop::take`)
- #148757 (Constify `mem::take`)
- #148855 (Error if an autodiff user does not set lto=fat)
- #148912 (add note to `lines` docs about empty str behavior)
- #148958 (Run codegen tests on a 32-bit target in PR CI)
- #148994 (Abi compatibility test cleanup)
- #148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
- #149004 (compiletest: Avoid race condition in file deletion)
- #149008 (triagebot: remove jsha from notifications for rustdoc HTML)
- #149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 06304ef into rust-lang:mainNov 17, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Nov 17, 2025
Rollup merge of #149010 - Zalathar:wasm32-bare, r=jieyouxu
compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`
- Follow-up to #148969
This "wasm32-bare" alias, understood by compiletest's `//@ ignore-wasm32-bare` and `//@ only-wasm32-bare` directives, dates all the way back to the original introduction of the `wasm32-unknown-unknown` target in #45905.
But there is no compelling reason to use an alias instead of the full target name.
r? jieyouxu
@rustbotrustbot added this to the 1.93.0 milestone Nov 17, 2025
@Zalathar
Zalathar deleted the wasm32-bare branch November 17, 2025 11:23
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 17, 2025
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#148505 (add larger test for `proc_macro` `FromStr` implementations)
- rust-lang/rust#148752 (Constify `ManuallyDrop::take`)
- rust-lang/rust#148757 (Constify `mem::take`)
- rust-lang/rust#148855 (Error if an autodiff user does not set lto=fat)
- rust-lang/rust#148912 (add note to `lines` docs about empty str behavior)
- rust-lang/rust#148958 (Run codegen tests on a 32-bit target in PR CI)
- rust-lang/rust#148994 (Abi compatibility test cleanup)
- rust-lang/rust#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
- rust-lang/rust#149004 (compiletest: Avoid race condition in file deletion)
- rust-lang/rust#149008 (triagebot: remove jsha from notifications for rustdoc HTML)
- rust-lang/rust#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
Rollup of 11 pull requests
Successful merges:
- rust-lang#148505 (add larger test for `proc_macro` `FromStr` implementations)
- rust-lang#148752 (Constify `ManuallyDrop::take`)
- rust-lang#148757 (Constify `mem::take`)
- rust-lang#148855 (Error if an autodiff user does not set lto=fat)
- rust-lang#148912 (add note to `lines` docs about empty str behavior)
- rust-lang#148958 (Run codegen tests on a 32-bit target in PR CI)
- rust-lang#148994 (Abi compatibility test cleanup)
- rust-lang#148999 (Tweak Motor OS linker preset, fix `remote-test-server` for Motor OS)
- rust-lang#149004 (compiletest: Avoid race condition in file deletion)
- rust-lang#149008 (triagebot: remove jsha from notifications for rustdoc HTML)
- rust-lang#149010 (compiletest: Remove the "wasm32-bare" alias for `wasm32-unknown-unknown`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletestArea: The compiletest test runnerA-run-makeArea: port run-make Makefiles to rmake.rsA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@Zalathar@rustbot@jieyouxu@bors