Some resolve cleanups - #148808

Merged
bors merged 3 commits into
rust-lang:mainfrom
nnethercote:resolve-cleanups
Nov 14, 2025
Merged

Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom
nnethercote:resolve-cleanups

Conversation

@nnethercote

@nnethercotennethercote commented Nov 11, 2025

Copy link
Copy Markdown
Contributor

Minor improvements I found while looking over this code.

r? @petrochenkov

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 11, 2025
chenyukang
chenyukang reviewed Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang

chenyukang commented Nov 12, 2025

Copy link
Copy Markdown
Member

@bors r=chenyukang

@bors

bors commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 6217cad has been approved by chenyukang

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
petrochenkov
petrochenkov reviewed Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit that referenced this pull request Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors

bors commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 6217cad with merge 12eb261...

@petrochenkov

petrochenkov commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

@bors r- #148808 (comment)

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2025
@petrochenkov

petrochenkov commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

@bors cancel

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 12, 2025
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 12, 2025
@petrochenkov

petrochenkov commented Nov 12, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

We should keep the logic filling the exts, they will be needed in any case #148808 (comment).

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 12, 2025
@Kobzol

Kobzol commented Nov 12, 2025

Copy link
Copy Markdown
Member

@bors r- retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2025
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote

nnethercote commented Nov 12, 2025

Copy link
Copy Markdown
ContributorAuthor

We should keep the logic filling the exts

Done.

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 12, 2025
@petrochenkov

petrochenkov commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Thanks!
@bors r=chenyukang,petrochenkov

@bors

bors commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit b728064 has been approved by chenyukang,petrochenkov

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 13, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar mentioned this pull request Nov 13, 2025
Closed
bors added a commit that referenced this pull request Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar mentioned this pull request Nov 14, 2025
Merged
bors added a commit that referenced this pull request Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ee40e02 into rust-lang:mainNov 14, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 14, 2025
rust-timer added a commit that referenced this pull request Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote deleted the resolve-cleanups branch November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Some resolve cleanups - #148808
Merged
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Nov 14, 2025
Merged
Some resolve cleanups#148808
bors merged 3 commits into
rust-lang:mainfrom 
nnethercote:resolve-cleanups
Conversation
@nnethercote
@nnethercotennethercote
commented
Nov 11, 2025

Copy link


Copy Markdown

Contributor
Minor improvements I found while looking over this code.
r? @petrochenkov
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Nov 11, 2025
chenyukang
chenyukang
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_resolve/src/macros.rs
@chenyukang
chenyukang
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r=chenyukang
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 6217cad has been approved by chenyukang
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
petrochenkov
petrochenkov
reviewed
Nov 12, 2025
View reviewed changes
Comment threadcompiler/rustc_expand/src/expand.rs
bors added a commit
that referenced
this pull request
Nov 12, 2025
@bors
Auto merge of#148808- nnethercote:resolve-cleanups, r=chenyukang
12eb261
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@bors
bors
commented
Nov 12, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 6217cad with merge 12eb261...
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors r- #148808 (comment)
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025

Copy link


Copy Markdown

Contributor
@bors cancel
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Nov 12, 2025
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 12, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep the logic filling the exts, they will be needed in any case #148808 (comment).
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 12, 2025
@Kobzol
Kobzol
commented
Nov 12, 2025

Copy link


Copy Markdown

Member
@bors r- retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkovpetrochenkov
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 12, 2025
@nnethercote
Simplify Resolver::resolve_macro_path.
258a446
There are only two call sites, and three of the arguments are identical
at both call sites. This commit removes those arguments and renames the
method accordingly.
@nnethercote
Remove trace argument from resolve_macro_or_delegation_path.
8ece939
It's `true` at all call sites.
@nnethercote
Add a helpful comment to DeriveResolution::exts.
b728064
@nnethercote
nnethercote
commented
Nov 12, 2025

Copy link


Copy Markdown

ContributorAuthor
We should keep the logic filling the exts
Done.
@rustbot ready
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 12, 2025
@petrochenkov
petrochenkov
commented
Nov 13, 2025

Copy link


Copy Markdown

Contributor
Thanks!
@bors r=chenyukang,petrochenkov
@bors
bors
commented
Nov 13, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit b728064 has been approved by chenyukang,petrochenkov
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 13, 2025
GuillaumeGomez added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 13, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
148912b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `@petrochenkov`
@GuillaumeGomezGuillaumeGomez
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 13, 2025
@bors
Auto merge of#148903- GuillaumeGomez:rollup-hxsp81c, r=GuillaumeGomez
9a79a27
Rollup of 4 pull requests
Successful merges:
- #148587 (stabilize duration_from_nanos_u128)
- #148638 (Fix ICE for repr simd on non struct)
- #148808 (Some resolve cleanups)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
e6abafb
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``@petrochenkov``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
720f885
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```@petrochenkov```
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
4e7a1da
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ````@petrochenkov````
@ZalatharZalathar
mentioned this pull request
Nov 13, 2025
 Closed

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148927- Zalathar:rollup-fpodxsi, r=Zalathar
323450f
Rollup of 14 pull requests
Successful merges:
- #146978 (Emit error when using path-segment keyword as cfg pred)
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
b621b1c
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? `````@petrochenkov`````
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
@Zalathar
Rollup merge ofrust-lang#148808- nnethercote:resolve-cleanups, r=ch…
017827b
…enyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ``````@petrochenkov``````
@ZalatharZalathar
mentioned this pull request
Nov 14, 2025
 Merged

bors added a commit
that referenced
this pull request
Nov 14, 2025
@bors
Auto merge of#148931- Zalathar:rollup-yfyhpcw, r=Zalathar
c880acd
Rollup of 15 pull requests
Successful merges:
- #148543 (Correctly link to associated trait items in reexports)
- #148808 (Some resolve cleanups)
- #148812 (coverage: Associate hole spans with expansion tree nodes )
- #148826 (CStr docs: Fix CStr vs &CStr confusion)
- #148850 (Implement `Read::read_array`)
- #148867 (Refactor `Box::take`)
- #148870 (Remove unused LLVMModuleRef argument)
- #148878 (error when ABI does not support guaranteed tail calls)
- #148901 (Disable rustdoc-test-builder test partially for SGX target.)
- #148902 (add missing s390x target feature to std detect test)
- #148904 (waffle: stop watching codegen ssa)
- #148906 (Expose fmt::Arguments::from_str as unstable.)
- #148907 (add assembly test for infinite recursion with `become`)
- #148928 (Move & adjust some `!`-adjacent tests)
- #148929 (ignore `build-rust-analyzer` even if it's a symlink)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors
merged commit ee40e02
into
rust-lang:mainNov 14, 2025

11 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 14, 2025
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
@rust-timer
Unrolled build for#148808
950a966
Rollup merge of #148808 - nnethercote:resolve-cleanups, r=chenyukang,petrochenkov
Some resolve cleanups
Minor improvements I found while looking over this code.
r? ```````@petrochenkov```````
@nnethercote
nnethercote
deleted the

resolve-cleanups

branch
November 17, 2025 11:20
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chenyukangchenyukangchenyukang left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@nnethercote@chenyukang@bors@petrochenkov@Kobzol@rustbot