Uh oh!
There was an error while loading. Please reload this page.
add assembly test for infinite recursion with become - #148907
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
folkertdevforce-pushed
the
tail-call-infinite-recursion
branch
from
November 13, 2025 15:57
796f9bd to
ddebb62CompareWaffleLapkin
commented
Nov 13, 2025
Member
@bors r+ rollip |
bors
commented
Nov 13, 2025
Collaborator
WaffleLapkin
commented
Nov 13, 2025
Member
@bors rollup |
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 13, 2025
…rsion, r=WaffleLapkin add assembly test for infinite recursion with `become` tracking issue: rust-lang#112788fixesrust-lang#125698 Check that infinite recursion via `become` does not grow the stack (even on opt-level 0). The incomplete implementation of `become` did not guarantee that earlier. Although it's unlikely this ever regresses we may as well test it and close the issue. r? `@WaffleLapkin`
bors added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 14 pull requests Successful merges: - #146978 (Emit error when using path-segment keyword as cfg pred) - #148543 (Correctly link to associated trait items in reexports) - #148808 (Some resolve cleanups) - #148812 (coverage: Associate hole spans with expansion tree nodes ) - #148826 (CStr docs: Fix CStr vs &CStr confusion) - #148850 (Implement `Read::read_array`) - #148867 (Refactor `Box::take`) - #148870 (Remove unused LLVMModuleRef argument) - #148878 (error when ABI does not support guaranteed tail calls) - #148901 (Disable rustdoc-test-builder test partially for SGX target.) - #148902 (add missing s390x target feature to std detect test) - #148904 (waffle: stop watching codegen ssa) - #148906 (Expose fmt::Arguments::from_str as unstable.) - #148907 (add assembly test for infinite recursion with `become`) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 14, 2025
…rsion, r=WaffleLapkin add assembly test for infinite recursion with `become` tracking issue: rust-lang#112788fixesrust-lang#125698 Check that infinite recursion via `become` does not grow the stack (even on opt-level 0). The incomplete implementation of `become` did not guarantee that earlier. Although it's unlikely this ever regresses we may as well test it and close the issue. r? ``@WaffleLapkin``
bors added a commit
that referenced
this pull request
Nov 14, 2025
Rollup of 15 pull requests Successful merges: - #148543 (Correctly link to associated trait items in reexports) - #148808 (Some resolve cleanups) - #148812 (coverage: Associate hole spans with expansion tree nodes ) - #148826 (CStr docs: Fix CStr vs &CStr confusion) - #148850 (Implement `Read::read_array`) - #148867 (Refactor `Box::take`) - #148870 (Remove unused LLVMModuleRef argument) - #148878 (error when ABI does not support guaranteed tail calls) - #148901 (Disable rustdoc-test-builder test partially for SGX target.) - #148902 (add missing s390x target feature to std detect test) - #148904 (waffle: stop watching codegen ssa) - #148906 (Expose fmt::Arguments::from_str as unstable.) - #148907 (add assembly test for infinite recursion with `become`) - #148928 (Move & adjust some `!`-adjacent tests) - #148929 (ignore `build-rust-analyzer` even if it's a symlink) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Nov 14, 2025
Rollup merge of #148907 - folkertdev:tail-call-infinite-recursion, r=WaffleLapkin add assembly test for infinite recursion with `become` tracking issue: #112788fixes#125698 Check that infinite recursion via `become` does not grow the stack (even on opt-level 0). The incomplete implementation of `become` did not guarantee that earlier. Although it's unlikely this ever regresses we may as well test it and close the issue. r? ```@WaffleLapkin```
36 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #112788
fixes#125698
Check that infinite recursion via
becomedoes not grow the stack (even on opt-level 0). The incomplete implementation ofbecomedid not guarantee that earlier. Although it's unlikely this ever regresses we may as well test it and close the issue.r? @WaffleLapkin