Uh oh!
There was an error while loading. Please reload this page.
Fix ICE when collecting opaques from trait method declarations - #149168
Merged
Conversation
rustbot
commented
Nov 21, 2025
Collaborator
rustbot has assigned @JonathanBrouwer. Use |
tiif
reviewed
Nov 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
lapla-cogitoforce-pushed
the
ice_148622
branch
from
November 21, 2025 12:42
e0f1684 to
d340ea5Comparetiif
commented
Nov 22, 2025
Member
r? tiif |
tiif
commented
Nov 22, 2025
Member
Looks good, thanks! @bors r+ |
bors
commented
Nov 22, 2025
Collaborator
JonathanBrouwer
commented
Nov 22, 2025
Member
@bors rollup |
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 22, 2025
Fix ICE when collecting opaques from trait method declarations fixesrust-lang#148622 When using an `opaque` type as a `const` generic parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking in `hir_body_owned_by`.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
Fix ICE when collecting opaques from trait method declarations fixesrust-lang#148622 When using an `opaque` type as a `const` generic parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking in `hir_body_owned_by`.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
Fix ICE when collecting opaques from trait method declarations fixesrust-lang#148622 When using an `opaque` type as a `const` generic parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking in `hir_body_owned_by`.
bors added a commit
that referenced
this pull request
Nov 22, 2025
Rollup of 8 pull requests Successful merges: - #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts) - #148407 (Warn against calls which mutate an interior mutable `const`-item) - #149168 (Fix ICE when collecting opaques from trait method declarations) - #149170 (automate gpu offloading - part 1) - #149180 (Couple of refactors to SharedEmitter) - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - #149194 (Move safe computation out of unsafe block) - #149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
Fix ICE when collecting opaques from trait method declarations fixesrust-lang#148622 When using an `opaque` type as a `const` generic parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking in `hir_body_owned_by`.
bors added a commit
that referenced
this pull request
Nov 22, 2025
Rollup of 7 pull requests Successful merges: - #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts) - #148407 (Warn against calls which mutate an interior mutable `const`-item) - #149168 (Fix ICE when collecting opaques from trait method declarations) - #149170 (automate gpu offloading - part 1) - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - #149194 (Move safe computation out of unsafe block) - #149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 22, 2025
Fix ICE when collecting opaques from trait method declarations fixesrust-lang#148622 When using an `opaque` type as a `const` generic parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking in `hir_body_owned_by`.
This was referenced Nov 22, 2025
bors added a commit
that referenced
this pull request
Nov 22, 2025
Rollup of 9 pull requests Successful merges: - #148407 (Warn against calls which mutate an interior mutable `const`-item) - #149065 (Address annotate-snippets test differences) - #149072 (Fix the issue of unused assignment from MIR liveness checking) - #149077 (feat: Enable annotate-snippets' simd feature) - #149168 (Fix ICE when collecting opaques from trait method declarations) - #149180 (Couple of refactors to SharedEmitter) - #149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - #149194 (Move safe computation out of unsafe block) - #149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Nov 22, 2025
Rollup merge of #149168 - lapla-cogito:ice_148622, r=tiif Fix ICE when collecting opaques from trait method declarations fixes#148622 When using an `opaque` type as a `const` generic parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking in `hir_body_owned_by`.
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
Rollup of 9 pull requests Successful merges: - rust-lang/rust#148407 (Warn against calls which mutate an interior mutable `const`-item) - rust-lang/rust#149065 (Address annotate-snippets test differences) - rust-lang/rust#149072 (Fix the issue of unused assignment from MIR liveness checking) - rust-lang/rust#149077 (feat: Enable annotate-snippets' simd feature) - rust-lang/rust#149168 (Fix ICE when collecting opaques from trait method declarations) - rust-lang/rust#149180 (Couple of refactors to SharedEmitter) - rust-lang/rust#149185 (Handle cycles when checking impl candidates for `doc(hidden)`) - rust-lang/rust#149194 (Move safe computation out of unsafe block) - rust-lang/rust#149204 (Fix typo in HashMap performance comment) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#148622
When using an
opaquetype as aconstgeneric parameter, the compiler would attempt to collect TAIT from trait method declarations, causing an ICE by panicking inhir_body_owned_by.