Skip to content

Handle cycles when checking impl candidates for doc(hidden) - #149185

Merged
bors merged 1 commit into
rust-lang:mainfrom
Jules-Bertholet:fix-149092
Nov 22, 2025
Merged

Handle cycles when checking impl candidates for doc(hidden)#149185
bors merged 1 commit into
rust-lang:mainfrom
Jules-Bertholet:fix-149092

Conversation

@Jules-Bertholet

@Jules-BertholetJules-Bertholet commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Fixes#149092

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 21, 2025
@rustbot

rustbot commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Jules-BertholetJules-Bertholet mentioned this pull request Nov 21, 2025
Closed
@chenyukang

chenyukang commented Nov 22, 2025

Copy link
Copy Markdown
Member

Thanks!
@bors r=chenyukang

@bors

bors commented Nov 22, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f580357 has been approved by chenyukang

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2025
@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 22, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 22, 2025
@Zalathar
Rollup merge ofrust-lang#149185- Jules-Bertholet:fix-149092, r=chen…
81461bf
…yukang
Handle cycles when checking impl candidates for `doc(hidden)`
Fixesrust-lang#149092
@ZalatharZalathar mentioned this pull request Nov 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge ofrust-lang#149185- Jules-Bertholet:fix-149092, r=chen…
0b7e900
…yukang
Handle cycles when checking impl candidates for `doc(hidden)`
Fixesrust-lang#149092
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 22, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge ofrust-lang#149185- Jules-Bertholet:fix-149092, r=chen…
65619c8
…yukang
Handle cycles when checking impl candidates for `doc(hidden)`
Fixesrust-lang#149092
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 22, 2025
Closed
bors added a commit that referenced this pull request Nov 22, 2025
@bors
Auto merge of#149216- matthiaskrgr:rollup-xtf90h6, r=matthiaskrgr
c3c8d5c
Rollup of 8 pull requests
Successful merges:
- #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts)
- #148407 (Warn against calls which mutate an interior mutable `const`-item)
- #149168 (Fix ICE when collecting opaques from trait method declarations)
- #149170 (automate gpu offloading - part 1)
- #149180 (Couple of refactors to SharedEmitter)
- #149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
- #149194 (Move safe computation out of unsafe block)
- #149204 (Fix typo in HashMap performance comment)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge ofrust-lang#149185- Jules-Bertholet:fix-149092, r=chen…
6fce771
…yukang
Handle cycles when checking impl candidates for `doc(hidden)`
Fixesrust-lang#149092
@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 22, 2025
Closed
bors added a commit that referenced this pull request Nov 22, 2025
@bors
Auto merge of#149217- matthiaskrgr:rollup-eghiwzr, r=matthiaskrgr
8cb8621
Rollup of 7 pull requests
Successful merges:
- #147536 (Add `rust-mingw` component for `*-windows-gnullvm` hosts)
- #148407 (Warn against calls which mutate an interior mutable `const`-item)
- #149168 (Fix ICE when collecting opaques from trait method declarations)
- #149170 (automate gpu offloading - part 1)
- #149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
- #149194 (Move safe computation out of unsafe block)
- #149204 (Fix typo in HashMap performance comment)
r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 22, 2025
@matthiaskrgr
Rollup merge ofrust-lang#149185- Jules-Bertholet:fix-149092, r=chen…
5a47766
…yukang
Handle cycles when checking impl candidates for `doc(hidden)`
Fixesrust-lang#149092
This was referenced Nov 22, 2025
Closed
Merged
bors added a commit that referenced this pull request Nov 22, 2025
@bors
Auto merge of#149222- matthiaskrgr:rollup-cl428i7, r=matthiaskrgr
94b49fd
Rollup of 9 pull requests
Successful merges:
- #148407 (Warn against calls which mutate an interior mutable `const`-item)
- #149065 (Address annotate-snippets test differences)
- #149072 (Fix the issue of unused assignment from MIR liveness checking)
- #149077 (feat: Enable annotate-snippets' simd feature)
- #149168 (Fix ICE when collecting opaques from trait method declarations)
- #149180 (Couple of refactors to SharedEmitter)
- #149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
- #149194 (Move safe computation out of unsafe block)
- #149204 (Fix typo in HashMap performance comment)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit cb50c01 into rust-lang:mainNov 22, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 22, 2025
rust-timer added a commit that referenced this pull request Nov 22, 2025
@rust-timer
Unrolled build for#149185
cadad9c
Rollup merge of #149185 - Jules-Bertholet:fix-149092, r=chenyukang
Handle cycles when checking impl candidates for `doc(hidden)`
Fixes#149092
@Jules-Bertholet
Jules-Bertholet deleted the fix-149092 branch November 23, 2025 16:16
@apiraino

apiraino commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 27, 2025
@cuvipercuviper mentioned this pull request Dec 3, 2025
Merged
@cuvipercuviper modified the milestones: 1.93.0, 1.92.0Dec 3, 2025
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 3, 2025
bors added a commit that referenced this pull request Dec 3, 2025
@bors
Auto merge of#149572- cuviper:beta-next, r=cuviper
ac0aff2
[beta] backports
- rustdoc: Use configured target modifiers when collecting doctests #148068
- fix(rustdoc): Color doctest errors #148834
- Fix the issue of unused assignment from MIR liveness checking #149072
- Skip unused variables warning for unreachable code #149096
- In `BTreeMap::eq`, do not compare the elements if the sizes are different. #149125
- Handle cycles when checking impl candidates for `doc(hidden)` #149185
- Generalize branch references #148395
- only the commit updating CI scripts
- Change default branch references #148564
r? cuviper
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #149222 - matthiaskrgr:rollup-cl428i7, r=matthiaskrgr
1ed9df4
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#148407 (Warn against calls which mutate an interior mutable `const`-item)
- rust-lang/rust#149065 (Address annotate-snippets test differences)
- rust-lang/rust#149072 (Fix the issue of unused assignment from MIR liveness checking)
- rust-lang/rust#149077 (feat: Enable annotate-snippets' simd feature)
- rust-lang/rust#149168 (Fix ICE when collecting opaques from trait method declarations)
- rust-lang/rust#149180 (Couple of refactors to SharedEmitter)
- rust-lang/rust#149185 (Handle cycles when checking impl candidates for `doc(hidden)`)
- rust-lang/rust#149194 (Move safe computation out of unsafe block)
- rust-lang/rust#149204 (Fix typo in HashMap performance comment)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@chenyukangchenyukang

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

rustc nightly hangs with cross-crate trait bound issue involving pub use crate or extern crate self

7 participants

@Jules-Bertholet@rustbot@chenyukang@bors@apiraino@cuviper@theemathas