Skip to content

build-manifest: generate MSI and MINGW arrays from rustc - #149554

Merged
bors merged 1 commit into
rust-lang:mainfrom
mati865:build-manifest-more-gen
Dec 4, 2025
Merged

build-manifest: generate MSI and MINGW arrays from rustc#149554
bors merged 1 commit into
rust-lang:mainfrom
mati865:build-manifest-more-gen

Conversation

@mati865

@mati865mati865 commented Dec 2, 2025

Copy link
Copy Markdown
Member

An alternative to #149503

The arrays after generating:

❯ bat -n build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/build-manifest-e0236666c7c4187b/out/targets.rs | rg MSI -A14
136 static MSI_INSTALLERS: &[&str] = &[
137 "aarch64-pc-windows-gnullvm",
138 "aarch64-pc-windows-msvc",
139 "i686-pc-windows-gnu",
140 "i686-pc-windows-msvc",
141 "x86_64-pc-windows-gnu",
142 "x86_64-pc-windows-gnullvm",
143 "x86_64-pc-windows-msvc",
144 ];
145 static MINGW: &[&str] = &[
146 "aarch64-pc-windows-gnullvm",
147 "i686-pc-windows-gnu",
148 "x86_64-pc-windows-gnu",
149 "x86_64-pc-windows-gnullvm",
150 ];

r? @Mark-Simulacrum

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 2, 2025
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ rollup

Thanks!

@bors

bors commented Dec 4, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f4729f2 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Dec 4, 2025
…=Mark-Simulacrum
build-manifest: generate MSI and MINGW arrays from rustc
An alternative to rust-lang#149503
The arrays after generating:
```
❯ bat -n build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/build-manifest-e0236666c7c4187b/out/targets.rs | rg MSI -A14
136 static MSI_INSTALLERS: &[&str] = &[
137 "aarch64-pc-windows-gnullvm",
138 "aarch64-pc-windows-msvc",
139 "i686-pc-windows-gnu",
140 "i686-pc-windows-msvc",
141 "x86_64-pc-windows-gnu",
142 "x86_64-pc-windows-gnullvm",
143 "x86_64-pc-windows-msvc",
144 ];
145 static MINGW: &[&str] = &[
146 "aarch64-pc-windows-gnullvm",
147 "i686-pc-windows-gnu",
148 "x86_64-pc-windows-gnu",
149 "x86_64-pc-windows-gnullvm",
150 ];
```
r? `@Mark-Simulacrum`
@ZalatharZalathar mentioned this pull request Dec 4, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 4, 2025
…=Mark-Simulacrum
build-manifest: generate MSI and MINGW arrays from rustc
An alternative to rust-lang#149503
The arrays after generating:
```
❯ bat -n build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/build-manifest-e0236666c7c4187b/out/targets.rs | rg MSI -A14
136 static MSI_INSTALLERS: &[&str] = &[
137 "aarch64-pc-windows-gnullvm",
138 "aarch64-pc-windows-msvc",
139 "i686-pc-windows-gnu",
140 "i686-pc-windows-msvc",
141 "x86_64-pc-windows-gnu",
142 "x86_64-pc-windows-gnullvm",
143 "x86_64-pc-windows-msvc",
144 ];
145 static MINGW: &[&str] = &[
146 "aarch64-pc-windows-gnullvm",
147 "i686-pc-windows-gnu",
148 "x86_64-pc-windows-gnu",
149 "x86_64-pc-windows-gnullvm",
150 ];
```
r? ``@Mark-Simulacrum``
This was referenced Dec 4, 2025
bors added a commit that referenced this pull request Dec 4, 2025
Rollup of 12 pull requests
Successful merges:
- #147841 (Fix ICE when applying test macro to crate root)
- #149147 (Fix unused_assignments false positives from macros)
- #149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`)
- #149456 (std: don't call `current_os_id` from signal handler)
- #149501 (CTFE: avoid emitting a hard error on generic normalization failures)
- #149528 (reword error for invalid range patterns)
- #149539 (Additional test for uN::{gather,scatter}_bits)
- #149549 (Regression test for system register `ttbr0_el2`)
- #149550 (Disable native-lib for x check miri)
- #149554 (build-manifest: generate MSI and MINGW arrays from rustc)
- #149557 (c-variadic: bpf and spirv do not support c-variadic definitions)
- #149569 (Fix mailmap issue)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b63ef74 into rust-lang:mainDec 4, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Dec 4, 2025
rust-timer added a commit that referenced this pull request Dec 4, 2025
Rollup merge of #149554 - mati865:build-manifest-more-gen, r=Mark-Simulacrum
build-manifest: generate MSI and MINGW arrays from rustc
An alternative to #149503
The arrays after generating:
```
❯ bat -n build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/build/build-manifest-e0236666c7c4187b/out/targets.rs | rg MSI -A14
136 static MSI_INSTALLERS: &[&str] = &[
137 "aarch64-pc-windows-gnullvm",
138 "aarch64-pc-windows-msvc",
139 "i686-pc-windows-gnu",
140 "i686-pc-windows-msvc",
141 "x86_64-pc-windows-gnu",
142 "x86_64-pc-windows-gnullvm",
143 "x86_64-pc-windows-msvc",
144 ];
145 static MINGW: &[&str] = &[
146 "aarch64-pc-windows-gnullvm",
147 "i686-pc-windows-gnu",
148 "x86_64-pc-windows-gnu",
149 "x86_64-pc-windows-gnullvm",
150 ];
```
r? ```@Mark-Simulacrum```
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Dec 15, 2025
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#147841 (Fix ICE when applying test macro to crate root)
- rust-lang/rust#149147 (Fix unused_assignments false positives from macros)
- rust-lang/rust#149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`)
- rust-lang/rust#149456 (std: don't call `current_os_id` from signal handler)
- rust-lang/rust#149501 (CTFE: avoid emitting a hard error on generic normalization failures)
- rust-lang/rust#149528 (reword error for invalid range patterns)
- rust-lang/rust#149539 (Additional test for uN::{gather,scatter}_bits)
- rust-lang/rust#149549 (Regression test for system register `ttbr0_el2`)
- rust-lang/rust#149550 (Disable native-lib for x check miri)
- rust-lang/rust#149554 (build-manifest: generate MSI and MINGW arrays from rustc)
- rust-lang/rust#149557 (c-variadic: bpf and spirv do not support c-variadic definitions)
- rust-lang/rust#149569 (Fix mailmap issue)
r? `@ghost`
`@rustbot` modify labels: rollup
@mati865
mati865 deleted the build-manifest-more-gen branch February 19, 2026 21:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@mati865@Mark-Simulacrum@bors@rustbot