Uh oh!
There was an error while loading. Please reload this page.
c-variadic: bpf and spirv do not support c-variadic definitions - #149557
Merged
Conversation
rustbot
commented
Dec 2, 2025
Collaborator
|
folkertdevforce-pushed
the
c-variadic-not-supported
branch
from
December 2, 2025 20:26
2af7dca to
1f9013bCompareUrgau
reviewed
Dec 2, 2025
Uh oh!
There was an error while loading. Please reload this page.
folkertdevforce-pushed
the
c-variadic-not-supported
branch
from
December 3, 2025 00:03
1f9013b to
80a780fComparerustbot
commented
Dec 3, 2025
Collaborator
These commits modify compiler targets. |
folkertdevforce-pushed
the
c-variadic-not-supported
branch
from
December 3, 2025 00:06
80a780f to
695d2faComparefolkertdev
commented
Dec 3, 2025
Comment on lines
+1936
to
+1938
| // We don't know if the target supports c-variadic definitions, but we don't want | ||
| // to needlesly restrict custom target.json configurations. | ||
| Other(_) => true, |
ContributorAuthor
There was a problem hiding this comment.
This is kind of up for debate, but a custom target.json is kind of "here be dragons" already, and if the new target gets proper compiler support a choice still has to be made here.
| variadic_span: variadic_param.span, | ||
| target: &*self.sess.target.llvm_target, | ||
| }); | ||
| return; |
ContributorAuthor
There was a problem hiding this comment.
emitting other errors here doesn't seem useful when the target just does not support c-variadics.
This comment has been minimized.
This comment has been minimized.
folkertdevforce-pushed
the
c-variadic-not-supported
branch
from
December 3, 2025 00:36
695d2fa to
fe1855eCompare
This comment has been minimized.
This comment has been minimized.
folkertdevforce-pushed
the
c-variadic-not-supported
branch
from
December 3, 2025 10:33
fe1855e to
fc017ddComparerustbot
commented
Dec 3, 2025
Collaborator
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
workingjubilee
commented
Dec 3, 2025
Member
thanks! @bors r+ |
bors
commented
Dec 3, 2025
Collaborator
workingjubilee
commented
Dec 3, 2025
Member
@bors rollup |
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Dec 4, 2025
…d, r=workingjubilee c-variadic: bpf and spirv do not support c-variadic definitions tracking issue: rust-lang#44930 Emit a nice error message on bpf and spirv targets when a c-variadic function is defined. Spirv also does not support c-variadic calls, bpf appears to allow them. r? `@workingjubilee`
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 4, 2025
…d, r=workingjubilee c-variadic: bpf and spirv do not support c-variadic definitions tracking issue: rust-lang#44930 Emit a nice error message on bpf and spirv targets when a c-variadic function is defined. Spirv also does not support c-variadic calls, bpf appears to allow them. r? ``@workingjubilee``
This was referenced Dec 4, 2025
bors added a commit
that referenced
this pull request
Dec 4, 2025
Rollup of 12 pull requests Successful merges: - #147841 (Fix ICE when applying test macro to crate root) - #149147 (Fix unused_assignments false positives from macros) - #149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`) - #149456 (std: don't call `current_os_id` from signal handler) - #149501 (CTFE: avoid emitting a hard error on generic normalization failures) - #149528 (reword error for invalid range patterns) - #149539 (Additional test for uN::{gather,scatter}_bits) - #149549 (Regression test for system register `ttbr0_el2`) - #149550 (Disable native-lib for x check miri) - #149554 (build-manifest: generate MSI and MINGW arrays from rustc) - #149557 (c-variadic: bpf and spirv do not support c-variadic definitions) - #149569 (Fix mailmap issue) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Dec 4, 2025
Rollup merge of #149557 - folkertdev:c-variadic-not-supported, r=workingjubilee c-variadic: bpf and spirv do not support c-variadic definitions tracking issue: #44930 Emit a nice error message on bpf and spirv targets when a c-variadic function is defined. Spirv also does not support c-variadic calls, bpf appears to allow them. r? ```@workingjubilee```
4 tasks
github-actionsBot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Dec 15, 2025
Rollup of 12 pull requests Successful merges: - rust-lang/rust#147841 (Fix ICE when applying test macro to crate root) - rust-lang/rust#149147 (Fix unused_assignments false positives from macros) - rust-lang/rust#149183 (Use `TypingMode::PostAnalysis` in `try_evaluate_const`) - rust-lang/rust#149456 (std: don't call `current_os_id` from signal handler) - rust-lang/rust#149501 (CTFE: avoid emitting a hard error on generic normalization failures) - rust-lang/rust#149528 (reword error for invalid range patterns) - rust-lang/rust#149539 (Additional test for uN::{gather,scatter}_bits) - rust-lang/rust#149549 (Regression test for system register `ttbr0_el2`) - rust-lang/rust#149550 (Disable native-lib for x check miri) - rust-lang/rust#149554 (build-manifest: generate MSI and MINGW arrays from rustc) - rust-lang/rust#149557 (c-variadic: bpf and spirv do not support c-variadic definitions) - rust-lang/rust#149569 (Fix mailmap issue) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #44930
Emit a nice error message on bpf and spirv targets when a c-variadic function is defined. Spirv also does not support c-variadic calls, bpf appears to allow them.
r? @workingjubilee