adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file by paradoxicalguy · Pull Request #150368 · rust-lang/rust

paradoxicalguy · 2025-12-25T12:41:17Z

this adds the Ordering enum to minicore.rs.

consequently, this updates tests/assembly-llvm/rust-abi-arg-attr.rs to import minicore directly. previously, this test file contained traits like CopyClonePointeeSized, which were giving a duplicate lang item error, so replace those by importing minicore completely.

rustbot · 2025-12-25T12:41:20Z

This PR modifies tests/auxiliary/minicore.rs.

cc @jieyouxu

rustbot · 2025-12-25T12:41:22Z

Mark-Simulacrum is not on the review rotation at the moment.
They may take a while to respond.

rustbot · 2025-12-25T12:41:23Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

workingjubilee

This doesn't actually remove any diverging definitions from tests?

View changes since this review

workingjubilee · 2025-12-26T00:53:49Z


 #[lang = "c_void"]
-#[repr(u8)]
+#[repr(C)]


This is not how c_void is defined in core::ffi. Please revert this unrelated change.

workingjubilee · 2025-12-26T00:54:21Z

+#[lang = "Ordering"]
+#[repr(i8)]
+pub enum Ordering {
+ Less = 0xFFu8 as i8,


I'm sorry?
You can just write -1, can't you?

it was giving an error before, reverted it back

workingjubilee · 2025-12-26T00:55:21Z

+#[rustc_nounwind]
+#[rustc_intrinsic]
+pub const fn three_way_compare<T: Copy>(lhs: T, rhs: T) -> Ordering;


Why are you also adding this?

tests/assembly-llvm/rust-abi-arg-attr.rs - uses Ordering and three_way_compare

rustbot · 2025-12-26T00:56:25Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

paradoxicalguy · 2025-12-26T08:14:01Z

fixed minicore issues, aligned ordering and usize behavior, ready for re-review
@rustbot ready

paradoxicalguy · 2025-12-26T11:44:27Z

@rustbot ready

paradoxicalguy · 2025-12-26T12:28:43Z

@workingjubilee
i used 0xFFu8 as i8 instead of -1 because in #![no_core] context, the unary - operator requires the Neg lang item and an impl Neg for i8, which aren't currently in minicore.

adding impl Neg for i8 just to support this discriminant would introduce operator semantics (arithmetic, overflow handling, MIR lowering) which minicore intentionally avoids. the 0xFFu8 as i8 approach uses pure constant evaluation with no operator traits or lang items required

if you'd prefer -1 for readability, i can add the Neg implementation

workingjubilee · 2025-12-26T22:16:13Z

don't quote the deep magic to me. I was there when it was written.

minicore is minimal for the sake of not reimplementing all of core, nothing more.

workingjubilee · 2026-01-09T04:30:11Z

@bors r+

rust-bors · 2026-01-09T04:30:14Z

📌 Commit 484ea76 has been approved by workingjubilee

It is now in the queue for this repository.

paradoxicalguy · 2026-01-09T04:32:56Z

yay :-D

adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file this adds the `Ordering` enum to `minicore.rs`. consequently, this updates `tests/assembly-llvm/rust-abi-arg-attr.rs` to import `minicore` directly. previously, this test file contained traits like `Copy` `Clone` `PointeeSized`, which were giving a duplicate lang item error, so replace those by importing `minicore` completely.

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150786 (mGCA: Support array expression as direct const arguments) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) r? @ghost

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - #150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

Rollup merge of #150368 - minicore-ordering, r=workingjubilee adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file this adds the `Ordering` enum to `minicore.rs`. consequently, this updates `tests/assembly-llvm/rust-abi-arg-attr.rs` to import `minicore` directly. previously, this test file contained traits like `Copy` `Clone` `PointeeSized`, which were giving a duplicate lang item error, so replace those by importing `minicore` completely.

@ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace) - rust-lang/rust#150743 (Reword the collect() docs) - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+) - rust-lang/rust#150781 (Use `rand` crate more idiomatically) - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`) - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush) - rust-lang/rust#150873 (Reenable GCC CI download) - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22) - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek) - rust-lang/rust#150922 (Subscribe myself to attr parsing) - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`) - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

paradoxicalguy · 2026-01-25T14:32:24Z

@workingjubilee very out of the blue but thank you for the big feedback, i keep coming back to it
especially because this was my first pr

rustbot added A-test-infra-minicore Area: `minicore` test auxiliary and `//@ add-core-stubs` S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 25, 2025

rustbot assigned Mark-Simulacrum Dec 25, 2025