Unix implementation for stdio set/take/replace by the8472 · Pull Request #150668 · rust-lang/rust

the8472 · 2026-01-04T10:36:23Z

Tracking issue: #150667
ACP: rust-lang/libs-team#500

rustbot · 2026-01-04T10:36:28Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Mark-Simulacrum

r=me if you want to move these to tracking issue open questions

View changes since this review

bjorn3 · 2026-01-04T15:56:16Z

+fn replace_stdio_fd(this: BorrowedFd<'_>, other: OwnedFd) -> io::Result<()> {
+ cfg_select! {
+ not(any(
+ target_arch = "wasm32",


wasip1 supports fd_renumber which is like dup2 except moving the fd rather than duplicating it.

But wasip1 doesn't implement try_clone_to_owned, so replace and take won't work. But ok, we can still support set with that.

the8472 · 2026-01-05T08:12:07Z

@bors r=Mark-Simulacrum

bors · 2026-01-05T08:12:10Z

📌 Commit 0f5cf5e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Rollup of 3 pull requests Successful merges: - #150412 (use PIDFD_GET_INFO ioctl when available) - #150668 (Unix implementation for stdio set/take/replace) - #150702 (`rust-analyzer` subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Rollup of 8 pull requests Successful merges: - #144113 (Impls and impl items inherit `dead_code` lint level of the corresponding traits and trait items) - #149880 (rustc_codegen_llvm: update alignment for double on AIX) - #150668 (Unix implementation for stdio set/take/replace) - #150670 (THIR pattern building: Move all `thir::Pat` creation into `rustc_mir_build::thir::pattern`) - #150695 (MGCA: pretty printing for struct expressions and tuple calls ) - #150698 (Improve comment clarity in candidate_may_shadow) - #150706 (Update wasm-component-ld) - #150710 (Update libc dependency of std) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-06T05:59:36Z

I don't think this is responsible for rollup failure in #150718 (comment), but let's double-check:

@bors try jobs=dist-ohos-armv7

Unix implementation for stdio set/take/replace try-job: dist-ohos-armv7

Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

rust-bors · 2026-01-09T05:41:22Z

☀️ Try build successful (CI)
Build commit: d31a388 (d31a388f0b2558d5a4a8a0d3cd22c1c663e274e3, parent: 3fda0e426ca17b0baa0d6e765a0d23f487350573)

RalfJung · 2026-01-09T07:49:33Z

Miri patch LGTM, thanks. You can change that fail-dep test into a pass-dep test.

std supports redirecting stdio file descriptors.

the8472 · 2026-01-09T11:47:13Z

@bors r=Mark-Simulacrum,RalfJung

rust-bors · 2026-01-09T11:47:17Z

📌 Commit 7e433eb has been approved by Mark-Simulacrum,RalfJung

It is now in the queue for this repository.

…Jung Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150786 (mGCA: Support array expression as direct const arguments) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) r? @ghost

@ghost

Rollup of 14 pull requests Successful merges: - #148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - #150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - #150668 (Unix implementation for stdio set/take/replace) - #150743 (Reword the collect() docs) - #150776 (Fix the connect_error test on FreeBSD 15+) - #150781 (Use `rand` crate more idiomatically) - #150812 (Bump `diesel` to the most recent commit in `cargotest`) - #150862 (std: sys: fs: uefi: Implement File::flush) - #150873 (Reenable GCC CI download) - #150908 (llvm: Update `reliable_f16` configuration for LLVM22) - #150918 (std: sys: fs: uefi: Implement File::seek) - #150922 (Subscribe myself to attr parsing) - #150930 (Remove special case for `AllowedTargets::CrateLevel`) - #150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - #150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

Rollup merge of #150668 - stdio-swap, r=Mark-Simulacrum,RalfJung Unix implementation for stdio set/take/replace Tracking issue: #150667 ACP: rust-lang/libs-team#500

@ghost

Rollup of 14 pull requests Successful merges: - rust-lang/rust#148941 (stabilize `Peekable::next_if_map` (`#![feature(peekable_next_if_map)]`)) - rust-lang/rust#150368 (adding Ordering enum to minicore.rs, importing minicore in "tests/assembly-llvm/rust-abi-arg-attr.rs" test file) - rust-lang/rust#150668 (Unix implementation for stdio set/take/replace) - rust-lang/rust#150743 (Reword the collect() docs) - rust-lang/rust#150776 (Fix the connect_error test on FreeBSD 15+) - rust-lang/rust#150781 (Use `rand` crate more idiomatically) - rust-lang/rust#150812 (Bump `diesel` to the most recent commit in `cargotest`) - rust-lang/rust#150862 (std: sys: fs: uefi: Implement File::flush) - rust-lang/rust#150873 (Reenable GCC CI download) - rust-lang/rust#150908 (llvm: Update `reliable_f16` configuration for LLVM22) - rust-lang/rust#150918 (std: sys: fs: uefi: Implement File::seek) - rust-lang/rust#150922 (Subscribe myself to attr parsing) - rust-lang/rust#150930 (Remove special case for `AllowedTargets::CrateLevel`) - rust-lang/rust#150942 (Port `#[rustc_has_incoherent_inherent_impls]` to attribute parser) Failed merges: - rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser) r? @ghost

Windows implementation for stdio set/take/replace #150668 try-job: x86_64-msvc-1

rustbot assigned Mark-Simulacrum Jan 4, 2026

rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026

This comment has been minimized.
Sign in to view

the8472 force-pushed the stdio-swap branch from aa5e351 to 3daed94Compare January 4, 2026 11:29

bjorn3 reviewed Jan 4, 2026
View reviewed changes

Comment threadlibrary/std/src/os/unix/io/mod.rs Outdated

Mark-Simulacrum reviewed Jan 4, 2026
View reviewed changes

Comment threadlibrary/std/src/os/unix/io/mod.rs Outdated
Comment threadlibrary/std/src/os/unix/io/mod.rs

Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

bjorn3 reviewed Jan 4, 2026
View reviewed changes

the8472 force-pushed the stdio-swap branch from 3daed94 to 0f5cf5eCompare January 5, 2026 03:28

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 5, 2026
Rollup merge ofrust-lang#150668- the8472:stdio-swap, r=Mark-Simulacrum
7b53217
Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

JonathanBrouwer mentioned this pull request Jan 5, 2026
Rollup of 4 pull requests #150715
Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2026
Rollup merge ofrust-lang#150668- the8472:stdio-swap, r=Mark-Simulacrum
53b07ad
Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

matthiaskrgr mentioned this pull request Jan 5, 2026
Rollup of 3 pull requests #150716
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 6, 2026
Rollup merge ofrust-lang#150668- the8472:stdio-swap, r=Mark-Simulacrum
a1ce839
Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 6, 2026
Rollup of 8 pull requests #150718
Closed

rust-borsBot added a commit that referenced this pull request Jan 6, 2026
Auto merge of#150668- the8472:stdio-swap, r=<try>
5c50261
Unix implementation for stdio set/take/replace try-job: dist-ohos-armv7

This comment has been minimized.
Sign in to view

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 6, 2026
Rollup merge ofrust-lang#150668- the8472:stdio-swap, r=Mark-Simulacrum
c097ef3
Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 6, 2026
Rollup of 8 pull requests #150719
Closed

[miri] make closing stdio file descriptions noops
7e433eb
std supports redirecting stdio file descriptors.

the8472 force-pushed the stdio-swap branch from f54d42e to 7e433ebCompare January 9, 2026 08:01

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 9, 2026

tgross35 added a commit to tgross35/rust that referenced this pull request Jan 9, 2026
Rollup merge ofrust-lang#150668- stdio-swap, r=Mark-Simulacrum,Ralf…
cafda8d
…Jung Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

tgross35 mentioned this pull request Jan 9, 2026
Rollup of 9 pull requests #150901
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 10, 2026
Rollup merge ofrust-lang#150668- stdio-swap, r=Mark-Simulacrum,Ralf…
ea1e30f
…Jung Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 10, 2026
Rollup of 15 pull requests #150914
Closed

JonathanBrouwer mentioned this pull request Jan 10, 2026
Rollup of 14 pull requests #150924
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026
Rollup merge ofrust-lang#150668- stdio-swap, r=Mark-Simulacrum,Ralf…
a373085
…Jung Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 11, 2026
[EXPERIMENT] Rollup of 15 pull requests #150948
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 11, 2026
Rollup merge ofrust-lang#150668- stdio-swap, r=Mark-Simulacrum,Ralf…
dabe10f
…Jung Unix implementation for stdio set/take/replace Tracking issue: rust-lang#150667 ACP: rust-lang/libs-team#500

Zalathar mentioned this pull request Jan 11, 2026
Rollup of 14 pull requests #150952
Closed

matthiaskrgr mentioned this pull request Jan 11, 2026
Rollup of 14 pull requests #150957
Merged

rust-borsBot merged commit 7a9ef99 into rust-lang:mainJan 11, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 11, 2026

rust-timer added a commit that referenced this pull request Jan 11, 2026
Unrolled build for#150668
6d1f481
Rollup merge of #150668 - stdio-swap, r=Mark-Simulacrum,RalfJung Unix implementation for stdio set/take/replace Tracking issue: #150667 ACP: rust-lang/libs-team#500

the8472 mentioned this pull request Jan 11, 2026
Tracking Issue for StdioExt #150667
Open
5 tasks

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
Auto merge of#159312- the8472:stdio-swap-win, r=<try>
fffb527
Windows implementation for stdio set/take/replace #150668 try-job: x86_64-msvc-1

rust-borsBot pushed a commit that referenced this pull request Jul 15, 2026
Auto merge of#159312- the8472:stdio-swap-win, r=<try>
82cc127
Windows implementation for stdio set/take/replace #150668 try-job: x86_64-msvc-1

rust-borsBot pushed a commit that referenced this pull request Jul 16, 2026
Auto merge of#159312- the8472:stdio-swap-win, r=<try>
c8f422e
Windows implementation for stdio set/take/replace #150668 try-job: x86_64-msvc-1

Uh oh!

Uh oh!

Conversation

the8472 commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

This comment has been minimized.

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bjorn3Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

the8472Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

the8472Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

the8472 commented Jan 5, 2026

Uh oh!

bors commented Jan 5, 2026

Uh oh!

Zalathar commented Jan 6, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Jan 9, 2026

Uh oh!

RalfJung commented Jan 9, 2026

Uh oh!

the8472 commented Jan 9, 2026

Uh oh!

rust-borsBot commented Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Mark-Simulacrum left a comment •
edited by rustbot
Loading