Dont bail in error predicate unless self ty is error in new solver by ChayimFriedman2 · Pull Request #150453 · rust-lang/rust

ChayimFriedman2 · 2025-12-28T03:34:43Z

Continuation of #146602.

r? lcnr

I think we should move this out of assemble_builtin_impl_candidate to avoid ambiguity between e.g. blanket impls and the builtin impl candidate 🤔

Where do you want to put it?

apiraino · 2026-03-12T12:00:09Z

I think there's a pending comment, therefore switching to waiting on author. Feel free to request a review with @rustbot ready, thanks!

@rustbot author

rustbot · 2026-03-12T12:00:13Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

ChayimFriedman2 · 2026-04-15T11:33:58Z

@rustbot ready

ChayimFriedman2 · 2026-04-30T07:36:56Z

Ping @lcnr, do you remember this?

rustbot · 2026-06-05T04:30:16Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

ChayimFriedman2 · 2026-06-05T04:30:25Z

@bors r=lcnr

rust-bors · 2026-06-05T04:30:27Z

📌 Commit 8dd9467 has been approved by lcnr

It is now in the queue for this repository.

rust-bors · 2026-06-05T06:05:22Z

⌛ Testing commit 8dd9467 with merge 0176f45...

Workflow: https://github.com/rust-lang/rust/actions/runs/26998538227

@lcnr

Dont bail in error predicate unless self ty is error in new solver Continuation of #146602. r? lcnr @lcnr #146602 (comment) > I think we should move this out of assemble_builtin_impl_candidate to avoid ambiguity between e.g. blanket impls and the builtin impl candidate 🤔 Where do you want to put it?

@lcnr

…, r=lcnr Dont bail in error predicate unless self ty is error in new solver Continuation of rust-lang#146602. r? lcnr @lcnr rust-lang#146602 (comment) > I think we should move this out of assemble_builtin_impl_candidate to avoid ambiguity between e.g. blanket impls and the builtin impl candidate 🤔 Where do you want to put it?

jhpratt · 2026-06-05T06:10:29Z

yielding to a rollup that includes this

@bors yield

rust-bors · 2026-06-05T06:10:32Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/26998538227

The next pull request likely to be tested is #157464.

@kulst

Rollup of 7 pull requests Successful merges: - #150453 (Dont bail in error predicate unless self ty is error in new solver) - #155338 (Staticlib hide internal symbols) - #156892 (Suppress E0621 perpetual borrow suggestion) - #157135 (fix armv7a-none-eabihf tier doc) - #157360 (Document error conditions for `Command::{spawn, output, status}`) - #157418 (NVPTX: Add @kulst to the target maintainers) - #157443 (Make distinction between crate-level attributes that are warned vs errored)

rust-bors · 2026-06-05T07:01:47Z

⌛ Testing commit 8dd9467 with merge a84533e...

Workflow: https://github.com/rust-lang/rust/actions/runs/27000626389

@lcnr

Dont bail in error predicate unless self ty is error in new solver Continuation of #146602. r? lcnr @lcnr #146602 (comment) > I think we should move this out of assemble_builtin_impl_candidate to avoid ambiguity between e.g. blanket impls and the builtin impl candidate 🤔 Where do you want to put it?

jhpratt · 2026-06-05T07:02:48Z

retrying the spurious rollup failure

@bors yield

rust-bors · 2026-06-05T07:02:52Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27000626389

The next pull request likely to be tested is #157464.

@kulst

Rollup of 7 pull requests Successful merges: - #150453 (Dont bail in error predicate unless self ty is error in new solver) - #155338 (Staticlib hide internal symbols) - #156892 (Suppress E0621 perpetual borrow suggestion) - #157135 (fix armv7a-none-eabihf tier doc) - #157360 (Document error conditions for `Command::{spawn, output, status}`) - #157418 (NVPTX: Add @kulst to the target maintainers) - #157443 (Make distinction between crate-level attributes that are warned vs errored)

rust-bors · 2026-06-05T08:57:27Z

⌛ Testing commit 8dd9467 with merge 5435b5c...

Workflow: https://github.com/rust-lang/rust/actions/runs/27005603878

@lcnr

Dont bail in error predicate unless self ty is error in new solver Continuation of #146602. r? lcnr @lcnr #146602 (comment) > I think we should move this out of assemble_builtin_impl_candidate to avoid ambiguity between e.g. blanket impls and the builtin impl candidate 🤔 Where do you want to put it?

JonathanBrouwer · 2026-06-05T08:59:15Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-06-05T08:59:18Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/27005603878

The next pull request likely to be tested is #157473.

@kulst

…uwer Rollup of 7 pull requests Successful merges: - #150453 (Dont bail in error predicate unless self ty is error in new solver) - #157442 (Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s) - #156892 (Suppress E0621 perpetual borrow suggestion) - #157135 (fix armv7a-none-eabihf tier doc) - #157360 (Document error conditions for `Command::{spawn, output, status}`) - #157418 (NVPTX: Add @kulst to the target maintainers) - #157443 (Make distinction between crate-level attributes that are warned vs errored)

@lcnr

Rollup merge of #150453 - ChayimFriedman2:less-err-in-solver, r=lcnr Dont bail in error predicate unless self ty is error in new solver Continuation of #146602. r? lcnr @lcnr #146602 (comment) > I think we should move this out of assemble_builtin_impl_candidate to avoid ambiguity between e.g. blanket impls and the builtin impl candidate 🤔 Where do you want to put it?

rustbot assigned lcnr Dec 28, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Dec 28, 2025

ChayimFriedman2 changed the title ~~Dont bail in error predicate unless self ty is error~~Dont bail in error predicate unless self ty is error in new solverDec 28, 2025

This comment has been minimized.
Sign in to view

lcnr reviewed Jan 6, 2026
View reviewed changes

Comment threadcompiler/rustc_next_trait_solver/src/solve/normalizes_to/mod.rs Outdated

ChayimFriedman2 mentioned this pull request Feb 3, 2026
UX: move the implements notable traits message down rust-lang/rust-analyzer#21575
Open

flodiebold mentioned this pull request Feb 28, 2026
variables with incomplete type inference produce "callable" semantic token rust-lang/rust-analyzer#21717
Closed

ChayimFriedman2 mentioned this pull request Mar 3, 2026
Spurious type error with indexing and braced const generics rust-lang/rust-analyzer#21735
Closed

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026

This comment has been minimized.
Sign in to view

ChayimFriedman2 force-pushed the less-err-in-solver branch from fe9c130 to 1f3541dCompare April 15, 2026 03:40

This comment has been minimized.
Sign in to view

ChayimFriedman2 force-pushed the less-err-in-solver branch from 1f3541d to ede6821Compare April 15, 2026 04:43

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 15, 2026

This comment has been minimized.
Sign in to view

ChayimFriedman2 force-pushed the less-err-in-solver branch from ede6821 to a686445Compare May 3, 2026 03:31

This comment has been minimized.
Sign in to view

ChayimFriedman2 force-pushed the less-err-in-solver branch from a686445 to 9c1675aCompare May 9, 2026 17:46

This comment has been minimized.
Sign in to view

ChayimFriedman2 mentioned this pull request May 20, 2026
Possible bug in vscode tooltip shown when hovering over a function rust-lang/rust-analyzer#21447
Open

ChayimFriedman2 force-pushed the less-err-in-solver branch from 9c1675a to 8dd9467Compare June 5, 2026 04:30

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026

jhpratt mentioned this pull request Jun 5, 2026
Rollup of 7 pull requests #157464
Closed

JonathanBrouwer mentioned this pull request Jun 5, 2026
Rollup of 7 pull requests #157473
Merged

rust-borsBot merged commit 7027a4a into rust-lang:mainJun 5, 2026
12 of 13 checks passed

rustbot added this to the 1.98.0 milestone Jun 5, 2026

ChayimFriedman2 deleted the less-err-in-solver branch June 5, 2026 12:46

ChayimFriedman2 mentioned this pull request Jun 19, 2026
fix: don't complete .await on receivers of unknown type rust-lang/rust-analyzer#22486
Merged

lcnr mentioned this pull request Jun 24, 2026
Stabilize the next-generation trait solver rust-lang/goals#113
Open
8 tasks

Uh oh!

Uh oh!

Conversation

ChayimFriedman2 commented Dec 28, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

Uh oh!

apiraino commented Mar 12, 2026

Uh oh!

rustbot commented Mar 12, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ChayimFriedman2 commented Apr 15, 2026

Uh oh!

ChayimFriedman2 commented Apr 30, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Jun 5, 2026

Uh oh!

ChayimFriedman2 commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jhpratt commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Jun 5, 2026

Uh oh!

rust-borsBot commented Jun 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ChayimFriedman2 commented Dec 28, 2025•
edited by rustbot
Loading

rust-borsBot commented Jun 5, 2026•
edited
Loading

rust-borsBot commented Jun 5, 2026•
edited
Loading

rust-borsBot commented Jun 5, 2026•
edited
Loading