Skip to content

Create non-exhaustive proc_macro::EscapeError enum mirrorring rustc-literal-escaper's - #157442

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:escape-error-proc-macro
Jun 5, 2026
Merged

Create non-exhaustive proc_macro::EscapeError enum mirrorring rustc-literal-escaper's#157442
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:escape-error-proc-macro

Conversation

@GuillaumeGomez

Copy link
Copy Markdown
Member

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2026
Comment threadlibrary/proc_macro/src/lib.rs
@GuillaumeGomez
GuillaumeGomezforce-pushed the escape-error-proc-macro branch from 689c0f8 to f4b269dCompareJune 4, 2026 20:08

@UrgauUrgau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

As it's a nightly-only change, r=me once CI is green

View changes since this review

@Urgau

Urgau commented Jun 5, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-borsBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f4b269d has been approved by Urgau

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2026
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 5, 2026
…acro, r=Urgau
Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s
As discussed in rust-lang/literal-escaper#26.
r? @Urgau
rust-borsBot pushed a commit that referenced this pull request Jun 5, 2026
…uwer
Rollup of 7 pull requests
Successful merges:
- #150453 (Dont bail in error predicate unless self ty is error in new solver)
- #157442 (Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s)
- #156892 (Suppress E0621 perpetual borrow suggestion)
- #157135 (fix armv7a-none-eabihf tier doc)
- #157360 (Document error conditions for `Command::{spawn, output, status}`)
- #157418 (NVPTX: Add @kulst to the target maintainers)
- #157443 (Make distinction between crate-level attributes that are warned vs errored)
@rust-bors
rust-borsBot merged commit 94d6ea6 into rust-lang:mainJun 5, 2026
12 checks passed
@rustbotrustbot added this to the 1.98.0 milestone Jun 5, 2026
rust-timer added a commit that referenced this pull request Jun 5, 2026
Rollup merge of #157442 - GuillaumeGomez:escape-error-proc-macro, r=Urgau
Create non-exhaustive `proc_macro::EscapeError` enum mirrorring `rustc-literal-escaper`'s
As discussed in rust-lang/literal-escaper#26.
r? @Urgau
@GuillaumeGomez
GuillaumeGomez deleted the escape-error-proc-macro branch June 5, 2026 12:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez@Urgau@rustbot