Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all \x3Cpre>\x3Ccode> blocks (function() { function addCopyButtons() { document.querySelectorAll('pre code').forEach(function(codeBlock) { if (codeBlock.parentElement.hasAttribute('data-copy-added')) return; codeBlock.parentElement.setAttribute('data-copy-added', 'true'); var btn = document.createElement('button'); btn.textContent = 'Copy'; btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;'; btn.onmouseover = function() { this.style.opacity = '1'; }; btn.onmouseout = function() { this.style.opacity = '0.7'; }; btn.onclick = function() { navigator.clipboard.writeText(codeBlock.textContent).then(function() { btn.textContent = 'Copied!'; setTimeout(function() { btn.textContent = 'Copy'; }, 1500); }); }; codeBlock.parentElement.style.position = 'relative'; codeBlock.parentElement.appendChild(btn); }); } addCopyButtons(); // Re-run on dynamic content var observer = new MutationObserver(addCopyButtons); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + ' Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Rollup of 4 pull requests by JonathanBrouwer · Pull Request #150559 · rust-lang/rust · GitHub
Skip to content

Rollup of 4 pull requests - #150559

Merged
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm
Jan 1, 2026
Merged

Rollup of 4 pull requests#150559
bors merged 8 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-59hbbmm

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Jan 1, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJungand others added 8 commits December 22, 2025 13:29
I don't know why many places refer to the type as `crate::io::Result`
when `crate::io` is already imported.
…mulacrum
`crate::io::Result` → `io::Result` in most places
I don't know why many places refer to the type as `crate::io::Result` when `crate::io` is already imported.
…plit, r=Amanieu
split up tracking issue for target feature feature gates
rust-lang#44839 is tracking too many things at once. We usually have a separate tracking issue for each feature gate, so let's do that here as well:
- rust-lang#150244
- rust-lang#150245
- rust-lang#150246
- rust-lang#150247
- rust-lang#150248
- rust-lang#150249
- rust-lang#150250
- rust-lang#150251
- rust-lang#150252
- rust-lang#150253
- rust-lang#150254
- rust-lang#150255
- rust-lang#150256
- rust-lang#150257
- rust-lang#150258
- rust-lang#150259
- rust-lang#150260
- rust-lang#150261Closesrust-lang#44839 in favor of the ones listed above.
r? `@Amanieu`
…ewrite, r=BoxyUwU
`region_scope_tree`: Rewrite a `loop` as tail recursion
This addresses rust-lang#146098 (comment), hopefully making `record_subexpr_extended_temp_scopes` a bit more legible.
I removed a `debug!` in the process, since the function it calls every iteration, [`ScopeTree::record_extended_temp_scope`](https://github.com/rust-lang/rust/blob/2848c2ebe9a8a604cd63455263299d7258bc8252/compiler/rustc_middle/src/middle/region.rs#L264-L271), does the same `debug!`. Keeping the behavior of having an additional `debug!` for the top-level expression would hurt legibility, and having a duplicate `debug!` at each iteration seems excessive. No information is lost from the debug output, so I think it's fine to just have the inner `debug!`s.
r? BoxyUwU or anyone
…=chenyukang
Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal targets
This flag enables the `#[instruction_set(arm::t32)]` for the armv7a/armv7r/armv8r targets, which all support Thumb interwork but were missing this flag.
Target maintainers are `@chrisnc,` `@rust-lang/arm-maintainers,` `@rust-embedded/arm` (including me).
@rustbotrustbot added O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 1, 2026
@JonathanBrouwer

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit 767e7da has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 1, 2026
@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 767e7da with merge 6e48b44...

@bors

bors commented Jan 1, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: JonathanBrouwer
Pushing 6e48b44 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 1, 2026
@bors
bors merged commit 6e48b44 into rust-lang:mainJan 1, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 1, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#149778crate::io::Resultio::Result in most places813cbf4b89736082babb86efcbe6ca73fbd952b1 (link)
#150264split up tracking issue for target feature feature gates360aa6a13c5c5f2f18c4ddd7a9f2c66234261fa9 (link)
#150548region_scope_tree: Rewrite a loop as tail recursion8d94899201fecc4c3073b6825d8b8113c6447b72 (link)
#150555Enable thumb interworking on ARMv7A/R and ARMv8R bare-metal…0e92c54e18364a3c0796430749f6f9506ddcb353 (link)

previous master: 4c62aa4468

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 4c62aa4 (parent) -> 6e48b44 (this PR)

Test differences

Show 36 test diffs

36 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6e48b44e77d117d84ff3c340368dea3064117559 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 7662.7s -> 9357.3s (+22.1%)
  2. dist-apple-various: 5438.9s -> 4265.6s (-21.6%)
  3. aarch64-msvc-1: 7891.1s -> 6995.5s (-11.3%)
  4. dist-aarch64-llvm-mingw: 5488.9s -> 6098.1s (+11.1%)
  5. arm-android: 5858.6s -> 6490.2s (+10.8%)
  6. dist-x86_64-netbsd: 5316.6s -> 4770.1s (-10.3%)
  7. dist-ohos-aarch64: 4532.2s -> 4071.8s (-10.2%)
  8. dist-ohos-x86_64: 4611.4s -> 4170.0s (-9.6%)
  9. dist-x86_64-apple: 6895.1s -> 7531.4s (+9.2%)
  10. x86_64-msvc-1: 9179.2s -> 8374.2s (-8.8%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (6e48b44): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.1%[0.1%, 0.2%]3
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 2.5%, secondary -3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.5%[2.5%, 2.5%]1
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.5%[-6.1%, -0.9%]3
All ❌✅ (primary)2.5%[2.5%, 2.5%]1

Cycles

Results (primary 9.2%, secondary 16.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
9.2%[3.1%, 15.1%]10
Regressions ❌
(secondary)
18.0%[2.8%, 29.6%]11
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.3%[-2.3%, -2.3%]1
All ❌✅ (primary)9.2%[3.1%, 15.1%]10

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.46s -> 476.234s (-0.05%)
Artifact size: 390.83 MiB -> 390.86 MiB (0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.O-hermitOperating System: HermitO-itronOperating System: ITRONO-SGXTarget: SGXO-solidOperating System: SOLIDO-unixOperating system: Unix-likeO-wasiOperating system: Wasi, Webassembly System InterfaceO-windowsOperating system: WindowsrollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@JonathanBrouwer@bors@rust-timer@rustbot@RalfJung@tbu-@adamgreig@dianne