THIR pattern building: Pass HIR nodes instead of loose types/spans by Zalathar · Pull Request #150660 · rust-lang/rust

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Zalathar · 2026-01-04T04:34:37Z

This should make it easier to keep track of where the types/spans came from.

There should be no change to compiler output.

In the future I would also like to make more of these lowering methods return Box<thir::Pat> instead of thir::PatKind, so that it becomes feasible to add more fields to thir::Pat (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

rustbot · 2026-01-04T04:34:40Z

Some changes occurred in match checking

cc @Nadrieril

rustbot · 2026-01-04T04:34:43Z

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

This should make it easier to keep track of where the types/spans came from.

davidtwco · 2026-01-04T14:05:36Z

@bors r+ rollup

bors · 2026-01-04T14:05:38Z

📌 Commit de37724 has been approved by davidtwco

It is now in the queue for this repository.

Rollup of 5 pull requests Successful merges: - #150554 (test: add regression cases for valtree hashing ICE) - #150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - #150619 (alloc: Move Cow impl to existing ones) - #150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - #150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #150660 - Zalathar:pass-nodes, r=davidtwco THIR pattern building: Pass HIR nodes instead of loose types/spans This should make it easier to keep track of where the types/spans came from. There should be no change to compiler output. --- In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for #150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.

Rollup of 5 pull requests Successful merges: - rust-lang/rust#150554 (test: add regression cases for valtree hashing ICE) - rust-lang/rust#150597 (make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`) - rust-lang/rust#150619 (alloc: Move Cow impl to existing ones) - rust-lang/rust#150660 (THIR pattern building: Pass HIR nodes instead of loose types/spans) - rust-lang/rust#150671 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 4, 2026

rustbot assigned davidtwco Jan 4, 2026

Prefer to pass HIR nodes instead of loose types/spans
de37724
This should make it easier to keep track of where the types/spans came from.

Zalathar force-pushed the pass-nodes branch from 6b89a50 to de37724Compare January 4, 2026 04:54

davidtwco approved these changes Jan 4, 2026
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026

matthiaskrgr mentioned this pull request Jan 4, 2026
Rollup of 5 pull requests #150674
Merged

bors merged commit cdddb85 into rust-lang:mainJan 4, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 4, 2026

Zalathar deleted the pass-nodes branch January 4, 2026 21:31

github-actionsBot mentioned this pull request Jan 27, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

Uh oh!

Uh oh!

Conversation

Zalathar commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

davidtwco commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

davidtwco commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

davidtwco commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Zalathar commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

rustbot commented Jan 4, 2026

Uh oh!

davidtwco commented Jan 4, 2026

Uh oh!

bors commented Jan 4, 2026

Uh oh!

Uh oh!