Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Rollup of 5 pull requests - #150674

Merged
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx
Jan 4, 2026
Merged

Rollup of 5 pull requests#150674
bors merged 32 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-tnkgbcx

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Jan 4, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Dushyanthyadavand others added 30 commits December 31, 2025 21:09
This commit adds basic support for FFI callbacks by registering a shim function
via libffi. This shim function currently only exits with an error. The main
motivation for this is to prevent miri segfaulting as described in
[4639](rust-lang/miri#4639).
In the future miri could try to continue execution in the registered
callback, although as far as I understand Ralf that is no easy problem.
Basic support for FFI callbacks (at least stop segfaulting and report a proper error)
…r vec::IntoIter with any Allocator, not just Global
native lib support: support returning structs
android: get the entire test suite to pass
Right now, the `borrow.rs` module starts with a `Cow` impl, although
most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its
impl directly below it.
Moving it to the others down below makes sense here, given that the
entire enum depends on `ToOwned` anyways.
This updates the rust-version file to e8f3cfc.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: e8f3cfc
Filtered ref: 5837f859c413e836e4fd1eb4985632c2f62c7db0
Upstream diff: rust-lang/rust@7fefa09...e8f3cfc
This merge was created using https://github.com/rust-lang/josh-sync.
…ests/libc-pipe
Refactor libc pipe tests to use utility functions for error handling and data operations
This should make it easier to keep track of where the types/spans came from.
This updates the rust-version file to f57b9e6.
Pull recent changes from https://github.com/rust-lang/rust via Josh.
Upstream ref: f57b9e6
Filtered ref: dd835ad11d6c5cea520a087bb620e3643e2dbf0f
Upstream diff: rust-lang/rust@e8f3cfc...f57b9e6
This merge was created using https://github.com/rust-lang/josh-sync.
add check_only feature for faster check builds
…gression-test, r=davidtwco
test: add regression cases for valtree hashing ICE
This PR extends the existing regression test `printing_valtrees_supports_non_values.rs` to cover cases that previously caused an ICE in `const_kind.rs` due to hashing inference variables.
It specifically adds:
A case where an associated constant is used without the required trait bound.
The `0: _` case as suggested in [Here](rust-lang#150409 (comment))
Fixesrust-lang#150409
…cator, r=jhpratt
make specialization of `Vec::extend` and `VecDeque::extend_front` work for vec::IntoIter with any `Allocator`, not just `Global`
These functions consume all the elements from the respective collection, but do not care about the `Allocator` they use. Without specifying one (like in `vec::IntoIter<T>`) the specialization is only chosen when `A=Global`.
(extra context: `VecDeque::extend_front` is unstable and tracked by rust-lang#146975)
…ulacrum
alloc: Move Cow impl to existing ones
Right now, the `borrow.rs` module starts with a `Cow` impl, although most of them can be found below.
This hurts code readability because there is `ToOwned` alongside its impl directly below it.
Moving it to the others down below makes sense here, given that the entire enum depends on `ToOwned` anyways.
THIR pattern building: Pass HIR nodes instead of loose types/spans
This should make it easier to keep track of where the types/spans came from.
There should be no change to compiler output.
---
In the future I would also like to make more of these lowering methods return `Box<thir::Pat>` instead of `thir::PatKind`, so that it becomes feasible to add more fields to `thir::Pat` (e.g. for rust-lang#150498 (comment)). That will be easier if those methods have easy access to the corresponding HIR pattern node, from which they can obtain a type and span.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jan 4, 2026
@matthiaskrgr

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

📌 Commit eeb4431 has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2026
@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

⌛ Testing commit eeb4431 with merge e29fcf4...

@bors

bors commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing e29fcf4 to main...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Jan 4, 2026
@bors
bors merged commit e29fcf4 into rust-lang:mainJan 4, 2026
12 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 4, 2026
@rust-timer

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#150554test: add regression cases for valtree hashing ICE542bc5d27a7dbc8ac21b50fe655c79af75d2403a (link)
#150597make specialization of Vec::extend and `VecDeque::extend_…4c50440380f8792608bd531db0a4c983dbb05730 (link)
#150619alloc: Move Cow impl to existing onescf41d5f26f12ba0aa6dde37109c3b06e9a0fb7f3 (link)
#150660THIR pattern building: Pass HIR nodes instead of loose type…83ecbc0b99a56fe6020f1b5bba8d32c9358b21aa (link)
#150671miri subtree update75f7d939cbbf681e69b3728feb4e3a9b4bdfdcf6 (link)

previous master: 5afdf5d8c0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5afdf5d (parent) -> e29fcf4 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e29fcf45e4ae686d77b490bf07320f0d3a2cf35f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 6323.6s -> 8698.5s (+37.6%)
  2. aarch64-gnu-llvm-20-1: 4061.0s -> 3300.1s (-18.7%)
  3. aarch64-msvc-1: 7994.9s -> 6708.5s (-16.1%)
  4. aarch64-apple: 11067.1s -> 9383.1s (-15.2%)
  5. pr-check-1: 1962.8s -> 1680.7s (-14.4%)
  6. aarch64-gnu-llvm-20-2: 3246.8s -> 2792.9s (-14.0%)
  7. i686-gnu-2: 6182.5s -> 5358.7s (-13.3%)
  8. aarch64-gnu-debug: 4565.8s -> 4000.7s (-12.4%)
  9. x86_64-gnu-llvm-20-3: 7005.8s -> 6173.7s (-11.9%)
  10. i686-gnu-1: 8403.2s -> 7431.2s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (e29fcf4): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-2.9%[-2.9%, -2.9%]1
All ❌✅ (primary)--0

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
--0
Regressions ❌
(secondary)
2.9%[2.9%, 2.9%]1
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.624s -> 475.648s (0.01%)
Artifact size: 390.88 MiB -> 390.89 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@matthiaskrgr@bors@rust-timer@rustbot@Dushyanthyadav@folkertdev@RalfJung@weiznich@antonilol@cvengler@oli-obk@hulxv@Zalathar