Skip to content

Improve std::path::Path::join documentation - #150677

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
KaiTomotake:improve-doc
Jan 14, 2026
Merged

Improve std::path::Path::join documentation#150677
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
KaiTomotake:improve-doc

Conversation

@KaiTomotake

@KaiTomotakeKaiTomotake commented Jan 4, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Adapt PathBuf::push documentation for Path::join and add it to join's docs

#146447

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026
@rustbot

rustbot commented Jan 4, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Mark-Simulacrum

Mark-Simulacrum commented Jan 10, 2026

Copy link
Copy Markdown
Member

r=me with commits squashed

@KaiTomotake

KaiTomotake commented Jan 11, 2026

Copy link
Copy Markdown
ContributorAuthor

Thanks! Just to confirm:
does “r=me with commits squashed” mean the change is approved as long as I squash the commits?

@rustbot

rustbot commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot

This comment has been minimized.

Sign in to view
@rustbotrustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 12, 2026
@rustbotrustbot removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. has-merge-commits PR has merge commits, merge with caution. labels Jan 12, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Jan 12, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Yes, once this is squashed to one commit I'll approve.

@Mark-SimulacrumMark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026
@KaiTomotake
Improve std::path::Path::join documentation
d697b4d
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs
Fix to comply with tidy
Remove unnecessary whitespace
@KaiTomotake

KaiTomotake commented Jan 13, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot label -S-waiting-on-author +S-waiting-on-review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 13, 2026
@Mark-Simulacrum

Mark-Simulacrum commented Jan 13, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-borsrust-borsBot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 13, 2026
@rust-bors

rust-borsBot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d697b4d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-borsrust-borsBot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#150677- improve-doc, r=Mark-Simulacrum
b8be619
Improve std::path::Path::join documentation
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs
rust-lang#146447
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 13, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 13, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#150677- improve-doc, r=Mark-Simulacrum
de20a80
Improve std::path::Path::join documentation
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs
rust-lang#146447
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 13, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of#151070- JonathanBrouwer:rollup-hfZvtaP, r=JonathanBro…
2719969
…uwer
Rollup of 13 pull requests
Successful merges:
- #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items)
- #150677 (Improve std::path::Path::join documentation)
- #150723 (std: move `errno` and related functions into `sys::io`)
- #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
- #150771 (Remove legacy homu `try` and `auto` branch mentions)
- #150915 (Regression test for type params on eii)
- #150962 (Remove `FeedConstTy` and provide ty when lowering const arg)
- #151017 (Port the rustc dump attributes to the attribute parser)
- #151019 (Make `Type::of` support unsized types)
- #151034 (std: Change UEFI env vars to volatile storage)
- #151052 (ui: add regression test for macro resolution ICE (issue #150711))
- #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
- #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)
r? @ghost
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 13, 2026
@GuillaumeGomez
Rollup merge ofrust-lang#150677- improve-doc, r=Mark-Simulacrum
dd8cb22
Improve std::path::Path::join documentation
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs
rust-lang#146447
This was referenced Jan 13, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Jan 14, 2026
@bors
Auto merge of#151087- GuillaumeGomez:rollup-vIdiReJ, r=GuillaumeGomez
4931e09
Rollup of 13 pull requests
Successful merges:
- #150587 (triagebot: add A-rustdoc-js autolabel)
- #150677 (Improve std::path::Path::join documentation)
- #150737 (diagnostics: make implicit Sized bounds explicit in E0277)
- #150771 (Remove legacy homu `try` and `auto` branch mentions)
- #150840 (Make `--print=check-cfg` output compatible `--check-cfg` arguments)
- #150915 (Regression test for type params on eii)
- #151017 (Port the rustc dump attributes to the attribute parser)
- #151019 (Make `Type::of` support unsized types)
- #151031 (Support arrays in type reflection)
- #151043 (armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax)
- #151052 (ui: add regression test for macro resolution ICE (issue #150711))
- #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`)
- #151055 (Emit error instead of delayed bug when meeting mismatch type for const array)
r? @ghost
@rust-bors
rust-borsBot merged commit 7fc878c into rust-lang:mainJan 14, 2026
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 14, 2026
rust-timer added a commit that referenced this pull request Jan 14, 2026
@rust-timer
Unrolled build for#150677
8e9884c
Rollup merge of #150677 - improve-doc, r=Mark-Simulacrum
Improve std::path::Path::join documentation
Adapt `PathBuf::push` documentation for `Path::join` and add it to `join`'s docs
#146447
@KaiTomotake
KaiTomotake deleted the improve-doc branch January 14, 2026 07:59
@github-actionsgithub-actionsBot mentioned this pull request Jan 28, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

4 participants

@KaiTomotake@rustbot@rust-log-analyzer@Mark-Simulacrum