Regression test for type params on eii by jdonszelmann · Pull Request #150915 · rust-lang/rust

jdonszelmann · 2026-01-10T10:18:22Z

Somewhere along the line I fixed this one with my other PRs. This just adds the regression tests

rustbot · 2026-01-10T10:18:27Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kivooeo · 2026-01-10T16:37:18Z

r? me

r=me when ci is green

rustbot · 2026-01-11T15:57:09Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

jdonszelmann · 2026-01-11T15:58:01Z

@Kivooeo ended up rebasing on a little renaming PR so they don't conflict down the line, assigned you too, and improved the error messages a bit so there's no duplicate. Could you take a look again? Despite having already approved the original PR

Kivooeo · 2026-01-11T16:15:38Z

Could you take a look again?

not sure why this PR contains changes from #150972

jdonszelmann · 2026-01-11T16:16:02Z

Cause I rebased on it, to use the new names. This one can merge after that one

jdonszelmann · 2026-01-11T16:16:29Z

(i.e. it's a stacked PR, if only github could render that.... :/)

jdonszelmann · 2026-01-11T16:18:10Z

I use jj, so I've got autorebase. So I often end up submitting multiple PRs, some stacked on others. Feel free to review after #150972 merged

@rustbot blocked #150972

Kivooeo · 2026-01-11T16:27:23Z

check_no_generics is not required anymore?

jdonszelmann · 2026-01-11T16:39:59Z

I think not, an EII definition always generates a foreign function, and foreign functions are already disallowed to take generics. This would give a duplicate error which is exactly what I noticed and why I added another commit on top to fix.

jdonszelmann · 2026-01-11T16:41:17Z

wait, dya mind if I add another test for that to make sure?

jdonszelmann · 2026-01-11T16:48:00Z

okay, I realized you were totally right: we need the other check too make sure the implementation of the EII has no generics. The duplicate error is caused by the fact that an EII with default implementation also contains an implementation, so we error on both the definition and implementation. I'll fix

Kivooeo · 2026-01-11T17:29:54Z

wait, dya mind if I add another test for that to make sure?

not really, it seems like this check was originally added to fix that issue #149983, so removing it was kinda questionable because maybe it was fixed by some another pr that I'm unaware of and this check already unnecessary

but glad that you found out that this check is still needed ^^

jdonszelmann · 2026-01-11T19:54:45Z

wasn't fixed by anything else, but the remove was wrong. Now I just changed it slightly so there's no duplicate error with that last commit, so I think this is the best outcome :)

Kivooeo · 2026-01-11T20:54:05Z

just to make sure, first two commits will be removed from this pr before merge after #150972 lands right?

jdonszelmann · 2026-01-11T21:25:32Z

indeed, same hashes too :)

Kivooeo · 2026-01-11T21:28:54Z

yeah, i just don't quite sure what "stacked PR" is, so trying to figure out what are we going to do with this next

btw, implementation wise i have no questions, so feel free to r=me once it unblocked after other pr lands

rust-bors · 2026-01-12T05:50:06Z

☔ The latest upstream changes (presumably #150981) made this pull request unmergeable. Please resolve the merge conflicts.

… and test this

rustbot · 2026-01-13T11:03:30Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jdonszelmann · 2026-01-13T11:03:43Z

@bors r=kivooeo rollup

rust-bors · 2026-01-13T11:03:47Z

📌 Commit b454f76 has been approved by kivooeo

It is now in the queue for this repository.

Regression test for type params on eii Somewhere along the line I fixed this one with my other PRs. This just adds the regression tests Closesrust-lang#149983

@ghost

…uwer Rollup of 13 pull requests Successful merges: - #150586 (rustdoc: Fix intra-doc link bugs involving type aliases and associated items) - #150677 (Improve std::path::Path::join documentation) - #150723 (std: move `errno` and related functions into `sys::io`) - #150737 (diagnostics: make implicit Sized bounds explicit in E0277) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150915 (Regression test for type params on eii) - #150962 (Remove `FeedConstTy` and provide ty when lowering const arg) - #151017 (Port the rustc dump attributes to the attribute parser) - #151019 (Make `Type::of` support unsized types) - #151034 (std: Change UEFI env vars to volatile storage) - #151052 (ui: add regression test for macro resolution ICE (issue #150711)) - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`) - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array) r? @ghost

Regression test for type params on eii Somewhere along the line I fixed this one with my other PRs. This just adds the regression tests Closesrust-lang#149983

@ghost

Rollup of 13 pull requests Successful merges: - #150587 (triagebot: add A-rustdoc-js autolabel) - #150677 (Improve std::path::Path::join documentation) - #150737 (diagnostics: make implicit Sized bounds explicit in E0277) - #150771 (Remove legacy homu `try` and `auto` branch mentions) - #150840 (Make `--print=check-cfg` output compatible `--check-cfg` arguments) - #150915 (Regression test for type params on eii) - #151017 (Port the rustc dump attributes to the attribute parser) - #151019 (Make `Type::of` support unsized types) - #151031 (Support arrays in type reflection) - #151043 (armv7-unknown-linux-uclibceabihf.md: Fix bootstrap.toml syntax) - #151052 (ui: add regression test for macro resolution ICE (issue #150711)) - #151053 (Reduce flakyness for `tests/rustdoc-gui/notable-trait.goml`) - #151055 (Emit error instead of delayed bug when meeting mismatch type for const array) r? @ghost

Rollup merge of #150915 - eii-regression-test-149983, r=kivooeo Regression test for type params on eii Somewhere along the line I fixed this one with my other PRs. This just adds the regression tests Closes#149983

rustbot assigned petrochenkov Jan 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 10, 2026

This comment has been minimized.
Sign in to view

rustbot assigned Kivooeo and unassigned petrochenkov Jan 10, 2026

jdonszelmann force-pushed the eii-regression-test-149983 branch from 6f628c9 to 6996af3Compare January 11, 2026 15:57

rustbot added the A-attributes Area: Attributes (`#[…]`, `#![…]`) label Jan 11, 2026

This comment has been minimized.
Sign in to view

rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2026

type params on eii
1d96806

jdonszelmann added 3 commits January 13, 2026 11:59

deduplicate error message when EII has generics
d25f471

bless the tests
b64a9be

ensure generics are still properly reported on EII *implementations*,…
b454f76
… and test this

jdonszelmann force-pushed the eii-regression-test-149983 branch from b3477f9 to b454f76Compare January 13, 2026 11:03

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jan 13, 2026

JonathanBrouwer mentioned this pull request Jan 13, 2026
Rollup of 14 pull requests #151062
Closed

JonathanBrouwer mentioned this pull request Jan 13, 2026
Rollup of 13 pull requests #151070
Closed

This was referenced Jan 13, 2026
Rollup of 13 pull requests #151086
Closed
Rollup of 13 pull requests #151087
Merged

rust-borsBot merged commit 0d3692a into rust-lang:mainJan 14, 2026
11 checks passed

rustbot added this to the 1.94.0 milestone Jan 14, 2026

github-actionsBot mentioned this pull request Jan 28, 2026
Toolchain upgrade to nightly-2026-02-09 flux-rs/flux#1345
Closed

bjorn3 added the F-extern_item_impls `#![feature(extern_item_impls)]` label Jul 8, 2026

Uh oh!

Uh oh!

Conversation

jdonszelmann commented Jan 10, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jan 10, 2026

Uh oh!

This comment has been minimized.

Kivooeo commented Jan 10, 2026

Uh oh!

rustbot commented Jan 11, 2026

Uh oh!

This comment has been minimized.

jdonszelmann commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Kivooeo commented Jan 11, 2026

Uh oh!

jdonszelmann commented Jan 11, 2026

Uh oh!

Kivooeo commented Jan 11, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Jan 12, 2026

Uh oh!

rustbot commented Jan 13, 2026

Uh oh!

jdonszelmann commented Jan 13, 2026

Uh oh!

rust-borsBot commented Jan 13, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jdonszelmann commented Jan 10, 2026•
edited by rustbot
Loading

jdonszelmann commented Jan 11, 2026•
edited
Loading

Kivooeo commented Jan 11, 2026•
edited
Loading