Skip to content

Improve span for "unresolved intra doc link" on deprecated attribute - #150883

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:improve-deprecated-intra-doc-span
Jan 13, 2026
Merged

Improve span for "unresolved intra doc link" on deprecated attribute#150883
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GuillaumeGomez:improve-deprecated-intra-doc-span

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Jan 9, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Follow-up of #150721.

To make this work, I replaced the Symbol by an Ident to keep the Span information.

cc @folkertdev
r? @camelid

@rustbot

rustbot commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 9, 2026
folkertdev
folkertdev reviewed Jan 9, 2026
View reviewed changes

@folkertdevfolkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

View changes since this review

Comment threadcompiler/rustc_attr_parsing/src/parser.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
GuillaumeGomezforce-pushed the improve-deprecated-intra-doc-span branch from b339921 to f9c71dfCompareJanuary 9, 2026 19:37
@rust-log-analyzer

rust-log-analyzer commented Jan 9, 2026

Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
............................................ (144/144)
======== tests/rustdoc-gui/notable-trait.goml ========
[ERROR] line 254
at `tests/rustdoc-gui/utils.goml` line 34: Error: The following CSS properties still don't match: [expected `block` for key `display`, found `none`]: for command `wait-for-css: ("#settings", {"display": "block"})`
at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/struct.NotableStructWithLongName.html#method.create_an_iterator_from_read>
======== tests/rustdoc-gui/search-result-display.goml ========
[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@GuillaumeGomez

GuillaumeGomez commented Jan 10, 2026

Copy link
Copy Markdown
MemberAuthor

After relaunching CI, it passed this time. I really need to investigate why we have these flaky errors...

camelid
camelid approved these changes Jan 12, 2026
View reviewed changes

@camelidcamelid left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@camelid

camelid commented Jan 12, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026
@rust-bors

rust-borsBot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit f9c71df has been approved by camelid

It is now in the queue for this repository.

@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 13, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of#151051- JonathanBrouwer:rollup-SuaGLmP, r=JonathanBro…
db1484b
…uwer
Rollup of 14 pull requests
Successful merges:
- #150151 (Destabilise `target-spec-json`)
- #150826 (Add `f16` inline ASM support for s390x)
- #150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute)
- #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
- #150943 (Port `#[must_not_suspend]` to attribute parser)
- #150990 (std: sys: net: uefi: Make TcpStream Send)
- #150995 (core: ptr: split_at_mut: fix typo in safety doc)
- #150998 (Relax test expectation for @__llvm_profile_runtime_user)
- #151002 (Remove a workaround for a bug (take 2))
- #151005 (Fix typo in `MaybeUninit` docs)
- #151011 (Update books)
- #151029 (rustc-dev-guide subtree update)
- #151032 (fix: added missing backtick in triagebot.toml)
- #151035 (Don't suggest replacing closure parameter with type name)
r? @ghost
@rust-bors
rust-borsBot merged commit dc6afd7 into rust-lang:mainJan 13, 2026
28 of 33 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 13, 2026
@GuillaumeGomez
GuillaumeGomez deleted the improve-deprecated-intra-doc-span branch January 13, 2026 14:21
rust-timer added a commit that referenced this pull request Jan 13, 2026
@rust-timer
Unrolled build for#150883
0f60295
Rollup merge of #150883 - improve-deprecated-intra-doc-span, r=camelid
Improve span for "unresolved intra doc link" on `deprecated` attribute
Follow-up of #150721.
To make this work, I replaced the `Symbol` by an `Ident` to keep the `Span` information.
cc @folkertdev
r? @camelid
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151051 - JonathanBrouwer:rollup-SuaGLmP, r=JonathanBro…
16fbef1
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#150151 (Destabilise `target-spec-json`)
- rust-lang/rust#150826 (Add `f16` inline ASM support for s390x)
- rust-lang/rust#150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute)
- rust-lang/rust#150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
- rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser)
- rust-lang/rust#150990 (std: sys: net: uefi: Make TcpStream Send)
- rust-lang/rust#150995 (core: ptr: split_at_mut: fix typo in safety doc)
- rust-lang/rust#150998 (Relax test expectation for @__llvm_profile_runtime_user)
- rust-lang/rust#151002 (Remove a workaround for a bug (take 2))
- rust-lang/rust#151005 (Fix typo in `MaybeUninit` docs)
- rust-lang/rust#151011 (Update books)
- rust-lang/rust#151029 (rustc-dev-guide subtree update)
- rust-lang/rust#151032 (fix: added missing backtick in triagebot.toml)
- rust-lang/rust#151035 (Don't suggest replacing closure parameter with type name)
r? @ghost
@github-actionsgithub-actionsBot mentioned this pull request Jan 28, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev left review comments
@camelidcamelidcamelid approved these changes

Assignees

@camelidcamelid

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@GuillaumeGomez@rustbot@rust-log-analyzer@camelid@folkertdev