Skip to content

std: sys: net: uefi: Make TcpStream Send - #150990

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ayush1325:uefi-run-test
Jan 13, 2026
Merged

std: sys: net: uefi: Make TcpStream Send#150990
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Ayush1325:uefi-run-test

Conversation

@Ayush1325

@Ayush1325Ayush1325 commented Jan 12, 2026

Copy link
Copy Markdown
Contributor
  • Since UEFI has no threads, this should be safe.
  • Makes compiling remote-test-server simpler.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 12, 2026
@rustbot

rustbot commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Ayush1325

Ayush1325 commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

@rustbot label +O-UEFI

@rustbotrustbot added the O-UEFI UEFI label Jan 12, 2026
@joboet

joboet commented Jan 12, 2026

Copy link
Copy Markdown
Member

I'd implement this for tcp::Tcp instead, as you'll face the same issue when implementing TcpListener otherwise.

@Ayush1325
std: sys: net: uefi: Make TcpStream Send
50b60aa
- Since UEFI has no threads, this should be safe.
- Makes compiling remote-test-server simpler.
Signed-off-by: Ayush Singh <ayush@beagleboard.org>
@Ayush1325

Ayush1325 commented Jan 12, 2026

Copy link
Copy Markdown
ContributorAuthor

I'd implement this for tcp::Tcp instead, as you'll face the same issue when implementing TcpListener otherwise.

Done

@joboet

joboet commented Jan 12, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2026
@rust-bors

rust-borsBot commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 50b60aa has been approved by joboet

It is now in the queue for this repository.

@tgross35tgross35 assigned joboet and unassigned tgross35Jan 12, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 12, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#150990- uefi-run-test, r=joboet
03aafbc
std: sys: net: uefi: Make TcpStream Send
- Since UEFI has no threads, this should be safe.
- Makes compiling remote-test-server simpler.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 12, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jan 12, 2026
@bors
Auto merge of#151023- JonathanBrouwer:rollup-f6vMoSd, r=JonathanBro…
8d04a9f
…uwer
Rollup of 13 pull requests
Successful merges:
- #145343 (Dogfood `-Zno-embed-metadata` in the standard library)
- #150151 (Destabilise `target-spec-json`)
- #150723 (std: move `errno` and related functions into `sys::io`)
- #150771 (Remove legacy homu `try` and `auto` branch mentions)
- #150826 (Add `f16` inline ASM support for s390x)
- #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
- #150943 (Port `#[must_not_suspend]` to attribute parser)
- #150990 (std: sys: net: uefi: Make TcpStream Send)
- #150995 (core: ptr: split_at_mut: fix typo in safety doc)
- #150998 (Relax test expectation for @__llvm_profile_runtime_user)
- #151002 (Remove a workaround for a bug (take 2))
- #151005 (Fix typo in `MaybeUninit` docs)
- #151011 (Update books)
r? @ghost
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 12, 2026
@matthiaskrgr
Rollup merge ofrust-lang#150990- uefi-run-test, r=joboet
5ed98e1
std: sys: net: uefi: Make TcpStream Send
- Since UEFI has no threads, this should be safe.
- Makes compiling remote-test-server simpler.
@matthiaskrgrmatthiaskrgr mentioned this pull request Jan 12, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of#151038- matthiaskrgr:rollup-fBdEuCE, r=matthiaskrgr
56cc9e3
Rollup of 12 pull requests
Successful merges:
- #145343 (Dogfood `-Zno-embed-metadata` in the standard library)
- #150151 (Destabilise `target-spec-json`)
- #150723 (std: move `errno` and related functions into `sys::io`)
- #150826 (Add `f16` inline ASM support for s390x)
- #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
- #150943 (Port `#[must_not_suspend]` to attribute parser)
- #150990 (std: sys: net: uefi: Make TcpStream Send)
- #150995 (core: ptr: split_at_mut: fix typo in safety doc)
- #150998 (Relax test expectation for @__llvm_profile_runtime_user)
- #151002 (Remove a workaround for a bug (take 2))
- #151005 (Fix typo in `MaybeUninit` docs)
- #151011 (Update books)
r? @ghost
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jan 13, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jan 13, 2026
@bors
Auto merge of#151051- JonathanBrouwer:rollup-SuaGLmP, r=JonathanBro…
db1484b
…uwer
Rollup of 14 pull requests
Successful merges:
- #150151 (Destabilise `target-spec-json`)
- #150826 (Add `f16` inline ASM support for s390x)
- #150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute)
- #150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
- #150943 (Port `#[must_not_suspend]` to attribute parser)
- #150990 (std: sys: net: uefi: Make TcpStream Send)
- #150995 (core: ptr: split_at_mut: fix typo in safety doc)
- #150998 (Relax test expectation for @__llvm_profile_runtime_user)
- #151002 (Remove a workaround for a bug (take 2))
- #151005 (Fix typo in `MaybeUninit` docs)
- #151011 (Update books)
- #151029 (rustc-dev-guide subtree update)
- #151032 (fix: added missing backtick in triagebot.toml)
- #151035 (Don't suggest replacing closure parameter with type name)
r? @ghost
@rust-bors
rust-borsBot merged commit a830a9a into rust-lang:mainJan 13, 2026
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Jan 13, 2026
rust-timer added a commit that referenced this pull request Jan 13, 2026
@rust-timer
Unrolled build for#150990
c86dbd3
Rollup merge of #150990 - uefi-run-test, r=joboet
std: sys: net: uefi: Make TcpStream Send
- Since UEFI has no threads, this should be safe.
- Makes compiling remote-test-server simpler.
@Ayush1325
Ayush1325 deleted the uefi-run-test branch January 13, 2026 14:27
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 20, 2026
@bors
Auto merge of #151051 - JonathanBrouwer:rollup-SuaGLmP, r=JonathanBro…
16fbef1
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#150151 (Destabilise `target-spec-json`)
- rust-lang/rust#150826 (Add `f16` inline ASM support for s390x)
- rust-lang/rust#150883 (Improve span for "unresolved intra doc link" on `deprecated` attribute)
- rust-lang/rust#150934 (Move some checks from `check_doc_attrs` directly into `rustc_attr_parsing`)
- rust-lang/rust#150943 (Port `#[must_not_suspend]` to attribute parser)
- rust-lang/rust#150990 (std: sys: net: uefi: Make TcpStream Send)
- rust-lang/rust#150995 (core: ptr: split_at_mut: fix typo in safety doc)
- rust-lang/rust#150998 (Relax test expectation for @__llvm_profile_runtime_user)
- rust-lang/rust#151002 (Remove a workaround for a bug (take 2))
- rust-lang/rust#151005 (Fix typo in `MaybeUninit` docs)
- rust-lang/rust#151011 (Update books)
- rust-lang/rust#151029 (rustc-dev-guide subtree update)
- rust-lang/rust#151032 (fix: added missing backtick in triagebot.toml)
- rust-lang/rust#151035 (Don't suggest replacing closure parameter with type name)
r? @ghost
@github-actionsgithub-actionsBot mentioned this pull request Jan 28, 2026
Closed
@ginnyTheCatginnyTheCat mentioned this pull request Mar 17, 2026
Merged
RalfJung
RalfJung reviewed Mar 24, 2026
View reviewed changes
Comment threadlibrary/std/src/sys/net/connection/uefi/tcp.rs
}

// SAFETY: UEFI has no threads.
unsafe impl Send for Tcp {}

@RalfJungRalfJungMar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UEFI still has signal handlers / interrupts though, doesn't it? Those are basically a form of concurrency, so Send isn't "free".

Also see Zulip.

@RalfJungRalfJungMar 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#154357 updates the comment for this impl.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Apr 18, 2026
@GuillaumeGomez
Rollup merge ofrust-lang#154003- ginnyTheCat:uefi-file-send, r=Mark…
ddc7bec
…-Simulacrum
Make std::fs::File Send on UEFI
Similarly to rust-lang#150990 since UEFI has no threads, this should be safe.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 18, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154003- ginnyTheCat:uefi-file-send, r=Mark…
a2282cf
…-Simulacrum
Make std::fs::File Send on UEFI
Similarly to rust-lang#150990 since UEFI has no threads, this should be safe.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 18, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154003- ginnyTheCat:uefi-file-send, r=Mark…
f766867
…-Simulacrum
Make std::fs::File Send on UEFI
Similarly to rust-lang#150990 since UEFI has no threads, this should be safe.
rust-timer added a commit that referenced this pull request Apr 18, 2026
@rust-timer
Unrolled build for#154003
ae8563a
Rollup merge of #154003 - ginnyTheCat:uefi-file-send, r=Mark-Simulacrum
Make std::fs::File Send on UEFI
Similarly to #150990 since UEFI has no threads, this should be safe.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments

Assignees

@joboetjoboet

Labels

O-UEFIUEFIS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Ayush1325@rustbot@joboet@RalfJung@tgross35