Convert to inline diagnostics in `rustc_mir_build` by GuillaumeGomez · Pull Request #152126 · rust-lang/rust

GuillaumeGomez · 2026-02-04T18:11:41Z

Part of #151366.

r? @JonathanBrouwer

rustbot · 2026-02-04T18:11:45Z

Some changes occurred in match checking

cc @Nadrieril

JonathanBrouwer · 2026-02-04T18:19:29Z

@bors r+ rollup

rust-bors · 2026-02-04T18:19:32Z

📌 Commit e424077 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 8 pull requests Successful merges: - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

Rollup of 15 pull requests Successful merges: - #151431 (Add new unstable attribute: `#[export_visibility = ...]`.) - #146900 (Add avr_target_feature) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

Rollup of 19 pull requests Successful merges: - #146900 (Add avr_target_feature) - #150379 (Return `ExitCode` from `rustc_driver::main` instead of calling `process::exit`) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152145 (Disable flaky test `oneshot::recv_timeout_before_send`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152110 (Fix incorrect RSS on systems with non-4K page size) - #152111 (bootstrap: exclude hexagon-unknown-qurt from llvm-libunwind default) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

…uwer Rollup of 18 pull requests Successful merges: - #150379 (Return `ExitCode` from `rustc_driver::main` instead of calling `process::exit`) - #152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - #152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - #152145 (Disable flaky test `oneshot::recv_timeout_before_send`) - #152020 (Remove dummy loads on offload codegen) - #152023 (Some `rustc_query_system` cleanups) - #152068 (Convert to inline diagnostics in `rustc_resolve`) - #152081 (Port depgraph testing attributes to parser) - #152090 (Port reexport_test_harness_main to attr parser) - #152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - #152108 (Convert to inline diagnostics in `rustc_expand`) - #152110 (Fix incorrect RSS on systems with non-4K page size) - #152111 (bootstrap: exclude hexagon-unknown-qurt from llvm-libunwind default) - #152114 (Convert to inline diagnostics in `rustc_mir_transform`) - #152115 (Convert to inline diagnostics in `rustc_metadata`) - #152116 (Remove rustdoc GUI flaky test) - #152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - #152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - #152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - #152106 (Convert to inline diagnostics in `rustc_ast_passes`) - #152109 (Convert to inline diagnostics in `rustc_errors`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152119 (Convert to inline diagnostics in `rustc_middle`) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152131 (Port rustc_no_implicit_bounds attribute to parser.)

JonathanBrouwer · 2026-02-05T11:52:05Z

@bors r+

rust-bors · 2026-02-05T11:52:08Z

📌 Commit 3c0d2fe has been approved by JonathanBrouwer

It is now in the queue for this repository.

rustbot · 2026-02-06T21:21:58Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-02-06T21:22:35Z

@bors r+

rust-bors · 2026-02-06T21:22:38Z

📌 Commit 885a808 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@JonathanBrouwer

…ir_build, r=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of rust-lang#151366. r? @JonathanBrouwer

@JonathanBrouwer

…ir_build, r=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of rust-lang#151366. r? @JonathanBrouwer

@JonathanBrouwer

…ir_build, r=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of rust-lang#151366. r? @JonathanBrouwer

…uwer Rollup of 5 pull requests Successful merges: - #149960 (add `unreachable_cfg_select_predicates` lint) - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152186 (Convert to inline diagnostics in `rustc_const_eval`) - #152234 (Dont strip const blocks in array lengths) - #152243 (Use relative paths for std links in rustc-docs)

…uwer Rollup of 4 pull requests Successful merges: - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152186 (Convert to inline diagnostics in `rustc_const_eval`) - #152234 (Dont strip const blocks in array lengths) - #152243 (Use relative paths for std links in rustc-docs)

rust-bors · 2026-02-07T00:29:19Z

⌛ Testing commit 885a808 with merge c93722b...

Workflow: https://github.com/rust-lang/rust/actions/runs/21770720212

@JonathanBrouwer

…=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of #151366. r? @JonathanBrouwer

JonathanBrouwer · 2026-02-07T00:31:52Z

@bors yield
Yielding to enclosing rollup

rust-bors · 2026-02-07T00:31:55Z

Auto build cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/21770720212

The next pull request likely to be tested is #152264.

…uwer Rollup of 4 pull requests Successful merges: - #152126 (Convert to inline diagnostics in `rustc_mir_build`) - #152186 (Convert to inline diagnostics in `rustc_const_eval`) - #152234 (Dont strip const blocks in array lengths) - #152243 (Use relative paths for std links in rustc-docs)

@JonathanBrouwer

Rollup merge of #152126 - GuillaumeGomez:inline-diag-rustc_mir_build, r=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of #151366. r? @JonathanBrouwer

JonathanBrouwer · 2026-02-07T08:20:26Z

@rust-timer build 54f4034

rust-timer · 2026-02-07T09:21:30Z

Finished benchmarking commit (54f4034): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.6%, -0.5%]	2
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 0.9%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.9%, 0.9%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.8%	[-1.8%, -1.8%]	1
All ❌✅ (primary)	0.9%	[0.9%, 0.9%]	1

Cycles

Results (primary 2.3%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	7.6%	[7.6%, 7.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.3%, -2.3%]	2
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.536s -> 473.597s (-0.20%)
Artifact size: 397.98 MiB -> 398.03 MiB (0.01%)

…uwer Rollup of 18 pull requests Successful merges: - rust-lang/rust#150379 (Return `ExitCode` from `rustc_driver::main` instead of calling `process::exit`) - rust-lang/rust#152033 (Rename trait `DepNodeParams` to `DepNodeKey`) - rust-lang/rust#152142 (Convert to inline diagnostics in `rustc_hir_typeck`) - rust-lang/rust#152145 (Disable flaky test `oneshot::recv_timeout_before_send`) - rust-lang/rust#152020 (Remove dummy loads on offload codegen) - rust-lang/rust#152023 (Some `rustc_query_system` cleanups) - rust-lang/rust#152068 (Convert to inline diagnostics in `rustc_resolve`) - rust-lang/rust#152081 (Port depgraph testing attributes to parser) - rust-lang/rust#152090 (Port reexport_test_harness_main to attr parser) - rust-lang/rust#152105 (Convert to inline diagnostics in `rustc_ast_lowering`) - rust-lang/rust#152108 (Convert to inline diagnostics in `rustc_expand`) - rust-lang/rust#152110 (Fix incorrect RSS on systems with non-4K page size) - rust-lang/rust#152111 (bootstrap: exclude hexagon-unknown-qurt from llvm-libunwind default) - rust-lang/rust#152114 (Convert to inline diagnostics in `rustc_mir_transform`) - rust-lang/rust#152115 (Convert to inline diagnostics in `rustc_metadata`) - rust-lang/rust#152116 (Remove rustdoc GUI flaky test) - rust-lang/rust#152118 (Convert to inline diagnostics in `rustc_codegen_ssa`) - rust-lang/rust#152128 (Adopt matches-logical-or-141497.rs to LLVM HEAD) Failed merges: - rust-lang/rust#152070 (Convert to inline diagnostics in `rustc_pattern_analysis`) - rust-lang/rust#152106 (Convert to inline diagnostics in `rustc_ast_passes`) - rust-lang/rust#152109 (Convert to inline diagnostics in `rustc_errors`) - rust-lang/rust#152117 (Convert to inline diagnostics in `rustc_trait_selection`) - rust-lang/rust#152119 (Convert to inline diagnostics in `rustc_middle`) - rust-lang/rust#152126 (Convert to inline diagnostics in `rustc_mir_build`) - rust-lang/rust#152131 (Port rustc_no_implicit_bounds attribute to parser.)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026

rustbot assigned JonathanBrouwer Feb 4, 2026

JonathanBrouwer mentioned this pull request Feb 4, 2026
Tracking issue for MCP 959: Remove the fluent files #151366
Closed
7 tasks

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2026

This was referenced Feb 4, 2026
Rollup of 6 pull requests #152127
Closed
Rollup of 7 pull requests #152130
Closed
Rollup of 8 pull requests #152135
Closed

Zalathar mentioned this pull request Feb 5, 2026
Rollup of 15 pull requests #152144
Closed

This was referenced Feb 5, 2026
Rollup of 18 pull requests #152147
Closed
Rollup of 19 pull requests #152149
Closed

JonathanBrouwer mentioned this pull request Feb 5, 2026
Rollup of 18 pull requests #152156
Merged

JonathanBrouwer mentioned this pull request Feb 5, 2026
Rollup of 9 pull requests #152163
Merged

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 5, 2026

This comment has been minimized.
Sign in to view

GuillaumeGomez force-pushed the inline-diag-rustc_mir_build branch from e424077 to 3c0d2feCompare February 5, 2026 11:34

This comment has been minimized.
Sign in to view

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 5, 2026

Convert to inline diagnostics in rustc_mir_build
885a808

GuillaumeGomez force-pushed the inline-diag-rustc_mir_build branch from 3c0d2fe to 885a808Compare February 6, 2026 21:21

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 6, 2026

JonathanBrouwer mentioned this pull request Feb 6, 2026
Convert diagnostic style checks #152252
Merged

JonathanBrouwer mentioned this pull request Feb 6, 2026
Rollup of 3 pull requests #152256
Closed

JonathanBrouwer mentioned this pull request Feb 6, 2026
Rollup of 4 pull requests #152257
Closed

JonathanBrouwer mentioned this pull request Feb 6, 2026
Rollup of 5 pull requests #152260
Closed

JonathanBrouwer mentioned this pull request Feb 7, 2026
Rollup of 4 pull requests #152264
Merged

rust-borsBot pushed a commit that referenced this pull request Feb 7, 2026
Auto merge of#152126- GuillaumeGomez:inline-diag-rustc_mir_build, r…
c93722b
…=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of #151366. r? @JonathanBrouwer

rust-borsBot merged commit 4fa1cdb into rust-lang:mainFeb 7, 2026
11 of 12 checks passed

rustbot added this to the 1.95.0 milestone Feb 7, 2026

rust-timer added a commit that referenced this pull request Feb 7, 2026
Unrolled build for#152126
54f4034
Rollup merge of #152126 - GuillaumeGomez:inline-diag-rustc_mir_build, r=JonathanBrouwer Convert to inline diagnostics in `rustc_mir_build` Part of #151366. r? @JonathanBrouwer

This comment has been minimized.
Sign in to view

GuillaumeGomez deleted the inline-diag-rustc_mir_build branch February 7, 2026 16:01

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Feb 4, 2026

Uh oh!

rustbot commented Feb 4, 2026

Uh oh!

JonathanBrouwer commented Feb 4, 2026

Uh oh!

rust-borsBot commented Feb 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

JonathanBrouwer commented Feb 5, 2026

Uh oh!

rust-borsBot commented Feb 5, 2026

Uh oh!

rustbot commented Feb 6, 2026

Uh oh!

JonathanBrouwer commented Feb 6, 2026

Uh oh!

rust-borsBot commented Feb 6, 2026

Uh oh!

rust-borsBot commented Feb 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

rust-borsBot commented Feb 7, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 7, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 7, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rust-borsBot commented Feb 7, 2026•
edited
Loading