Skip to content

Convert diagnostic style checks - #152252

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:port-tidy-checks
Feb 7, 2026
Merged

Convert diagnostic style checks#152252
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JonathanBrouwer:port-tidy-checks

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Feb 6, 2026•
edited
Loading

Copy link
Copy Markdown
Member

@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

rustc_macros::diagnostics was changed

cc @davidtwco, @TaKO8Ki

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-tidy Area: The tidy tool A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@rustbotrustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 6, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 6, 2026
Closed
7 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Feb 6, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

@rustbotrustbot added the PG-exploit-mitigations Project group: Exploit mitigations label Feb 6, 2026
@jdonszelmann

jdonszelmann commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-borsBot commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 341f701 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
@JonathanBrouwer

JonathanBrouwer commented Feb 6, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r-
Soft conflict with #152126

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 6, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
JonathanBrouwerforce-pushed the port-tidy-checks branch 2 times, most recently from 0a5073e to b055778CompareFebruary 6, 2026 22:30
@rustbot

This comment has been minimized.

Sign in to view
@jdonszelmann

jdonszelmann commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

Doesn't actually seem to conflict, @bors r+

@rust-bors

rust-borsBot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b055778 has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
@rustbot

rustbot commented Feb 7, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 7, 2026
@rustbotrustbot added the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Feb 7, 2026
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 7, 2026
@rust-bors

rust-borsBot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

⚠️ A new commit c1091da34c052b2260c7d4d5e0d4c6a63a34a0b8 was pushed to the branch, the PR will need to be re-approved.

@rustbot

rustbot commented Feb 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer

JonathanBrouwer commented Feb 7, 2026

Copy link
Copy Markdown
MemberAuthor

It does soft conflict however :)
@bors r=jdonszelmann

@rust-bors

rust-borsBot commented Feb 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c1091da has been approved by jdonszelmann

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#152252- JonathanBrouwer:port-tidy-checks, …
be7d386
…r=jdonszelmann
Convert diagnostic style checks
For rust-lang#151366
r? @jdonszelmann
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#152252- JonathanBrouwer:port-tidy-checks, …
e27f734
…r=jdonszelmann
Convert diagnostic style checks
For rust-lang#151366
r? @jdonszelmann
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 7, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 7, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#152252- JonathanBrouwer:port-tidy-checks, …
1f4ee16
…r=jdonszelmann
Convert diagnostic style checks
For rust-lang#151366
r? @jdonszelmann
This was referenced Feb 7, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Feb 7, 2026
@bors
Auto merge of#152274- JonathanBrouwer:rollup-5GoDGKf, r=JonathanBro…
06cafcb
…uwer
Rollup of 4 pull requests
Successful merges:
- #146900 (Add avr_target_feature)
- #150949 (Port symbol mangler attrs)
- #152252 (Convert diagnostic style checks)
- #152265 (Use `.map.collect` to aggregate in `.to_ty` of tuples)
This was referenced Feb 7, 2026
Merged
Merged
@rust-bors
rust-borsBot merged commit 723eb92 into rust-lang:mainFeb 7, 2026
11 checks passed
@rustbotrustbot added this to the 1.95.0 milestone Feb 7, 2026
rust-timer added a commit that referenced this pull request Feb 7, 2026
@rust-timer
Unrolled build for#152252
cb01915
Rollup merge of #152252 - JonathanBrouwer:port-tidy-checks, r=jdonszelmann
Convert diagnostic style checks
For #151366
r? @jdonszelmann
@WaffleLapkinWaffleLapkin removed the F-explicit_tail_calls `#![feature(explicit_tail_calls)]` label Feb 25, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmannjdonszelmann

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-tidyArea: The tidy toolA-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticPG-exploit-mitigationsProject group: Exploit mitigationsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@JonathanBrouwer@rustbot@rust-log-analyzer@jdonszelmann@WaffleLapkin