Skip to content

Consolidate type const checks on tcx.is_type_const - #152136

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
eggyal:consolidate-type-const-checks
Feb 6, 2026
Merged

Consolidate type const checks on tcx.is_type_const#152136
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
eggyal:consolidate-type-const-checks

Conversation

@eggyal

@eggyaleggyal commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

A little bit of cleanup; explanation can be found in the reporting issue.

Fixes#152124
r? BoxyUwU

@rustbot

Copy link
Copy Markdown
Collaborator

HIR ty lowering was modified

cc @fmease

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 4, 2026
@BoxyUwU

Copy link
Copy Markdown
Member

@bors r+ rollup

thanks :)

@rust-bors

rust-borsBot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 13141af has been approved by BoxyUwU

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 5, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 5, 2026
…ks, r=BoxyUwU
Consolidate type const checks on `tcx.is_type_const`
A little bit of cleanup; explanation can be found in the reporting issue.
Fixesrust-lang#152124
r? BoxyUwU
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 5, 2026
…ks, r=BoxyUwU
Consolidate type const checks on `tcx.is_type_const`
A little bit of cleanup; explanation can be found in the reporting issue.
Fixesrust-lang#152124
r? BoxyUwU
rust-borsBot pushed a commit that referenced this pull request Feb 5, 2026
…uwer
Rollup of 9 pull requests
Successful merges:
- #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
- #151955 (escape symbol names in global asm)
- #149329 (Mark match arms in try and for as being from desugarings.)
- #151474 (Minor structural improvements)
- #151744 (fix refining_impl_trait suggestion with return_type_notation)
- #152107 (Convert to inline diagnostics in `rustc_borrowck`)
- #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- #152136 (Consolidate type const checks on `tcx.is_type_const`)
- #152170 (Port `rustc_effective_visibility` to the new attribute parser)
rust-borsBot pushed a commit that referenced this pull request Feb 5, 2026
…uwer
Rollup of 9 pull requests
Successful merges:
- #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
- #151955 (escape symbol names in global asm)
- #149329 (Mark match arms in try and for as being from desugarings.)
- #151474 (Minor structural improvements)
- #151744 (fix refining_impl_trait suggestion with return_type_notation)
- #152107 (Convert to inline diagnostics in `rustc_borrowck`)
- #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- #152136 (Consolidate type const checks on `tcx.is_type_const`)
- #152170 (Port `rustc_effective_visibility` to the new attribute parser)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 5, 2026
…ks, r=BoxyUwU
Consolidate type const checks on `tcx.is_type_const`
A little bit of cleanup; explanation can be found in the reporting issue.
Fixesrust-lang#152124
r? BoxyUwU
rust-borsBot pushed a commit that referenced this pull request Feb 5, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- #152174 (stdarch subtree update)
- #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
- #151955 (escape symbol names in global asm)
- #149329 (Mark match arms in try and for as being from desugarings.)
- #151474 (Minor structural improvements)
- #151744 (fix refining_impl_trait suggestion with return_type_notation)
- #152107 (Convert to inline diagnostics in `rustc_borrowck`)
- #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- #152136 (Consolidate type const checks on `tcx.is_type_const`)
- #152170 (Port `rustc_effective_visibility` to the new attribute parser)
- #152184 (Port rustc_abi to the attribute parser)
rust-borsBot pushed a commit that referenced this pull request Feb 5, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- #152174 (stdarch subtree update)
- #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
- #151955 (escape symbol names in global asm)
- #149329 (Mark match arms in try and for as being from desugarings.)
- #151474 (Minor structural improvements)
- #151744 (fix refining_impl_trait suggestion with return_type_notation)
- #152107 (Convert to inline diagnostics in `rustc_borrowck`)
- #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- #152136 (Consolidate type const checks on `tcx.is_type_const`)
- #152170 (Port `rustc_effective_visibility` to the new attribute parser)
- #152184 (Port rustc_abi to the attribute parser)
rust-borsBot pushed a commit that referenced this pull request Feb 5, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- #152174 (stdarch subtree update)
- #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
- #151955 (escape symbol names in global asm)
- #149329 (Mark match arms in try and for as being from desugarings.)
- #151474 (Minor structural improvements)
- #151744 (fix refining_impl_trait suggestion with return_type_notation)
- #152107 (Convert to inline diagnostics in `rustc_borrowck`)
- #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- #152136 (Consolidate type const checks on `tcx.is_type_const`)
- #152170 (Port `rustc_effective_visibility` to the new attribute parser)
- #152184 (Port rustc_abi to the attribute parser)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 6, 2026
…ks, r=BoxyUwU
Consolidate type const checks on `tcx.is_type_const`
A little bit of cleanup; explanation can be found in the reporting issue.
Fixesrust-lang#152124
r? BoxyUwU
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 6, 2026
…ks, r=BoxyUwU
Consolidate type const checks on `tcx.is_type_const`
A little bit of cleanup; explanation can be found in the reporting issue.
Fixesrust-lang#152124
r? BoxyUwU
This was referenced Feb 6, 2026
rust-borsBot pushed a commit that referenced this pull request Feb 6, 2026
…uwer
Rollup of 13 pull requests
Successful merges:
- #152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
- #149329 (Mark match arms in try and for as being from desugarings.)
- #151474 (Minor structural improvements)
- #152107 (Convert to inline diagnostics in `rustc_borrowck`)
- #152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- #152136 (Consolidate type const checks on `tcx.is_type_const`)
- #152140 (Hard code the error code registry for custom drivers)
- #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md)
- #152170 (Port `rustc_effective_visibility` to the new attribute parser)
- #152182 (update compiler stable backport zulip msg)
- #152184 (Port rustc_abi to the attribute parser)
- #152195 (update openmp/offload builds to LLVM 22, Part 1)
- #152202 (chore: clearify tidy's error message)
Failed merges:
- #151744 (fix refining_impl_trait suggestion with return_type_notation)
- #152212 (Port some attributes to the attr parser)
@rust-bors
rust-borsBot merged commit ce706cd into rust-lang:mainFeb 6, 2026
11 checks passed
@rustbotrustbot added this to the 1.95.0 milestone Feb 6, 2026
rust-timer added a commit that referenced this pull request Feb 6, 2026
Rollup merge of #152136 - eggyal:consolidate-type-const-checks, r=BoxyUwU
Consolidate type const checks on `tcx.is_type_const`
A little bit of cleanup; explanation can be found in the reporting issue.
Fixes#152124
r? BoxyUwU
@eggyal
eggyal deleted the consolidate-type-const-checks branch February 6, 2026 13:16
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Feb 16, 2026
…uwer
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
- rust-lang/rust#149329 (Mark match arms in try and for as being from desugarings.)
- rust-lang/rust#151474 (Minor structural improvements)
- rust-lang/rust#152107 (Convert to inline diagnostics in `rustc_borrowck`)
- rust-lang/rust#152117 (Convert to inline diagnostics in `rustc_trait_selection`)
- rust-lang/rust#152136 (Consolidate type const checks on `tcx.is_type_const`)
- rust-lang/rust#152140 (Hard code the error code registry for custom drivers)
- rust-lang/rust#152155 (Fix typos in riscv64a23-unknown-linux-gnu.md)
- rust-lang/rust#152170 (Port `rustc_effective_visibility` to the new attribute parser)
- rust-lang/rust#152182 (update compiler stable backport zulip msg)
- rust-lang/rust#152184 (Port rustc_abi to the attribute parser)
- rust-lang/rust#152195 (update openmp/offload builds to LLVM 22, Part 1)
- rust-lang/rust#152202 (chore: clearify tidy's error message)
Failed merges:
- rust-lang/rust#151744 (fix refining_impl_trait suggestion with return_type_notation)
- rust-lang/rust#152212 (Port some attributes to the attr parser)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mGCA: consolidate type const checks on tcx.is_type_const

3 participants

@eggyal@rustbot@BoxyUwU