Uh oh!
There was an error while loading. Please reload this page.
Port rustc_effective_visibility to the new attribute parser - #152170
Merged
rust-bors[bot] merged 1 commit intoFeb 6, 2026
Conversation
rustbot
commented
Feb 5, 2026
Collaborator
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred in compiler/rustc_attr_parsing Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt
cc @rust-lang/wg-const-eval Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
jdonszelmann
commented
Feb 5, 2026
ContributorAuthor
let's do this one separately, it's unrelated |
jdonszelmann
commented
Feb 5, 2026
ContributorAuthor
based on it anyway, since we'll get conflicts. They're next to eachother in a file. |
9 tasks
jdonszelmann
commented
Feb 5, 2026
ContributorAuthor
unlinked them after all |
jdonszelmannforce-pushed
the
port-rustc-effective-visibility
branch
from
February 5, 2026 14:19
58d3317 to
4935b73Compare
This comment has been minimized.
This comment has been minimized.
jdonszelmannforce-pushed
the
port-rustc-effective-visibility
branch
from
February 5, 2026 14:33
4935b73 to
9112039CompareJonathanBrouwer
commented
Feb 5, 2026
Member
@bors r+ rollup |
Contributor
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 9 pull requests Successful merges: - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 9 pull requests Successful merges: - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser)
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 5, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152184 (Port rustc_abi to the attribute parser)
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152184 (Port rustc_abi to the attribute parser)
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 5, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152174 (stdarch subtree update) - #151278 (Provide more context on trait bounds being unmet due to imperfect derive) - #151955 (escape symbol names in global asm) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152184 (Port rustc_abi to the attribute parser)
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 6, 2026
…visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
This was referenced Feb 6, 2026
rust-borsBot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…uwer Rollup of 13 pull requests Successful merges: - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`) - #149329 (Mark match arms in try and for as being from desugarings.) - #151474 (Minor structural improvements) - #152107 (Convert to inline diagnostics in `rustc_borrowck`) - #152117 (Convert to inline diagnostics in `rustc_trait_selection`) - #152136 (Consolidate type const checks on `tcx.is_type_const`) - #152140 (Hard code the error code registry for custom drivers) - #152155 (Fix typos in riscv64a23-unknown-linux-gnu.md) - #152170 (Port `rustc_effective_visibility` to the new attribute parser) - #152182 (update compiler stable backport zulip msg) - #152184 (Port rustc_abi to the attribute parser) - #152195 (update openmp/offload builds to LLVM 22, Part 1) - #152202 (chore: clearify tidy's error message) Failed merges: - #151744 (fix refining_impl_trait suggestion with return_type_notation) - #152212 (Port some attributes to the attr parser)
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Feb 6, 2026
Rollup merge of #152170 - jdonszelmann:port-rustc-effective-visibility, r=JonathanBrouwer Port `rustc_effective_visibility` to the new attribute parser r? @JonathanBrouwer
github-actionsBot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Feb 16, 2026
…uwer Rollup of 13 pull requests Successful merges: - rust-lang/rust#152191 (Convert to inline diagnostics in `rustc_hir_analysis`) - rust-lang/rust#149329 (Mark match arms in try and for as being from desugarings.) - rust-lang/rust#151474 (Minor structural improvements) - rust-lang/rust#152107 (Convert to inline diagnostics in `rustc_borrowck`) - rust-lang/rust#152117 (Convert to inline diagnostics in `rustc_trait_selection`) - rust-lang/rust#152136 (Consolidate type const checks on `tcx.is_type_const`) - rust-lang/rust#152140 (Hard code the error code registry for custom drivers) - rust-lang/rust#152155 (Fix typos in riscv64a23-unknown-linux-gnu.md) - rust-lang/rust#152170 (Port `rustc_effective_visibility` to the new attribute parser) - rust-lang/rust#152182 (update compiler stable backport zulip msg) - rust-lang/rust#152184 (Port rustc_abi to the attribute parser) - rust-lang/rust#152195 (update openmp/offload builds to LLVM 22, Part 1) - rust-lang/rust#152202 (chore: clearify tidy's error message) Failed merges: - rust-lang/rust#151744 (fix refining_impl_trait suggestion with return_type_notation) - rust-lang/rust#152212 (Port some attributes to the attr parser)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @JonathanBrouwer