Skip to content

Remove QuerySystemFns - #153078

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
nnethercote:rm-QuerySystemFns
Feb 26, 2026
Merged

Remove QuerySystemFns#153078
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
nnethercote:rm-QuerySystemFns

Conversation

@nnethercote

@nnethercotennethercote commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

Two small query-related cleanups.

r? petrochenkov

@nnethercote
Remove QuerySystemFns.
b76b26d
It has a single use and doesn't provide any real value. Removing it
allows the removal of two `for<'tcx>` qualifiers.
@nnethercote
Move two functions into hooks.
608d85f
`QuerySystem` has two function pointers: `encode_query_results` and
`try_mark_green`. These exist so that `rustc_middle` can call functions
from upstream crates.
But we have a more general mechanism for that: hooks. So this commit
converts these two cases into hooks.
@rustbotrustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2026
@petrochenkov

petrochenkov commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-borsBot commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 608d85f has been approved by petrochenkov

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 25, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153078- nnethercote:rm-QuerySystemFns, r=p…
9a2fc87
…etrochenkov
Remove `QuerySystemFns`
Two small query-related cleanups.
r? petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 25, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 25, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153078- nnethercote:rm-QuerySystemFns, r=p…
f01d162
…etrochenkov
Remove `QuerySystemFns`
Two small query-related cleanups.
r? petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 25, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 25, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153078- nnethercote:rm-QuerySystemFns, r=p…
a4f533b
…etrochenkov
Remove `QuerySystemFns`
Two small query-related cleanups.
r? petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 25, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 25, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153078- nnethercote:rm-QuerySystemFns, r=p…
f5a2ee6
…etrochenkov
Remove `QuerySystemFns`
Two small query-related cleanups.
r? petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 25, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Feb 25, 2026
@bors
Auto merge of#153098- JonathanBrouwer:rollup-dGxVpH7, r=JonathanBro…
2a2e570
…uwer
Rollup of 13 pull requests
Successful merges:
- #153079 (Revert "Move aarch64-apple dist builder to dynamic llvm linking")
- #148146 (CI: use alternative disks if available)
- #149937 (spliit out `linker-info` from `linker-messages`)
- #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
- #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
- #153075 (mGCA: Lower negated literals directly and reject non-integer negations)
- #153078 (Remove `QuerySystemFns`)
- #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
- #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
- #153063 (`is_ty_must_use`: do not require a `span` argument)
- #153071 (Update books)
- #153092 (Remove redundant self usages)
- #153094 (Simplify `AppendOnlyVec` iterators)
Failed merges:
- #153091 (Migration of `LintDiagnostic` - part 4)
@jhprattjhpratt mentioned this pull request Feb 26, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Feb 26, 2026
@bors
Auto merge of#153116- jhpratt:rollup-yjBVB1Y, r=jhpratt
f02672c
Rollup of 13 pull requests
Successful merges:
- #148146 (CI: use alternative disks if available)
- #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
- #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
- #153075 (mGCA: Lower negated literals directly and reject non-integer negations)
- #153078 (Remove `QuerySystemFns`)
- #153089 (interpret: avoid dummy spans in the stacktrace)
- #153111 (Refactor url_parts to return is_absolute instead of out param)
- #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
- #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
- #153063 (`is_ty_must_use`: do not require a `span` argument)
- #153071 (Update books)
- #153092 (Remove redundant self usages)
- #153094 (Simplify `AppendOnlyVec` iterators)
Failed merges:
- #153091 (Migration of `LintDiagnostic` - part 4)
@rust-bors
rust-borsBot merged commit 49a9885 into rust-lang:mainFeb 26, 2026
11 checks passed
@rustbotrustbot added this to the 1.95.0 milestone Feb 26, 2026
rust-timer added a commit that referenced this pull request Feb 26, 2026
@rust-timer
Unrolled build for#153078
761cc7e
Rollup merge of #153078 - nnethercote:rm-QuerySystemFns, r=petrochenkov
Remove `QuerySystemFns`
Two small query-related cleanups.
r? petrochenkov
@nnethercote
nnethercote deleted the rm-QuerySystemFns branch February 26, 2026 08:08
@JonathanBrouwer

JonathanBrouwer commented Feb 26, 2026

Copy link
Copy Markdown
Member

@rust-timer build 761cc7e

@rust-timer

This comment has been minimized.

Sign in to view
RalfJung pushed a commit to RalfJung/miri that referenced this pull request Feb 26, 2026
@bors
Auto merge of #153116 - jhpratt:rollup-yjBVB1Y, r=jhpratt
dc44ae7
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#148146 (CI: use alternative disks if available)
- rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
- rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
- rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations)
- rust-lang/rust#153078 (Remove `QuerySystemFns`)
- rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace)
- rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param)
- rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
- rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
- rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument)
- rust-lang/rust#153071 (Update books)
- rust-lang/rust#153092 (Remove redundant self usages)
- rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators)
Failed merges:
- rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
@rust-timer

rust-timer commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (761cc7e): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-5.4%[-5.4%, -5.4%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-5.4%[-5.4%, -5.4%]1

Cycles

Results (secondary 2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		2.5%[2.5%, 2.5%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 492.161s -> 479.39s (-2.59%)
Artifact size: 395.78 MiB -> 395.78 MiB (-0.00%)

github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Mar 2, 2026
@bors
Auto merge of #153116 - jhpratt:rollup-yjBVB1Y, r=jhpratt
eee277d
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#148146 (CI: use alternative disks if available)
- rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
- rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
- rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations)
- rust-lang/rust#153078 (Remove `QuerySystemFns`)
- rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace)
- rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param)
- rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
- rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
- rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument)
- rust-lang/rust#153071 (Update books)
- rust-lang/rust#153092 (Remove redundant self usages)
- rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators)
Failed merges:
- rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
@bors
Auto merge of #153116 - jhpratt:rollup-yjBVB1Y, r=jhpratt
db478a4
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#148146 (CI: use alternative disks if available)
- rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
- rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
- rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations)
- rust-lang/rust#153078 (Remove `QuerySystemFns`)
- rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace)
- rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param)
- rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
- rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
- rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument)
- rust-lang/rust#153071 (Update books)
- rust-lang/rust#153092 (Remove redundant self usages)
- rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators)
Failed merges:
- rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #153116 - jhpratt:rollup-yjBVB1Y, r=jhpratt
bd43d2c
Rollup of 13 pull requests
Successful merges:
- rust-lang/rust#148146 (CI: use alternative disks if available)
- rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup)
- rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination)
- rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations)
- rust-lang/rust#153078 (Remove `QuerySystemFns`)
- rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace)
- rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param)
- rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls)
- rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.)
- rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument)
- rust-lang/rust#153071 (Update books)
- rust-lang/rust#153092 (Remove redundant self usages)
- rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators)
Failed merges:
- rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

5 participants

@nnethercote@petrochenkov@JonathanBrouwer@rust-timer@rustbot