interpret: avoid dummy spans in the stacktrace by RalfJung · Pull Request #153089 · rust-lang/rust

RalfJung · 2026-02-25T14:04:17Z

This should fixrust-lang/miri#4871

rustbot · 2026-02-25T14:04:20Z

The Miri subtree was changed

cc @rust-lang/miri

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

Some changes occurred to the CTFE machinery

cc @oli-obk, @lcnr

rustbot · 2026-02-25T14:04:23Z

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler, mir
compiler, mir expanded to 68 candidates
Random selection from 14 candidates

Kivooeo

r=me with ci green

View changes since this review

rust-log-analyzer · 2026-02-25T14:18:18Z

The job pr-check-2 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

REPOSITORY TAG IMAGE ID CREATED SIZE
ghcr.io/dependabot/dependabot-updater-core latest b72a662c47e3 3 weeks ago 790MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:57ef9cc45f72cc4258ee1baa8243bc3cd55c0a0e570b6768c37346247be35f0d
deleted: sha256:b72a662c47e31df2e7bf59368b2b83be239f02a1baa721393717711a1a719df9
deleted: sha256:3e13ccd80f19769f39008cfc6549938e1ea4905f47b028c1df2dd6085191386c
deleted: sha256:842807995a512b2c5a9b241a3aecdbe79af6b0642d96fa5460cfcf0c9d8be295
deleted: sha256:0f9074b9f46f4570eb7cb4b65fcb3c3d909f9b1d14ca66b30508117b6deda303
deleted: sha256:2ca99cb9251d19157c56b5d91c8961bb4b35196a5ca9b4ffdccbf24abbfe2a5f

Kivooeo · 2026-02-25T14:23:08Z

Some network issues

RalfJung · 2026-02-25T14:47:11Z

(I had already restarted CI.)

RalfJung · 2026-02-25T19:54:03Z

@bors r=Kivooeo

rust-bors · 2026-02-25T19:54:06Z

📌 Commit 82e5ed6 has been approved by Kivooeo

It is now in the queue for this repository.

Rollup of 13 pull requests Successful merges: - #148146 (CI: use alternative disks if available) - #151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - #153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - #153075 (mGCA: Lower negated literals directly and reject non-integer negations) - #153078 (Remove `QuerySystemFns`) - #153089 (interpret: avoid dummy spans in the stacktrace) - #153111 (Refactor url_parts to return is_absolute instead of out param) - #149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - #153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - #153063 (`is_ty_must_use`: do not require a `span` argument) - #153071 (Update books) - #153092 (Remove redundant self usages) - #153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - #153091 (Migration of `LintDiagnostic` - part 4)

Rollup merge of #153089 - RalfJung:no-dummys, r=Kivooeo interpret: avoid dummy spans in the stacktrace This should fixrust-lang/miri#4871

JonathanBrouwer · 2026-02-26T16:48:04Z

@rust-timer build 0fb636b

Rollup of 13 pull requests Successful merges: - rust-lang/rust#148146 (CI: use alternative disks if available) - rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations) - rust-lang/rust#153078 (Remove `QuerySystemFns`) - rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace) - rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param) - rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument) - rust-lang/rust#153071 (Update books) - rust-lang/rust#153092 (Remove redundant self usages) - rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)

rust-timer · 2026-02-26T19:24:37Z

Finished benchmarking commit (0fb636b): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -5.8%, secondary 8.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	8.1%	[7.9%, 8.2%]	2
Improvements ✅ (primary)	-5.8%	[-5.8%, -5.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-5.8%	[-5.8%, -5.8%]	1

Cycles

Results (secondary -5.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-5.4%	[-5.4%, -5.4%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 492.161s -> 481.873s (-2.09%)
Artifact size: 395.78 MiB -> 397.80 MiB (0.51%)

Rollup of 13 pull requests Successful merges: - rust-lang/rust#148146 (CI: use alternative disks if available) - rust-lang/rust#151771 (Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup) - rust-lang/rust#153035 (rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination) - rust-lang/rust#153075 (mGCA: Lower negated literals directly and reject non-integer negations) - rust-lang/rust#153078 (Remove `QuerySystemFns`) - rust-lang/rust#153089 (interpret: avoid dummy spans in the stacktrace) - rust-lang/rust#153111 (Refactor url_parts to return is_absolute instead of out param) - rust-lang/rust#149978 (deprecate `Eq::assert_receiver_is_total_eq` and emit FCW on manual impls) - rust-lang/rust#153029 (Rename `rustc::pass_by_value` lint as `rustc::disallowed_pass_by_ref`.) - rust-lang/rust#153063 (`is_ty_must_use`: do not require a `span` argument) - rust-lang/rust#153071 (Update books) - rust-lang/rust#153092 (Remove redundant self usages) - rust-lang/rust#153094 (Simplify `AppendOnlyVec` iterators) Failed merges: - rust-lang/rust#153091 (Migration of `LintDiagnostic` - part 4)

interpret: avoid dummy spans in the stacktrace
82e5ed6

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2026

rustbot assigned TaKO8Ki Feb 25, 2026

RalfJung mentioned this pull request Feb 25, 2026
Panics with -Zmiri-report-progress when MIR basic blocks have no source location rust-lang/miri#4871
Closed

Kivooeo approved these changes Feb 25, 2026
View reviewed changes

Kivooeo closed this Feb 25, 2026

Kivooeo reopened this Feb 25, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026

RalfJung closed this Feb 25, 2026

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2026

RalfJung reopened this Feb 25, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 25, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026

jhpratt mentioned this pull request Feb 26, 2026
Rollup of 13 pull requests #153116
Merged

rust-borsBot merged commit ec78ad8 into rust-lang:mainFeb 26, 2026
25 of 55 checks passed

rustbot added this to the 1.95.0 milestone Feb 26, 2026

rust-timer added a commit that referenced this pull request Feb 26, 2026
Unrolled build for#153089
0fb636b
Rollup merge of #153089 - RalfJung:no-dummys, r=Kivooeo interpret: avoid dummy spans in the stacktrace This should fixrust-lang/miri#4871

This comment has been minimized.
Sign in to view

RalfJung deleted the no-dummys branch March 3, 2026 08:42

Navigation Menu

Uh oh!

Uh oh!

interpret: avoid dummy spans in the stacktrace - #153089

interpret: avoid dummy spans in the stacktrace#153089
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
RalfJung:no-dummys

RalfJung commented Feb 25, 2026

Uh oh!

rustbot commented Feb 25, 2026

Uh oh!

rustbot commented Feb 25, 2026

Uh oh!

Kivooeo left a comment •
edited by rustbot
Loading

Uh oh!

rust-log-analyzer commented Feb 25, 2026

Uh oh!

Kivooeo commented Feb 25, 2026

Uh oh!

RalfJung commented Feb 25, 2026

Uh oh!

RalfJung commented Feb 25, 2026

Uh oh!

rust-borsBot commented Feb 25, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 26, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Uh oh!

Conversation

RalfJung commented Feb 25, 2026

Uh oh!

rustbot commented Feb 25, 2026

Uh oh!

rustbot commented Feb 25, 2026

Uh oh!

Kivooeo left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-log-analyzer commented Feb 25, 2026

Uh oh!

Kivooeo commented Feb 25, 2026

Uh oh!

RalfJung commented Feb 25, 2026

Uh oh!

RalfJung commented Feb 25, 2026

Uh oh!

rust-borsBot commented Feb 25, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented Feb 26, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Feb 26, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Kivooeo left a comment •
edited by rustbot
Loading