Various small query cleanups by nnethercote · Pull Request #153169 · rust-lang/rust

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

r? @oli-obk

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

r? @oli-obk

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

r? @oli-obk

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

r? @oli-obk

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

r? @oli-obk

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote · 2026-02-27T08:29:26Z

I found these while doing a close read of the query code.

r? @oli-obk

rustbot · 2026-02-27T08:29:31Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

Zoxc · 2026-02-27T20:10:15Z

 }
 }

-impl<'tcx> FromCycleError<'tcx> for ty::SymbolName<'_> {


These impl are used with the default CycleErrorHandling::Error, so they don't need a query modifier to make use of them. We don't seem to have a test for the use case of this, so it's probably fine to remove anyway.

nnethercote · 2026-03-01T04:56:52Z

I rebased.

@bors r=petrochenkov

rust-bors · 2026-03-01T04:56:54Z

📌 Commit fa5138b has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

It's unused.

It has a single use.

This makes it clear the `CycleError` is not used after the call.

When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

It reads better that way.

It's an unnecessary level of indirection.

Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

`Value` is an unhelpfully generic name. Standard naming procedure for a trait with a single method is for the trait name to match the method name, which is what this commit does. Likewise, the enclosing module is renamed from `values` to `from_cycle_error`. Also add a comment about some non-obvious behaviour.

It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

rustbot · 2026-03-02T03:37:18Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

nnethercote · 2026-03-02T03:37:43Z

I rebased again.

@bors r=petrochenkov

rust-bors · 2026-03-02T03:37:46Z

📌 Commit 5bd28b8 has been approved by petrochenkov

It is now in the queue for this repository.

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

Rollup of 6 pull requests Successful merges: - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153046 (Couple of cg_ssa refactorings) - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

…uwer Rollup of 6 pull requests Successful merges: - #153169 (Various small query cleanups) - #152304 (stabilize new RangeToInclusive type) - #153046 (Couple of cg_ssa refactorings) - #153090 (elf-raw-dylib: set type for functions) - #153225 (tests/ui/asm: add annotations for reference rules) - #153233 (test: add regression test for fuzzy_provenance_casts lint ICE)

@oli-obk

Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

rustbot assigned oli-obk Feb 27, 2026

petrochenkov approved these changes Feb 27, 2026
View reviewed changes

Zoxc reviewed Feb 27, 2026
View reviewed changes

nnethercote mentioned this pull request Feb 27, 2026
Add per query cycle handlers and use them for representability #153028
Closed

This comment has been minimized.
Sign in to view

nnethercote force-pushed the rm-is_anon-etc branch from 2ac9c20 to fa5138bCompare March 1, 2026 03:04

This comment has been minimized.
Sign in to view

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 1, 2026

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 1, 2026
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
ca2655c
…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

matthiaskrgr mentioned this pull request Mar 1, 2026
Rollup of 5 pull requests #153245
Closed

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 1, 2026

This comment has been minimized.
Sign in to view

nnethercote added 10 commits March 2, 2026 14:21

Remove DepKindVTable::is_anon.
72a001b
It's unused.

Inline and remove handle_cycle_error.
cc1b878
It has a single use.

Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.

Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else expression easier to read than an early return.

Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.

Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.

Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call `raise_fatal`, so just do that directly instead.

Remove a duplicated comment.
6f111d2
This exact comment block also appears in `compiler/rustc_middle/src/queries.rs`, which is a better place for it.

Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect. `symbol_name` is the only query that produces a `SymbolName`. If it was marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError` impl would make sense, but that's not the case. Maybe it was the case in the past.

nnethercote force-pushed the rm-is_anon-etc branch from fa5138b to 5bd28b8Compare March 2, 2026 03:37

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 2, 2026

jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 2, 2026
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
e6e02c4
…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

jhpratt mentioned this pull request Mar 2, 2026
Rollup of 6 pull requests #153270
Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 2, 2026
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
3695d75
…ochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

jhpratt mentioned this pull request Mar 2, 2026
Rollup of 6 pull requests #153277
Closed

nnethercote mentioned this pull request Mar 2, 2026
Remove cycle_fatal query modifier #153276
Merged

JonathanBrouwer mentioned this pull request Mar 2, 2026
Rollup of 6 pull requests #153278
Merged

rust-borsBot merged commit af84b2a into rust-lang:mainMar 2, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 2, 2026

rust-timer added a commit that referenced this pull request Mar 2, 2026
Unrolled build for#153169
ef1fd91
Rollup merge of #153169 - nnethercote:rm-is_anon-etc, r=petrochenkov Various small query cleanups I found these while doing a close read of the query code. r? @oli-obk

nnethercote deleted the rm-is_anon-etc branch March 2, 2026 21:16

nnethercote mentioned this pull request Mar 3, 2026
Abort after representability errors #153317
Merged