Skip to content

Rollup of 6 pull requests - #153278

Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged

Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-k88jgqQ

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost

Create a similar rollup

bjorn3and others added 25 commits February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Mar 2, 2026
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbotrustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Mar 2, 2026
@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 80a9870 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
@JonathanBrouwer

JonathanBrouwer commented Mar 2, 2026

Copy link
Copy Markdown
MemberAuthor

Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)

@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2026
@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 54m 35s
Pushing 8ddf4ef to main...

@rust-bors
rust-borsBot merged commit 8ddf4ef into rust-lang:mainMar 2, 2026
13 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 2, 2026
@rust-timer

rust-timer commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)

previous master: 8d50bccc5b

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actionsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)

Test differences

Show 34 test diffs

Stage 1

  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)

Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
Merged
Closed
Merged
Merged
@rust-timer

rust-timer commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8ddf4ef): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -3.0%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅
(primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅
(secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2

Cycles

Results (secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)

@JonathanBrouwer
JonathanBrouwer deleted the rollup-k88jgqQ branch August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Rollup of 6 pull requests by JonathanBrouwer · Pull Request #153278 · rust-lang/rust · GitHub
Skip to content
Rollup of 6 pull requests - #153278
Merged
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Mar 2, 2026
Merged
Rollup of 6 pull requests#153278
rust-bors[bot] merged 25 commits into
rust-lang:mainfrom 
JonathanBrouwer:rollup-k88jgqQ
Conversation
@JonathanBrouwer
@JonathanBrouwerJonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
Create a similar rollup
bjorn3and others
added 25 commits
February 24, 2026 10:34
@bjorn3
Remove CodegenBackend supertrait of ExtraBackendMethods
811f708
@bjorn3
Merge typeid_metadata into type_checked_load
e33e562
This allows removing the Metadata associated type from BackendTypes.
@bjorn3
Reorder associated types in BackendTypes to be a bit more logical
e94aaf1
@bjorn3
Introduce FunctionSignature associated type for BackendTypes
f03581a
In Cranelift the regular Type enum can't represent function signatures.
Function pointers are represented as plain pointer sized integer.
@bjorn3
Merge const_data_from_alloc into static_addr_of
df4b228
In Cranelift a Value can't hold arbitrarily sized values.
@mati865
elf-raw-dylib: set type for functions
30fc9bd
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in
rust-lang#152451 (comment)
with changes from rust-lang#149937.
@DanielEScherzer
tests/ui/asm: add annotations for reference rules
7371a7f
@yuyahy
test: add regression test for fuzzy_provenance_casts lint ICE
6358dcc
@pitaj
stabilize new RangeToInclusive type
bc4cead
stabilizes `core::range::RangeToInclusive`
add missing trait impls for new RangeToInclusive
add missing trait impls for new RangeFrom
@nnethercote
Remove DepKindVTable::is_anon.
72a001b
It's unused.
@nnethercote
Inline and remove handle_cycle_error.
cc1b878
It has a single use.
@nnethercote
Make from_cycle_error consume the CycleError.
c0770ba
This makes it clear the `CycleError` is not used after the call.
@nnethercote
Avoid an early return in try_execute_query.
7a4daa4
When there are two cases of equal size and importance, I find an if/else
expression easier to read than an early return.
@nnethercote
Merge two assertion blocks in execute_job_non_incr.
fc395ed
It reads better that way.
@nnethercote
Remove three single-use type synonyms.
8129da8
It's an unnecessary level of indirection.
@nnethercote
Replace two abort_if_errors calls.
2aaced6
Calling `abort_if_errors` after emitting an error is guaranteed to call
`raise_fatal`, so just do that directly instead.
@nnethercote
Remove a duplicated comment.
6f111d2
This exact comment block also appears in
`compiler/rustc_middle/src/queries.rs`, which is a better place for it.
@nnethercote
Rename trait Value as FromCycleError.
5677f7c
`Value` is an unhelpfully generic name. Standard naming procedure for a
trait with a single method is for the trait name to match the method
name, which is what this commit does. Likewise, the enclosing module is
renamed from `values` to `from_cycle_error`.
Also add a comment about some non-obvious behaviour.
@nnethercote
Remove FromCycleError impl for SymbolName.
5bd28b8
It has no effect.
`symbol_name` is the only query that produces a `SymbolName`. If it was
marked with `cycle_delayed_bug`/`cycle_stash` then this `FromCycleError`
impl would make sense, but that's not the case. Maybe it was the case in
the past.
@JonathanBrouwer
Rollup merge ofrust-lang#153169- nnethercote:rm-is_anon-etc, r=petr…
af84b2a
…ochenkov
Various small query cleanups
I found these while doing a close read of the query code.
r? @oli-obk
@JonathanBrouwer
Rollup merge ofrust-lang#152304- pitaj:stabilize-new_range_api, r=t…
44c7081
…gross35
stabilize new RangeToInclusive type
stabilizes `core::range::RangeToInclusive`
```rust
// in core::range
pub struct RangeToInclusive<Idx> {
pub last: Idx,
}
impl<Idx: fmt::Debug> fmt::Debug for RangeInclusive<Idx> { /* ... */ }
impl<Idx: PartialOrd<Idx>> RangeToInclusive<Idx> {
pub const fn contains<U>(&self, item: &U) -> bool
where
Idx: [const] PartialOrd<U>,
U: ?Sized + [const] PartialOrd<Idx>;
}
impl<T> const RangeBounds<T> for RangeToInclusive<T> { /* ... */ }
impl<T> const RangeBounds<T> for RangeToInclusive<&T> { /* ... */ }
impl<T> const From<RangeToInclusive<T>> for legacy::RangeToInclusive<T> { /* ... */ }
impl<T> const From<legacy::RangeToInclusive<T>> for RangeToInclusive<T> { /* ... */ }
unsafe impl<T> const SliceIndex<[T]> for range::RangeToInclusive<usize> {
type Output = [T];
/* ... */
}
unsafe impl const SliceIndex<str> for range::RangeToInclusive<usize> {
type Output = str;
/* ... */
}
```
Tracking issue: rust-lang#125687
@JonathanBrouwer
Rollup merge ofrust-lang#153046- bjorn3:cg_ssa_cleanups, r=TaKO8Ki
ad4b2c0
Couple of cg_ssa refactorings
These should help a bit with using cg_ssa in cg_clif at some point in the future.
@JonathanBrouwer
Rollup merge ofrust-lang#153090- mati865:elf-raw-dylib-fns, r=TaKO8Ki
09b8f72
elf-raw-dylib: set type for functions
Avoids GNU ld warnings like:
```
type and size of dynamic symbol `meooooooooooooooow' are not defined
```
First noticed in rust-lang#152451 (comment) with changes from rust-lang#149937.
@JonathanBrouwer
Rollup merge ofrust-lang#153225- DanielEScherzer:test-references-as…
84f6387
…m, r=ehuss
tests/ui/asm: add annotations for reference rules
r? ehuss
Replaced rust-lang#152881 which got closed when the branch was renamed
@rustbot label +A-docs
@JonathanBrouwer
Rollup merge ofrust-lang#153233- yuyahy:ice-issue-137588-regression…
80a9870
…-test, r=nnethercote
test: add regression test for fuzzy_provenance_casts lint ICE
This PR adds a regression test for an ICE in `draw_code_line` that occurred when emitting a `fuzzy_provenance_casts` lint diagnostic for code with an inner attribute spanning the entire file, causing a panic on an empty `file_lines` from a dummy span.
The ICE no longer reproduces on the latest main. This PR only adds a regression test to prevent future regressions.
The test is based on the auto-reduced code from the issue.
rust-lang#137588
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 2, 2026
@rustbotrustbot
added

A-LLVM
Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.
A-query-system
Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbotrustbot
added
the 
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
label
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 80a9870 has been approved by JonathanBrouwer
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
@JonathanBrouwer
JonathanBrouwer
commented
Mar 2, 2026

Copy link


Copy Markdown

MemberAuthor
Trying commonly failed jobs
@bors try jobs=test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 2, 2026
@bors
Auto merge of#153278- JonathanBrouwer:rollup-k88jgqQ, r=<try>
e5a6556
Rollup of 6 pull requests
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: e5a6556 (e5a6556ac0daff5bf46ac9052cf1898302a3e41a, parent: ddd36bd57051f796850345b76c17e9402e28a9e4)
@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 2, 2026
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: JonathanBrouwer

Duration: 3h 54m 35s

Pushing 8ddf4ef to main...
@rust-bors
rust-borsBot
merged commit 8ddf4ef
into
rust-lang:mainMar 2, 2026

13 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 2, 2026
@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#152304stabilize new RangeToInclusive typed7c57d626a6f2c6e394c1b3c7917d473893171c8 (link)
#153046Couple of cg_ssa refactorings0544a81487284601d7b830513d70cebf2c0c21c5 (link)
#153090elf-raw-dylib: set type for functions82df08f80c07a6e5b989c78a717a1ec3847d034f (link)
#153169Various small query cleanupsef1fd9193d826d2a8f1b9d32a2248e6b8cbb250a (link)
#153225tests/ui/asm: add annotations for reference rules698d3f48c74fbffd7c84429d0c259dc812af054f (link)
#153233test: add regression test for fuzzy_provenance_casts lint I…b25c82c6a3b0cca94da388a92daf2c0d71ba9916 (link)
previous master: 8d50bccc5b
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8d50bcc (parent) -> 8ddf4ef (this PR)
Test differences
Show 34 test diffs

Stage 1
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/lint/ice-fuzzy-provenance-casts-with-inner-attr.rs: [missing] -> pass (J0)
Additionally, 32 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 8ddf4ef064fb702fed0f3d239ec8d0bac607484e --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. x86_64-rust-for-linux: 42m 43s -> 52m 30s (+22.9%)
  2. x86_64-gnu-gcc: 55m 20s -> 1h 7m (+21.8%)
  3. x86_64-gnu-llvm-20-2: 1h 26m -> 1h 43m (+19.2%)
  4. dist-aarch64-apple: 1h 51m -> 2h 10m (+17.0%)
  5. aarch64-gnu-llvm-20-1: 52m 58s -> 1h (+14.8%)
  6. pr-check-1: 27m 42s -> 31m 10s (+12.5%)
  7. armhf-gnu: 1h 23m -> 1h 32m (+11.2%)
  8. x86_64-msvc-ext1: 2h 2m -> 2h 16m (+11.0%)
  9. i686-gnu-2: 1h 30m -> 1h 40m (+10.8%)
  10. x86_64-gnu-miri: 1h 21m -> 1h 28m (+9.4%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.

This was referenced Mar 2, 2026
 Merged

 Closed

 Merged

 Merged

@rust-timer
rust-timer
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (8ddf4ef): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary -3.0%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		5.7%[5.7%, 5.7%]1
Improvements ✅ 
 (primary)		-3.0%[-3.1%, -2.9%]2
Improvements ✅ 
 (secondary)		-5.7%[-7.8%, -3.5%]2
All ❌✅ (primary)-3.0%[-3.1%, -2.9%]2
Cycles
Results (secondary 0.7%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.7%[3.7%, 3.7%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.2%[-2.2%, -2.2%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 479.657s -> 480.113s (0.10%)
Artifact size: 396.97 MiB -> 396.96 MiB (-0.00%)
@JonathanBrouwer
JonathanBrouwer
deleted the

rollup-k88jgqQ

branch
August 21, 2026 08:26
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-query-systemArea: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html)merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

9 participants

@JonathanBrouwer@rust-timer@rustbot@bjorn3@mati865@DanielEScherzer@yuyahy@pitaj@nnethercote