Skip to content

refactor: move check_align to parse_alignment - #153189

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JayanAXHF:refactor/check_attrs_reftor_1
Mar 6, 2026
Merged

refactor: move check_align to parse_alignment#153189
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
JayanAXHF:refactor/check_attrs_reftor_1

Conversation

@JayanAXHF

@JayanAXHFJayanAXHF commented Feb 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Part of #153101

r? @JonathanBrouwer

PS: jonathan i'm not sure about what to do with check_align now

@rustbot

rustbot commented Feb 27, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 27, 2026
@JayanAXHFJayanAXHF added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-AST Area: AST labels Feb 27, 2026
JonathanBrouwer
JonathanBrouwer requested changes Feb 27, 2026
View reviewed changes
Comment threadcompiler/rustc_attr_parsing/src/attributes/repr.rs Outdated
Comment threadcompiler/rustc_attr_parsing/src/attributes/repr.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/repr.rs Outdated
Comment threadcompiler/rustc_attr_parsing/src/attributes/repr.rs
Comment threadcompiler/rustc_attr_parsing/src/attributes/repr.rs Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Mar 1, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JayanAXHF

JayanAXHF commented Mar 1, 2026

Copy link
Copy Markdown
MemberAuthor

@JonathanBrouwer I think i've finally gotten everything in order :D

@JayanAXHF
JayanAXHFforce-pushed the refactor/check_attrs_reftor_1 branch from a1cb53e to a026d9dCompareMarch 1, 2026 14:53
@JonathanBrouwer

JonathanBrouwer commented Mar 1, 2026

Copy link
Copy Markdown
Member

I'll take a look sometime in the next few days :)

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 1, 2026
JonathanBrouwer
JonathanBrouwer requested changes Mar 2, 2026
View reviewed changes
Comment threadcompiler/rustc_attr_parsing/src/attributes/repr.rs Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
@JayanAXHFJayanAXHF changed the title refactor: add move check_align to parse_alignmentrefactor: move check_align to parse_alignmentMar 4, 2026
@JayanAXHF

JayanAXHF commented Mar 4, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer

JonathanBrouwer commented Mar 5, 2026

Copy link
Copy Markdown
Member

@rustbot author
ci is sad :c

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 5, 2026
@JayanAXHF
JayanAXHFforce-pushed the refactor/check_attrs_reftor_1 branch from 0b79ab0 to 6321e44CompareMarch 5, 2026 14:51
@JonathanBrouwer

JonathanBrouwer commented Mar 5, 2026

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

Sign in to view
@JayanAXHF
refactor: move check_align to parse_alignment
2093158
* refactor: move `check_align` from check_attrs.rs to `parse_alignment`
rel: attribute parser rework
* fix: fix error messages
* test: fix test
* fix: fix invalid error message
* ops(test): Fix CI
@rust-bors

rust-borsBot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

🔨 5 commits were squashed into 2093158.

@rust-bors
rust-borsBotforce-pushed the refactor/check_attrs_reftor_1 branch from 6321e44 to 2093158CompareMarch 5, 2026 18:46
@JonathanBrouwer

JonathanBrouwer commented Mar 5, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 2093158 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 5, 2026
Open
29 tasks
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 6, 2026
@jhpratt
Rollup merge ofrust-lang#153189- JayanAXHF:refactor/check_attrs_ref…
e27f876
…tor_1, r=JonathanBrouwer
refactor: move `check_align` to `parse_alignment`
Part of rust-lang#153101
r? @JonathanBrouwer
PS: jonathan i'm not sure about what to do with `check_align` now
@jhprattjhpratt mentioned this pull request Mar 6, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of#153467- jhpratt:rollup-uxqJkCS, r=jhpratt
882984e
Rollup of 7 pull requests
Successful merges:
- #153466 (`rust-analyzer` subtree update)
- #151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- #153189 (refactor: move `check_align` to `parse_alignment`)
- #153230 (Roll rustfmt reviewers for in-tree rustfmt)
- #153321 (Add high-priority ICEs to tests/crashes)
- #153445 (Consider try blocks as block-like for overflowed expr)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 6, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153189- JayanAXHF:refactor/check_attrs_ref…
7f9e761
…tor_1, r=JonathanBrouwer
refactor: move `check_align` to `parse_alignment`
Part of rust-lang#153101
r? @JonathanBrouwer
PS: jonathan i'm not sure about what to do with `check_align` now
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 6, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of#153490- JonathanBrouwer:rollup-2qfRVzJ, r=JonathanBro…
a3bc38c
…uwer
Rollup of 9 pull requests
Successful merges:
- #153466 (`rust-analyzer` subtree update)
- #151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- #153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
- #153189 (refactor: move `check_align` to `parse_alignment`)
- #153230 (Roll rustfmt reviewers for in-tree rustfmt)
- #153445 (Consider try blocks as block-like for overflowed expr)
- #153476 (bootstrap.py: fix typo "parallle")
- #153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 6, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153189- JayanAXHF:refactor/check_attrs_ref…
fb6afe7
…tor_1, r=JonathanBrouwer
refactor: move `check_align` to `parse_alignment`
Part of rust-lang#153101
r? @JonathanBrouwer
PS: jonathan i'm not sure about what to do with `check_align` now
This was referenced Mar 6, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 6, 2026
@bors
Auto merge of#153507- JonathanBrouwer:rollup-ki59UTE, r=JonathanBro…
80282b1
…uwer
Rollup of 14 pull requests
Successful merges:
- #153466 (`rust-analyzer` subtree update)
- #151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- #153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
- #153485 (libcore float tests: replace macro shadowing by const-compatible macro)
- #153495 (Fix ICE in `offset_of!` error recovery)
- #152040 (Do not emit ConstEvaluatable goals if type-const)
- #152741 (Suppress invalid suggestions in destructuring assignment)
- #153189 (refactor: move `check_align` to `parse_alignment`)
- #153230 (Roll rustfmt reviewers for in-tree rustfmt)
- #153445 (Consider try blocks as block-like for overflowed expr)
- #153452 (Cleanup unused diagnostic emission methods)
- #153476 (bootstrap.py: fix typo "parallle")
- #153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
@rust-bors
rust-borsBot merged commit 56c8de6 into rust-lang:mainMar 6, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 6, 2026
rust-timer added a commit that referenced this pull request Mar 6, 2026
@rust-timer
Unrolled build for#153189
d3219ef
Rollup merge of #153189 - JayanAXHF:refactor/check_attrs_reftor_1, r=JonathanBrouwer
refactor: move `check_align` to `parse_alignment`
Part of #153101
r? @JonathanBrouwer
PS: jonathan i'm not sure about what to do with `check_align` now
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Mar 9, 2026
@bors
Auto merge of #153507 - JonathanBrouwer:rollup-ki59UTE, r=JonathanBro…
112f2f5
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153466 (`rust-analyzer` subtree update)
- rust-lang/rust#151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- rust-lang/rust#152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- rust-lang/rust#153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
- rust-lang/rust#153485 (libcore float tests: replace macro shadowing by const-compatible macro)
- rust-lang/rust#153495 (Fix ICE in `offset_of!` error recovery)
- rust-lang/rust#152040 (Do not emit ConstEvaluatable goals if type-const)
- rust-lang/rust#152741 (Suppress invalid suggestions in destructuring assignment)
- rust-lang/rust#153189 (refactor: move `check_align` to `parse_alignment`)
- rust-lang/rust#153230 (Roll rustfmt reviewers for in-tree rustfmt)
- rust-lang/rust#153445 (Consider try blocks as block-like for overflowed expr)
- rust-lang/rust#153452 (Cleanup unused diagnostic emission methods)
- rust-lang/rust#153476 (bootstrap.py: fix typo "parallle")
- rust-lang/rust#153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Mar 21, 2026
@bors
Auto merge of #153507 - JonathanBrouwer:rollup-ki59UTE, r=JonathanBro…
1fc8c3b
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153466 (`rust-analyzer` subtree update)
- rust-lang/rust#151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- rust-lang/rust#152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- rust-lang/rust#153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
- rust-lang/rust#153485 (libcore float tests: replace macro shadowing by const-compatible macro)
- rust-lang/rust#153495 (Fix ICE in `offset_of!` error recovery)
- rust-lang/rust#152040 (Do not emit ConstEvaluatable goals if type-const)
- rust-lang/rust#152741 (Suppress invalid suggestions in destructuring assignment)
- rust-lang/rust#153189 (refactor: move `check_align` to `parse_alignment`)
- rust-lang/rust#153230 (Roll rustfmt reviewers for in-tree rustfmt)
- rust-lang/rust#153445 (Consider try blocks as block-like for overflowed expr)
- rust-lang/rust#153452 (Cleanup unused diagnostic emission methods)
- rust-lang/rust#153476 (bootstrap.py: fix typo "parallle")
- rust-lang/rust#153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
ghaaj pushed a commit to ghaaj/polygrammar that referenced this pull request Aug 7, 2026
@bors
Auto merge of #153507 - JonathanBrouwer:rollup-ki59UTE, r=JonathanBro…
289f7a1
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153466 (`rust-analyzer` subtree update)
- rust-lang/rust#151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- rust-lang/rust#152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- rust-lang/rust#153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
- rust-lang/rust#153485 (libcore float tests: replace macro shadowing by const-compatible macro)
- rust-lang/rust#153495 (Fix ICE in `offset_of!` error recovery)
- rust-lang/rust#152040 (Do not emit ConstEvaluatable goals if type-const)
- rust-lang/rust#152741 (Suppress invalid suggestions in destructuring assignment)
- rust-lang/rust#153189 (refactor: move `check_align` to `parse_alignment`)
- rust-lang/rust#153230 (Roll rustfmt reviewers for in-tree rustfmt)
- rust-lang/rust#153445 (Consider try blocks as block-like for overflowed expr)
- rust-lang/rust#153452 (Cleanup unused diagnostic emission methods)
- rust-lang/rust#153476 (bootstrap.py: fix typo "parallle")
- rust-lang/rust#153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #153507 - JonathanBrouwer:rollup-ki59UTE, r=JonathanBro…
a691a8a
…uwer
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#153466 (`rust-analyzer` subtree update)
- rust-lang/rust#151280 (Fix incorrect trailing comma suggested in no_accessible_fields)
- rust-lang/rust#152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`)
- rust-lang/rust#153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards)
- rust-lang/rust#153485 (libcore float tests: replace macro shadowing by const-compatible macro)
- rust-lang/rust#153495 (Fix ICE in `offset_of!` error recovery)
- rust-lang/rust#152040 (Do not emit ConstEvaluatable goals if type-const)
- rust-lang/rust#152741 (Suppress invalid suggestions in destructuring assignment)
- rust-lang/rust#153189 (refactor: move `check_align` to `parse_alignment`)
- rust-lang/rust#153230 (Roll rustfmt reviewers for in-tree rustfmt)
- rust-lang/rust#153445 (Consider try blocks as block-like for overflowed expr)
- rust-lang/rust#153452 (Cleanup unused diagnostic emission methods)
- rust-lang/rust#153476 (bootstrap.py: fix typo "parallle")
- rust-lang/rust#153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwerJonathanBrouwerAwaiting requested review from JonathanBrouwer

Assignees

@JonathanBrouwerJonathanBrouwer

Labels

A-ASTArea: ASTA-attributesArea: Attributes (`#[…]`, `#![…]`)C-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JayanAXHF@rustbot@rust-log-analyzer@JonathanBrouwer