Cleanup unused diagnostic emission methods by GuillaumeGomez · Pull Request #153452 · rust-lang/rust

GuillaumeGomez · 2026-03-05T17:36:07Z

To remove lint_level, we need to remove all functions calling it. One of them is TyCtxt::node_span_lint, so removing it.

r? @JonathanBrouwer

rustbot · 2026-03-05T17:36:17Z

HIR ty lowering was modified

cc @fmease

rustbot · 2026-03-05T17:36:20Z

JonathanBrouwer is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2026-03-05T22:54:02Z

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

GuillaumeGomez · 2026-03-05T22:56:11Z

PR is not ready, we need to figure out why the tracking is currently broken in clippy:

--- tests/ui/track-diagnostics-clippy.stderr
+++ <stderr output>
error: casting to the same type is unnecessary (`u32` -> `u32`)
--> tests/ui/track-diagnostics-clippy.rs:LL:CC
... 2 lines skipped ...
| ^^^^^^^^ help: try: `a`
|
- = note: -Ztrack-diagnostics: created at clippy_lints/src/casts/unnecessary_cast.rs:LL:CC
+ = note: -Ztrack-diagnostics: created at compiler/rustc_middle/src/lint.rs:LL:CC
= note: `-D clippy::unnecessary-cast` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unnecessary_cast)]`
... 18 lines skipped ...
error: aborting due to 2 previous errors

You can run this (specific) test with:

TESTNAME=track-diagnostics-clippy ./x.py test src/tools/clippy/ --stage 1

JonathanBrouwer · 2026-03-06T14:16:37Z

r=me if ci green & you agree with my commit

GuillaumeGomez · 2026-03-06T17:46:59Z

@bors r=JonathanBrouwer rollup

rust-bors · 2026-03-06T17:47:03Z

📌 Commit e01a7e7 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 14 pull requests Successful merges: - #153466 (`rust-analyzer` subtree update) - #151280 (Fix incorrect trailing comma suggested in no_accessible_fields) - #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`) - #153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards) - #153485 (libcore float tests: replace macro shadowing by const-compatible macro) - #153495 (Fix ICE in `offset_of!` error recovery) - #152040 (Do not emit ConstEvaluatable goals if type-const) - #152741 (Suppress invalid suggestions in destructuring assignment) - #153189 (refactor: move `check_align` to `parse_alignment`) - #153230 (Roll rustfmt reviewers for in-tree rustfmt) - #153445 (Consider try blocks as block-like for overflowed expr) - #153452 (Cleanup unused diagnostic emission methods) - #153476 (bootstrap.py: fix typo "parallle") - #153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)

@JonathanBrouwer

Rollup merge of #153452 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer Cleanup unused diagnostic emission methods Part of #153099. To remove `lint_level`, we need to remove all functions calling it. One of them is `TyCtxt::node_span_lint`, so removing it. r? @JonathanBrouwer

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#153466 (`rust-analyzer` subtree update) - rust-lang/rust#151280 (Fix incorrect trailing comma suggested in no_accessible_fields) - rust-lang/rust#152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`) - rust-lang/rust#153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards) - rust-lang/rust#153485 (libcore float tests: replace macro shadowing by const-compatible macro) - rust-lang/rust#153495 (Fix ICE in `offset_of!` error recovery) - rust-lang/rust#152040 (Do not emit ConstEvaluatable goals if type-const) - rust-lang/rust#152741 (Suppress invalid suggestions in destructuring assignment) - rust-lang/rust#153189 (refactor: move `check_align` to `parse_alignment`) - rust-lang/rust#153230 (Roll rustfmt reviewers for in-tree rustfmt) - rust-lang/rust#153445 (Consider try blocks as block-like for overflowed expr) - rust-lang/rust#153452 (Cleanup unused diagnostic emission methods) - rust-lang/rust#153476 (bootstrap.py: fix typo "parallle") - rust-lang/rust#153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)

…rcote HIR ty lowering: Move some things into submodules By commit: 1. Move `compute_object_lifetime_bound` into submodule `dyn_trait` since it's only used there unsurprisingly 2. Move a `impl Diagnostic for AmbiguousAssocItem` into submodule `errors` and rename the diagnostic struct * For what it represents, it was way too prominent right at the start of `lower_type_relative_path` which didn't use to be the case prior to PR rust-lang#153452 3. Move a distractingly lengthy "error builder" into a new fn `report_ambiguous_assoc_item` in submodule `errors` * Since we unconditionally `return Err(_)` after calling this new function, we fix a debug assertion (see commit message & description of added UI test for details) Fixesrust-lang#139387

Rollup merge of #157027 - fmease:hirtylo-mv-things, r=nnethercote HIR ty lowering: Move some things into submodules By commit: 1. Move `compute_object_lifetime_bound` into submodule `dyn_trait` since it's only used there unsurprisingly 2. Move a `impl Diagnostic for AmbiguousAssocItem` into submodule `errors` and rename the diagnostic struct * For what it represents, it was way too prominent right at the start of `lower_type_relative_path` which didn't use to be the case prior to PR #153452 3. Move a distractingly lengthy "error builder" into a new fn `report_ambiguous_assoc_item` in submodule `errors` * Since we unconditionally `return Err(_)` after calling this new function, we fix a debug assertion (see commit message & description of added UI test for details) Fixes#139387

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#153466 (`rust-analyzer` subtree update) - rust-lang/rust#151280 (Fix incorrect trailing comma suggested in no_accessible_fields) - rust-lang/rust#152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`) - rust-lang/rust#153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards) - rust-lang/rust#153485 (libcore float tests: replace macro shadowing by const-compatible macro) - rust-lang/rust#153495 (Fix ICE in `offset_of!` error recovery) - rust-lang/rust#152040 (Do not emit ConstEvaluatable goals if type-const) - rust-lang/rust#152741 (Suppress invalid suggestions in destructuring assignment) - rust-lang/rust#153189 (refactor: move `check_align` to `parse_alignment`) - rust-lang/rust#153230 (Roll rustfmt reviewers for in-tree rustfmt) - rust-lang/rust#153445 (Consider try blocks as block-like for overflowed expr) - rust-lang/rust#153452 (Cleanup unused diagnostic emission methods) - rust-lang/rust#153476 (bootstrap.py: fix typo "parallle") - rust-lang/rust#153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)

GuillaumeGomez added 2 commits March 5, 2026 11:46

Remove unused LintContext::lint method
96f2261

Create new Diagnostic type for panic calls without literals
25c7798

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2026

rustbot assigned JonathanBrouwer Mar 5, 2026

This comment has been minimized.
Sign in to view

JonathanBrouwer requested changes Mar 5, 2026
View reviewed changes

Comment threadcompiler/rustc_hir_analysis/src/hir_ty_lowering/generics.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2026

GuillaumeGomez force-pushed the migrate-diag branch from 9182eab to 9dfb21cCompare March 5, 2026 19:50

This comment has been minimized.
Sign in to view

GuillaumeGomez added 7 commits March 5, 2026 23:53

Remove usage of LintContext::span_lint in clippy
9dc456a

Remove unused LintContext::span_lint method
1f62cd2

Remove unused LintContext::opt_span_lint method
a0b24e3

Remove last use of rustc_middle::lint_level function in rustc_lint
6e47be7

Remove TyCtxt::node_span_lint usage from rustc_codegen_ssa
140ad03

Remove TyCtxt::node_span_lint usage from rustc_hir_analysis
e1ee669

Remove TyCtxt::node_span_lint usage from rustc_hir_typeck
c98094b

GuillaumeGomez force-pushed the migrate-diag branch from 9dfb21c to c98094bCompare March 5, 2026 22:53

rustbot added the T-clippy Relevant to the Clippy team. label Mar 5, 2026

This comment has been minimized.
Sign in to view

JonathanBrouwer force-pushed the migrate-diag branch from 6ab577a to 6c0ae27Compare March 6, 2026 14:11

Preserve the DiagLocation in diag_lint_level
8d96e60

JonathanBrouwer force-pushed the migrate-diag branch from 6c0ae27 to 8d96e60Compare March 6, 2026 14:16

This comment has been minimized.
Sign in to view

Fix panic by setting the span before it is actually needed
e01a7e7

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2026

JonathanBrouwer mentioned this pull request Mar 6, 2026
Rollup of 14 pull requests #153507
Merged

GuillaumeGomez mentioned this pull request Mar 6, 2026
Tracking Issue for LintDiagnostic migration #153099
Open
3 tasks

rust-borsBot merged commit 69dc318 into rust-lang:mainMar 6, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 6, 2026

GuillaumeGomez deleted the migrate-diag branch March 7, 2026 10:11

fmease mentioned this pull request May 28, 2026
HIR ty lowering: Move some things into submodules #157027
Merged

Navigation Menu

Uh oh!

Uh oh!

Cleanup unused diagnostic emission methods - #153452

Cleanup unused diagnostic emission methods#153452
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
GuillaumeGomez:migrate-diag

GuillaumeGomez commented Mar 5, 2026

Uh oh!

rustbot commented Mar 5, 2026

Uh oh!

rustbot commented Mar 5, 2026

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

rustbot commented Mar 5, 2026

Uh oh!

GuillaumeGomez commented Mar 5, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 6, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Mar 6, 2026

Uh oh!

rust-borsBot commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

GuillaumeGomez commented Mar 5, 2026

Uh oh!

rustbot commented Mar 5, 2026

Uh oh!

rustbot commented Mar 5, 2026

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

rustbot commented Mar 5, 2026

Uh oh!

GuillaumeGomez commented Mar 5, 2026

Uh oh!

This comment has been minimized.

JonathanBrouwer commented Mar 6, 2026

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Mar 6, 2026

Uh oh!

rust-borsBot commented Mar 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants