Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
asder8215:intersperse_changes
Mar 3, 2026
Merged

Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
asder8215:intersperse_changes

Conversation

@asder8215

@asder8215asder8215 commented Mar 2, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbot

rustbot commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@asder8215
asder8215force-pushed the intersperse_changes branch from 3652817 to 5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt reviewed Mar 2, 2026
View reviewed changes

@jhprattjhpratt left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.

View changes since this review

Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs Outdated
@asder8215

asder8215 commented Mar 2, 2026

Copy link
Copy Markdown
ContributorAuthor

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.

I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).

I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.

@asder8215
asder8215force-pushed the intersperse_changes branch 2 times, most recently from a4fed7f to 612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed the intersperse_changes branch from 612930d to c8d343eCompareMarch 3, 2026 00:45
@asder8215

asder8215 commented Mar 3, 2026

Copy link
Copy Markdown
ContributorAuthor

I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.

If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.

This PR should still pass the tests as per the previous comment.

@asder8215
asder8215 requested a review from jhprattMarch 3, 2026 00:54
@jhpratt

jhpratt commented Mar 3, 2026

Copy link
Copy Markdown
Member

My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂

@bors r+

@rust-bors

rust-borsBot commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c8d343e has been approved by jhpratt

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026
@asder8215

asder8215 commented Mar 3, 2026

Copy link
Copy Markdown
ContributorAuthor

It's all good, mistakes happen 👍

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
This was referenced Mar 3, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot merged commit c438462 into rust-lang:mainMar 3, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 3, 2026
rust-timer added a commit that referenced this pull request Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215 mentioned this pull request Mar 10, 2026
Closed
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with - #153265
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Mar 3, 2026
Merged
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
asder8215:intersperse_changes
Conversation
@asder8215
@asder8215asder8215
commented
Mar 2, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Contributor
This PR builds on top of #152855. I just added clarifying comments to intersperse/intersperse_with about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for intersperse/intersperse_with.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
r? @jhpratt
rustbot has assigned @jhpratt.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
Why was this reviewer chosen?
The reviewer was selected based on:
  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
3652817 to
5d65c39CompareMarch 2, 2026 02:13
jhpratt
jhpratt
reviewed
Mar 2, 2026
View reviewed changes
@jhprattjhpratt
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
View changes since this review
Comment threadlibrary/coretests/tests/iter/adapters/intersperse.rs
Outdated

@asder8215
asder8215
commented
Mar 2, 2026

Copy link


Copy Markdown

ContributorAuthor
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of intersperse currently (since interspersetransforms the iter into a fused iterator); what it does do is prevent us from entering the self.started branch if we see a None element as the first one in the iterator (maybe saving instructions for further .next() call after the first time seeing None? I don't know why one would do that, but it's possible).
I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch.
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
2 times, most recently
from
a4fed7f to
612930dCompareMarch 2, 2026 23:54
@asder8215
Added guarantee and non-guarantee comments + tests for intersperse/in…
c8d343e
…tersperse_with regarding fused/non-fused iterators
@asder8215
asder8215force-pushed
the
intersperse_changes
branch
from
612930d to
c8d343eCompareMarch 3, 2026 00:45
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork defused-intersperse branch. I don't know if the suggestion feature allows you to suggest changes on a whole separate file (and create new file) that the PR doesn't pertain to.
If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route.
This PR should still pass the tests as per the previous comment.
@asder8215
asder8215
requested a review
from jhprattMarch 3, 2026 00:54
@jhpratt
jhpratt
commented
Mar 3, 2026

Copy link


Copy Markdown

Member
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂
@bors r+
@rust-bors
rust-borsBot
commented
Mar 3, 2026

Copy link


Copy Markdown

Contributor
📌 Commit c8d343e has been approved by jhpratt
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 3, 2026
@asder8215
asder8215
commented
Mar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
It's all good, mistakes happen 👍
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153265- asder8215:intersperse_changes, r=j…
be7f4cc
…hpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit c438462
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153265
2794733
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt
Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with
This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
@asder8215asder8215
mentioned this pull request
Mar 10, 2026
 Closed

flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jhprattjhprattAwaiting requested review from jhpratt

Assignees

@jhprattjhpratt

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asder8215@rustbot@jhpratt