feat: Provide an '.item_kind()' method on ItemEnum - #153279

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged

feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
LukeMathWalker:add-kind-method

Conversation

@LukeMathWalker

@LukeMathWalkerLukeMathWalker commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.

r? @aDotInTheVoid

@rustbot

rustbot commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.

cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi

@rustbotrustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 2, 2026
@rustbot

rustbot commented Mar 2, 2026

Copy link
Copy Markdown
Collaborator

aDotInTheVoid is currently at their maximum review capacity.
They may take a while to respond.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid approved these changes Mar 2, 2026
View reviewed changes

@aDotInTheVoidaDotInTheVoid left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.

View changes since this review

Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
/// Returns the [`ItemKind`] of this item.

@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.

@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅

Comment threadsrc/rustdoc-json-types/lib.rs
ItemEnum::Static(_) => ItemKind::Static,
ItemEnum::ExternType => ItemKind::ExternType,
ItemEnum::Macro(_) => ItemKind::Macro,
ItemEnum::ProcMacro(pm) => match pm.kind {

@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)

@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.

@aDotInTheVoid

aDotInTheVoid commented Mar 2, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 931e2c4 has been approved by aDotInTheVoid

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
This was referenced Mar 3, 2026
Closed
Merged
rust-borsBot pushed a commit that referenced this pull request Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot merged commit 3bb5245 into rust-lang:mainMar 3, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 3, 2026
rust-timer added a commit that referenced this pull request Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid

aDotInTheVoid commented Mar 4, 2026

Copy link
Copy Markdown
Member

Published in v0.57.1

rust-cloud-vmsBot pushed a commit to aDotInTheVoid/rust that referenced this pull request Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot pushed a commit to aDotInTheVoid/rust that referenced this pull request Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid mentioned this pull request Mar 9, 2026
Merged
rust-cloud-vmsBot pushed a commit to aDotInTheVoid/rust that referenced this pull request Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit that referenced this pull request Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
feat: Provide an '.item_kind()' method on ItemEnum - #153279
Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Mar 3, 2026
Merged
feat: Provide an '.item_kind()' method on ItemEnum#153279
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom 
LukeMathWalker:add-kind-method
Conversation
@LukeMathWalker
@LukeMathWalkerLukeMathWalker
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on rustdoc-json-types.
r? @aDotInTheVoid
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
rustdoc-json-types is a public (although nightly-only) API. If possible, consider changing src/librustdoc/json/conversions.rs; otherwise, make sure you bump the FORMAT_VERSION constant.
cc @CraftSpider, @aDotInTheVoid, @Enselic, @obi1kenobi
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 2, 2026
@rustbot
rustbot
commented
Mar 2, 2026

Copy link


Copy Markdown

Collaborator
aDotInTheVoid is currently at their maximum review capacity.

They may take a while to respond.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
aDotInTheVoid
aDotInTheVoid
approved these changes
Mar 2, 2026
View reviewed changes
@aDotInTheVoidaDotInTheVoid
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API makes sense. We do something like this in https://github.com/rust-lang/rust/blob/ec818fda361ca216eb186f5cf45131bd9c776bb4/src/tools/jsondoclint/src/item_kind.rs, which could probably be eliminated after this lands.
View changes since this review
Comment threadsrc/rustdoc-json-types/lib.rs
}

impl ItemEnum {
 /// Returns the [`ItemKind`] of this item.
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This doc comment doesn't say anything that isn't in the function signature. Maybe add a sentance or an example about why you'd want to do this.
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one of those methods where it's difficult to be insightful in doc comments 😅
Comment threadsrc/rustdoc-json-types/lib.rs
 ItemEnum::Static(_) => ItemKind::Static,
 ItemEnum::ExternType => ItemKind::ExternType,
 ItemEnum::Macro(_) => ItemKind::Macro,
 ItemEnum::ProcMacro(pm) => match pm.kind {
@aDotInTheVoidaDotInTheVoidMar 2, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, maybe we should merge these in ItemKind, or split them in ItemEnum. (But not in this PR)
@LukeMathWalkerLukeMathWalkerMar 3, 2026

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it does violate the overall ItemEnum variant <> ItemKind variant symmetry a bit.
@aDotInTheVoid
aDotInTheVoid
commented
Mar 2, 2026

Copy link


Copy Markdown

Member
@bors r+ rollup
@rust-bors
rust-borsBot
commented
Mar 2, 2026

Copy link


Copy Markdown

Contributor
📌 Commit 931e2c4 has been approved by aDotInTheVoid
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 2, 2026
JonathanBrouwer added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Mar 3, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#153279- LukeMathWalker:add-kind-method, r=…
a85fa2a
…aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid

This was referenced Mar 3, 2026
 Closed

 Merged

rust-borsBot
pushed a commit
that referenced
this pull request
Mar 3, 2026
@bors
Auto merge of#153331- JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
1b7d722
…uwer
Rollup of 12 pull requests
Successful merges:
- #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- #153227 (Don’t report missing fields in struct exprs with syntax errors.)
- #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- #152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- #153034 (Remove unhelpful hint from trivial bound errors)
- #153152 (Migration of LintDiagnostic - part 5)
- #153177 (disable the ptr_fragment_in_final test on s390x)
- #153221 (Add release notes for 1.94.0)
- #153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- #153297 (Update the name of the Hermit operating system)
- #153309 (Cleanup of c-variadic link test)
@rust-bors
rust-borsBot
merged commit 3bb5245
into
rust-lang:mainMar 3, 2026

11 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 3, 2026
rust-timer added a commit
that referenced
this pull request
Mar 3, 2026
@rust-timer
Unrolled build for#153279
7695ee8
Rollup merge of #153279 - LukeMathWalker:add-kind-method, r=aDotInTheVoid
feat: Provide an '.item_kind()' method on ItemEnum
A little helper method which I found myself adding over and over again in all the projects I maintain which depend on `rustdoc-json-types`.
r? @aDotInTheVoid
@aDotInTheVoid
aDotInTheVoid
commented
Mar 4, 2026

Copy link


Copy Markdown

Member
Published in v0.57.1
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
e966219
Fixesrust-lang#153279 (comment)
rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
567e064
Fixesrust-lang#153279 (comment)
@aDotInTheVoidaDotInTheVoid
mentioned this pull request
Mar 9, 2026
 Merged

rust-cloud-vmsBot
pushed a commit
to aDotInTheVoid/rust
that referenced
this pull request
Mar 9, 2026
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 10, 2026
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153627- aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
ee703ce
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez CC @LukeMathWalker
rust-timer added a commit
that referenced
this pull request
Mar 10, 2026
@rust-timer
Unrolled build for#153627
8dfbefe
Rollup merge of #153627 - aDotInTheVoid:rustdocsdocs, r=GuillaumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixes#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
flip1995 pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
Aug 17, 2026
@bors
Auto merge of #153331 - JonathanBrouwer:rollup-hr9XbEa, r=JonathanBro…
b976bd2
…uwer
Rollup of 12 pull requests
Successful merges:
- rust-lang/rust#152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions)
- rust-lang/rust#153227 (Don’t report missing fields in struct exprs with syntax errors.)
- rust-lang/rust#153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with)
- rust-lang/rust#152966 (Migrate 11 tests from tests/ui/issues to specific directories)
- rust-lang/rust#153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc)
- rust-lang/rust#153034 (Remove unhelpful hint from trivial bound errors)
- rust-lang/rust#153152 (Migration of LintDiagnostic - part 5)
- rust-lang/rust#153177 (disable the ptr_fragment_in_final test on s390x)
- rust-lang/rust#153221 (Add release notes for 1.94.0)
- rust-lang/rust#153279 (feat: Provide an '.item_kind()' method on ItemEnum)
- rust-lang/rust#153297 (Update the name of the Hermit operating system)
- rust-lang/rust#153309 (Cleanup of c-variadic link test)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@aDotInTheVoidaDotInTheVoidaDotInTheVoid approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@aDotInTheVoidaDotInTheVoid

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

4 participants

@LukeMathWalker@rustbot@rust-log-analyzer@aDotInTheVoid