Rollup of 4 pull requests - #153642

Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged

Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom
matthiaskrgr:rollup-IHw8KqK

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Mar 10, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Successful merges:

r? @ghost

Create a similar rollup

kpreidand others added 11 commits November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot added the rollup A PR which is a rollup label Mar 10, 2026
@rustbotrustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Mar 10, 2026
@matthiaskrgr

matthiaskrgr commented Mar 10, 2026

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@rust-bors

rust-borsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b01e56d has been approved by matthiaskrgr

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026
@rust-bors

rust-borsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 2254b92 failed: CI. Failed job:

@rust-log-analyzer

rust-log-analyzer commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar

Zalathar commented Mar 10, 2026

Copy link
Copy Markdown
Member

Looks like we're seeing a streak of network failures.

@bors treeclosed=1000

@rust-bors

rust-borsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Tree closed for PRs with priority less than 1000.

@JonathanBrouwer

JonathanBrouwer commented Mar 10, 2026

Copy link
Copy Markdown
Member

@bors p=1000

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot pushed a commit that referenced this pull request Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026
@rust-bors

rust-borsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 5c216d1 failed: CI. Failed job:

@JonathanBrouwer

JonathanBrouwer commented Mar 10, 2026

Copy link
Copy Markdown
Member

@bors retry

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot mentioned this pull request Mar 10, 2026
Merged
@rust-log-analyzer

rust-log-analyzer commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

This was referenced Mar 10, 2026
Merged
Closed
Merged
@jyn514

jyn514 commented Mar 10, 2026

Copy link
Copy Markdown
Member

i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
Merged
Merged
Merged
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 10, 2026
@rust-bors

rust-borsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: matthiaskrgr
Duration: 3h 18m 46s
Pushing 0c68443 to main...

@rust-bors
rust-borsBot merged commit 0c68443 into rust-lang:mainMar 10, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 10, 2026
@rust-timer

rust-timer commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)

previous master: 3bc6ea5673

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actionsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)

Test differences

Show 244 test diffs

Stage 1

  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)

Stage 2

  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)

Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-borsrust-borsBot mentioned this pull request Mar 10, 2026
Closed
@JonathanBrouwer

JonathanBrouwer commented Mar 10, 2026

Copy link
Copy Markdown
Member

@bors treeopen

@rust-bors

rust-borsBot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Tree is now open for merging.

@rust-timer

rust-timer commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0c68443): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅
(secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 5.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		5.0%[5.0%, 5.0%]1
Regressions ❌
(secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1

Binary size

Results (primary 1.4%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		1.4%[1.4%, 1.4%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1

Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rollup of 4 pull requests - #153642
Merged
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Mar 10, 2026
Merged
Rollup of 4 pull requests#153642
rust-bors[bot] merged 11 commits into
rust-lang:mainfrom 
matthiaskrgr:rollup-IHw8KqK
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Mar 10, 2026•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
View all comments
Successful merges:
r? @ghost
Create a similar rollup
kpreidand others
added 11 commits
November 23, 2025 15:00
@kpreid
In Option::get_or_insert_with(), forget the None instead of dropp…
c1b51dd
…ing it.
This allows eliminating the `T: [const] Destruct` bounds and avoids
generating an implicit `drop_in_place::<Option<T>>()` that will never do
anything.
Ideally, the compiler would prove that that drop is not necessary
itself, but it currently doesn't, even with `const_precise_live_drops`
enabled.
@DanielEScherzer
tests/ui/cfg: add annotations for reference rules
226b4dd
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in librustdoc
4c48a5b
@aDotInTheVoid
rustdoc-json: Improve docs for ItemEnum::item_kind
ca9bd0d
Fixesrust-lang#153279 (comment)
@GuillaumeGomez
Remove usage of TyCtxt::node_span_lint in clippy
e54a3d3
@GuillaumeGomez
Remove TyCtxt::node_span_lint method
562e981
@GuillaumeGomez
Remove TyCtxt::node_span_lint mention in docs
4d7624e
@matthiaskrgr
Rollup merge ofrust-lang#148562- kpreid:get-init-drop, r=oli-obk
ce97229
In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.
Per rust-lang#148486 (comment)
In `Option::get_or_insert_with()`, after replacing the `None` with `Some`, forget the `None` instead of dropping it.
This allows eliminating the `T: [const] Destruct` bounds, making the functions more flexible in (unstable) const contexts, and avoids generating an implicit `drop_in_place::<Option<T>>()` that will never do anything (and which might even persist after optimization).
@matthiaskrgr
Rollup merge ofrust-lang#153325- DanielEScherzer:test-references-co…
4e0adfe
…nditional-compilation, r=ehuss
tests/ui/cfg: add annotations for reference rules
@matthiaskrgr
Rollup merge ofrust-lang#153621- GuillaumeGomez:migrate-diag, r=Jon…
531dafd
…athanBrouwer
Remove `TyCtxt::node_span_lint` method
Part of rust-lang#153099.
One less obstacle before we can remove `lint_level` function. :)
r? @JonathanBrouwer
@matthiaskrgr
Rollup merge ofrust-lang#153627- aDotInTheVoid:rustdocsdocs, r=Guil…
b01e56d
…laumeGomez
rustdoc-json: Improve docs for `ItemEnum::item_kind`
Fixesrust-lang#153279 (comment)
r? @GuillaumeGomez
CC @LukeMathWalker
@rust-borsrust-borsBot
added
the 
rollup
A PR which is a rollup
label
Mar 10, 2026
@rustbotrustbot
added

A-rustdoc-json
Area: Rustdoc JSON backend
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-clippy
Relevant to the Clippy team.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
labels
Mar 10, 2026
@matthiaskrgr
matthiaskrgr
commented
Mar 10, 2026

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
📌 Commit b01e56d has been approved by matthiaskrgr
It is now in the queue for this repository.
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
2254b92
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 2254b92 failed: CI. Failed job:
@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95007120KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
##[endgroup]
Image input checksum 72ecab2d23f2d77608df76481a5ada15b19d498a7dc3d48372c9a7a712b5b5ebbf396a23a20676c985663ba6d58ad0821d6c2d4213f3296bb226507df1b7fa67
##[group]Building docker image for x86_64-gnu-miri
Docker version 28.0.4, build b8034c0
Error response from daemon: Get "https://ghcr.io/v2/": Get "https://ghcr.io/token?account=rust-lang&client_id=docker&offline_token=true&service=ghcr.io": net/http: request canceled (Client.Timeout exceeded while awaiting headers) (Client.Timeout exceeded while awaiting headers)
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@Zalathar
Zalathar
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
Looks like we're seeing a streak of network failures.
@bors treeclosed=1000
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree closed for PRs with priority less than 1000.
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors p=1000
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 10, 2026
@bors
Auto merge of#153642- matthiaskrgr:rollup-IHw8KqK, r=matthiaskrgr
5c216d1
Rollup of 4 pull requests
Successful merges:
- #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
- #153325 (tests/ui/cfg: add annotations for reference rules)
- #153621 (Remove `TyCtxt::node_span_lint` method)
- #153627 (rustdoc-json: Improve docs for `ItemEnum::item_kind`)
@rust-borsrust-borsBot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
💔 Test for 5c216d1 failed: CI. Failed job:
@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors retry
@rust-borsrust-borsBot
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 10, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Merged

@rust-log-analyzer
rust-log-analyzer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
A job failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15 105M 6.2M 99M 6% /boot/efi
tmpfs 1.6G 12K 1.6G 1% /run/user/1001
================================================================================
Sufficient disk space available (95909384KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}


This was referenced Mar 10, 2026
 Merged

 Closed

 Merged

@jyn514
jyn514
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
i mean, the network is fine, it's ghcr.io that's down ...

This was referenced Mar 10, 2026
 Merged

 Merged

 Merged

@rust-borsrust-borsBot
added

merged-by-bors
This PR was explicitly merged by bors.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Mar 10, 2026
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
☀️ Test successful - CI

Approved by: matthiaskrgr

Duration: 3h 18m 46s

Pushing 0c68443 to main...
@rust-bors
rust-borsBot
merged commit 0c68443
into
rust-lang:mainMar 10, 2026

12 checks passed

@rustbotrustbot
added this to the 1.96.0 milestone
Mar 10, 2026
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#148562In Option::get_or_insert_with(), forget the None instea…33891b65ed9b64812e7efe000fdf6f3db671bf15 (link)
#153325tests/ui/cfg: add annotations for reference rulesdf67f754b00fcd06750c5483c9b91be1917e9aba (link)
#153621Remove TyCtxt::node_span_lint method8bcd51980b376bb405c774cbaf77b5efe42eab96 (link)
#153627rustdoc-json: Improve docs for ItemEnum::item_kind8dfbefe5b670bf377ef30be14bc5f7031430fb37 (link)
previous master: 3bc6ea5673
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3bc6ea5 (parent) -> 0c68443 (this PR)
Test differences
Show 244 test diffs

Stage 1
  • option::const_get_or_insert_default: [missing] -> pass (J1)
  • option::const_get_or_insert_with: [missing] -> pass (J1)
Stage 2
  • option::const_get_or_insert_default: [missing] -> pass (J0)
  • option::const_get_or_insert_with: [missing] -> pass (J0)
Additionally, 240 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0c68443b0a0469e4211acca7e7b06e14f256ada8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 27m 17s -> 33m 54s (+24.2%)
  2. aarch64-apple: 2h 41m -> 3h 11m (+18.2%)
  3. dist-apple-various: 1h 51m -> 1h 31m (-18.2%)
  4. i686-gnu-2: 1h 30m -> 1h 43m (+15.0%)
  5. pr-check-2: 38m 45s -> 44m 31s (+14.9%)
  6. x86_64-gnu-llvm-20-3: 1h 44m -> 1h 59m (+14.8%)
  7. dist-ohos-armv7: 1h 10m -> 1h 19m (+12.8%)
  8. aarch64-gnu-llvm-20-1: 53m 18s -> 59m 31s (+11.7%)
  9. dist-aarch64-apple: 1h 33m -> 1h 44m (+11.4%)
  10. x86_64-gnu-aux: 2h 13m -> 2h 28m (+11.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-borsrust-borsBot
mentioned this pull request
Mar 10, 2026
 Closed

@JonathanBrouwer
JonathanBrouwer
commented
Mar 10, 2026

Copy link


Copy Markdown

Member
@bors treeopen
@rust-bors
rust-borsBot
commented
Mar 10, 2026

Copy link


Copy Markdown

Contributor
Tree is now open for merging.
@rust-timer
rust-timer
commented
Mar 10, 2026

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (0c68443): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.2%[-0.2%, -0.1%]3
Improvements ✅ 
 (secondary)		-0.2%[-0.3%, -0.1%]15
All ❌✅ (primary)-0.2%[-0.2%, -0.1%]3
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 5.0%, secondary -0.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		5.0%[5.0%, 5.0%]1
Regressions ❌ 
 (secondary)		2.3%[2.3%, 2.3%]1
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.5%[-2.5%, -2.5%]1
All ❌✅ (primary)5.0%[5.0%, 5.0%]1
Binary size
Results (primary 1.4%, secondary -0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.4%[1.4%, 1.4%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-0.0%[-0.0%, -0.0%]1
All ❌✅ (primary)1.4%[1.4%, 1.4%]1
Bootstrap: 479.559s -> 480.034s (0.10%)
Artifact size: 394.94 MiB -> 394.90 MiB (-0.01%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

A-rustdoc-jsonArea: Rustdoc JSON backendmerged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupT-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

11 participants

@matthiaskrgr@rust-log-analyzer@Zalathar@JonathanBrouwer@jyn514@rust-timer@rustbot@kpreid@DanielEScherzer@GuillaumeGomez@aDotInTheVoid