Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Add optional CI job to build the compiler with the parallel frontend by Kobzol · Pull Request #153726 · rust-lang/rust · GitHub
Skip to content

Add optional CI job to build the compiler with the parallel frontend - #153726

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional
Mar 12, 2026
Merged

Add optional CI job to build the compiler with the parallel frontend#153726
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Kobzol:parallel-frontend-tests-optional

Conversation

@Kobzol

@KobzolKobzol commented Mar 11, 2026

Copy link
Copy Markdown
Member

Discussed on Zulip.

Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).

r? @jieyouxu

@rustbotrustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 11, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try jobs=x86_64-gnu-parallel-frontend

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Mar 11, 2026
Add optional CI job to run tests with the parallel frontend
try-job: x86_64-gnu-parallel-frontend
@KobzolKobzol changed the title Add optional CI job to run tests with the parallel frontendAdd optional CI job to build the compiler with the parallel frontendMar 11, 2026
@rust-bors

rust-borsBot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 84afa72 (84afa72e5bb52b18560d0f7a0c1668d6842acaa1, parent: 3b1b0ef4d80d3117924d91352c8b6ca528708b3c)

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General idea seems good, some clarifications
@rustbot author

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
Comment threadsrc/ci/docker/host-x86_64/x86_64-gnu-parallel-frontend/Dockerfile Outdated
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 3a48d69 to 5ac0eedCompareMarch 12, 2026 08:08
@Kobzol
Kobzolforce-pushed the parallel-frontend-tests-optional branch from 5ac0eed to 96e4833CompareMarch 12, 2026 08:09
@Kobzol

Copy link
Copy Markdown
MemberAuthor

Updated docs and adopted the optional- naming convention.

@jieyouxujieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me with one doc nit (I forgot to mention)

View changes since this review

Comment threadsrc/ci/citool/src/jobs.rs
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @tshepang

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Mar 12, 2026
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors r=jieyouxu

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b3333b3 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

⌛ Testing commit b3333b3 with merge dc9c2eb...

Workflow: https://github.com/rust-lang/rust/actions/runs/22999418572

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…eyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
…ional, r=jieyouxu
Add optional CI job to build the compiler with the parallel frontend
Discussed on [Zulip](https://rust-lang.zulipchat.com/#narrow/channel/187679-t-compiler.2Fparallel-rustc/topic/Add.20the.20parallel.20front-end.20test.20suite/with/578684794).
Note: this only builds the compiler, stdlib, etc. with 2 threads. UI tests are still compiled serially. I'd add that in a follow-up PR if we see that this new job works well (and if optional auto jobs work well in the first place).
r? @jieyouxu
@ZalatharZalathar mentioned this pull request Mar 12, 2026
@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors yield
Yielding to enclosing rollup

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Auto build was cancelled. Cancelled workflows:

The next pull request likely to be tested is #153770.

rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@Zalathar

Copy link
Copy Markdown
Member

@bors yield (enclosing rollup)

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

❗ There is currently no auto build in progress on this PR.

@petrochenkov

Copy link
Copy Markdown
Contributor

if we see that this new job works well

Not sure about the CI environment, but locally I've been working on rustc with RUSTFLAGS="-Zthreads=8" enabled for a couple of years (?) already and have only seen incremental issues (or temporary regressions like #152717), so I'm optimistic.

@rust-bors
rust-borsBot merged commit 305778c into rust-lang:mainMar 12, 2026
11 of 12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
@Kobzol
Kobzol deleted the parallel-frontend-tests-optional branch March 12, 2026 15:31
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@petrochenkov

petrochenkov commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

@Kobzol
If the optional job fails on some PR, how do we know about it? E.g. to open an issue.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I'm not sure, to be honest. I guess we'd have to try to fail it forcefully to see what happens. We have scripts that could find out if it failed e.g. in the past week, but that's a bit unsystematic. I guess this can also be used - right now the failure rate seems to be zero.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-rustc-dev-guideArea: rustc-dev-guideA-testsuiteArea: The testsuite used to check the correctness of rustcS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@Kobzol@rustbot@JonathanBrouwer@Zalathar@petrochenkov@jieyouxu