Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Don't add empty target features for target-cpu=native on macOS by nikic · Pull Request #153763 · rust-lang/rust · GitHub
Skip to content

Don't add empty target features for target-cpu=native on macOS - #153763

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix
Mar 12, 2026
Merged

Don't add empty target features for target-cpu=native on macOS#153763
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
nikic:target-cpu-native-fix

Conversation

@nikic

Copy link
Copy Markdown
Contributor

LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.

Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds some target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables neon if it's already enabled. (This is to avoid enabling it on softfloat targets.)

Fixes#153397.

LLVM does not support host feature detection (only host cpu
detection) on apple platforms. As such, the returned feature
string will be empty. Adding this empty string to the target-features
attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features.
The reason why this was not caught by the target-cpu-native test
is that it requires a function that adds *some* target features,
otherwise the attribute is omitted entirely. We achieve this with
a somewhat peculiar construction that enables `neon` if it's
already enabled. (This is to avoid enabling it on softfloat targets.)
@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 12, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@theemathastheemathas added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 12, 2026
@lqd

lqd commented Mar 12, 2026

Copy link
Copy Markdown
Member

Thanks for the super quick fix!

r? me and r=me when green

@rustbotrustbot assigned lqd and unassigned davidtwcoMar 12, 2026
@nikic

Copy link
Copy Markdown
ContributorAuthor

@bors r=lqd

@rust-bors

rust-borsBot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0670491 has been approved by lqd

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 12, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
Rollup of 11 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153708 (de-non_const `Iterator` trait methods)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
Zalathar added a commit to Zalathar/rust that referenced this pull request Mar 12, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ZalatharZalathar mentioned this pull request Mar 12, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 12, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- #153726 (Add optional CI job to build the compiler with the parallel frontend)
- #153763 (Don't add empty target features for target-cpu=native on macOS)
- #153432 (Fix some comments about dataflow analysis.)
- #153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- #153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- #153717 (unused_macro_rules switched used and unused comments)
- #153736 (add test that an incomplete feature emits a warning)
- #153748 (editorconfig: css uses tabs)
- #153750 (rustc-dev-guide subtree update)
- #153762 (actually make the is-fn test test what it says it tests)
@madsmtmmadsmtm added the O-macos Operating system: macOS label Mar 12, 2026
@rust-bors
rust-borsBot merged commit 0102e91 into rust-lang:mainMar 12, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 12, 2026
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 16, 2026
…uwer
Rollup of 10 pull requests
Successful merges:
- rust-lang/rust#153726 (Add optional CI job to build the compiler with the parallel frontend)
- rust-lang/rust#153763 (Don't add empty target features for target-cpu=native on macOS)
- rust-lang/rust#153432 (Fix some comments about dataflow analysis.)
- rust-lang/rust#153529 (Fix LegacyKeyValueFormat report from docker build: pr)
- rust-lang/rust#153694 (fix(query): Pass Query Key to `value_from_cycle_error`)
- rust-lang/rust#153717 (unused_macro_rules switched used and unused comments)
- rust-lang/rust#153736 (add test that an incomplete feature emits a warning)
- rust-lang/rust#153748 (editorconfig: css uses tabs)
- rust-lang/rust#153750 (rustc-dev-guide subtree update)
- rust-lang/rust#153762 (actually make the is-fn test test what it says it tests)
@rustbot

Copy link
Copy Markdown
Collaborator

beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them.

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Mar 19, 2026
ehuss pushed a commit to ehuss/rust that referenced this pull request Mar 25, 2026
Don't add empty target features for target-cpu=native on macOS
LLVM does not support host feature detection (only host cpu detection) on apple platforms. As such, the returned feature string will be empty. Adding this empty string to the target-features attribute results in a verifier error on LLVM 22.
Fix this by not adding the empty string to the target features. The reason why this was not caught by the target-cpu-native test is that it requires a function that adds *some* target features, otherwise the attribute is omitted entirely. We achieve this with a somewhat peculiar construction that enables `neon` if it's already enabled. (This is to avoid enabling it on softfloat targets.)
Fixesrust-lang#153397.
@ehussehuss mentioned this pull request Mar 25, 2026
@ehussehuss removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 25, 2026
@ehussehuss modified the milestones: 1.96.0, 1.95.0Mar 25, 2026
rust-borsBot pushed a commit that referenced this pull request Mar 25, 2026
[beta] backports
- Update cargo
- #153763: Don't add empty target features for target-cpu=native on macOS - #153491: Move `freeze_*` methods to `OpenOptionsExt2`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.A-run-makeArea: port run-make Makefiles to rmake.rsbeta-acceptedAccepted for backporting to the compiler in the beta channel.O-macosOperating system: macOSS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: LLVM ERROR "Broken module" with -C target-cpu=native on aarch64-apple-darwin (Apple M5, LLVM 22.1.0)

7 participants

@nikic@rustbot@lqd@ehuss@davidtwco@theemathas@madsmtm