Do not attempt generating DllImport for extern types by mati865 · Pull Request #154147 · rust-lang/rust

mati865 · 2026-03-20T16:18:38Z

rustbot · 2026-03-20T18:28:28Z

r? @dingxiangfei2009

rustbot has assigned @dingxiangfei2009.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 69 candidates
Random selection from 12 candidates

mati865 · 2026-03-20T18:30:23Z

+//@ only-elf
+//@ ignore-cross-compile: Runs a binary.
+//@ needs-dynamic-linking
+// FIXME(raw_dylib_elf): Debug the failures on other targets.
+//@ only-gnu
+//@ only-x86_64


This is a copy from other raw-dylib-elf tests.
I don't know if we can make it run on both Windows and ELF && gnu && x86_64 at the same time.

mati865 · 2026-04-03T09:26:08Z

@rustbot reroll

chenyukang · 2026-04-03T09:30:23Z

@rustbot reroll

adwinwhite · 2026-04-03T11:56:20Z

@rustbot reroll

petrochenkov · 2026-04-07T14:04:47Z

@bors r+

rust-bors · 2026-04-07T14:04:50Z

📌 Commit 93b960e has been approved by petrochenkov

It is now in the queue for this repository.

…petrochenkov Do not attempt generating DllImport for extern types Fixesrust-lang#154111

…uwer Rollup of 22 pull requests Successful merges: - #150965 (Fix no results when searching for == in doc) - #153999 (Remove `TaggedQueryKey::def_kind`) - #154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - #154147 (Do not attempt generating DllImport for extern types) - #154812 (Update Fira Mono License Information) - #154880 (bootstrap: minor improvements to download-rustc) - #154886 (Stabilize check-cfg suggestions for symbol) - #154889 (Update wasm-component-ld to 0.5.22) - #154928 (Fix pin docs) - #154942 (delegation: generate more verbose error delegation) - #153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - #154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - #154673 (Use a different name for fast try builds) - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - #154795 (Add more info about where autodiff can be applied) - #154808 (Post-attribute ports cleanup pt. 1) - #154825 (constify `Step for NonZero<u*>`) - #154837 (library: std: motor: use OS' process::exit in abort_internal) - #154866 (add regression test for #146514) - #154922 (c-b: Export inverse hyperbolic trigonometric functions) - #154931 (delegation(small cleanup): remove not needed PhantomData) - #154950 (library: no `cfg(target_arch)` on scalable intrinsics)

Rollup merge of #154147 - mati865:raw-dylib-extern-types, r=petrochenkov Do not attempt generating DllImport for extern types Fixes#154111

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#150965 (Fix no results when searching for == in doc) - rust-lang/rust#153999 (Remove `TaggedQueryKey::def_kind`) - rust-lang/rust#154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - rust-lang/rust#154147 (Do not attempt generating DllImport for extern types) - rust-lang/rust#154812 (Update Fira Mono License Information) - rust-lang/rust#154880 (bootstrap: minor improvements to download-rustc) - rust-lang/rust#154886 (Stabilize check-cfg suggestions for symbol) - rust-lang/rust#154889 (Update wasm-component-ld to 0.5.22) - rust-lang/rust#154928 (Fix pin docs) - rust-lang/rust#154942 (delegation: generate more verbose error delegation) - rust-lang/rust#153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - rust-lang/rust#154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - rust-lang/rust#154673 (Use a different name for fast try builds) - rust-lang/rust#154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - rust-lang/rust#154795 (Add more info about where autodiff can be applied) - rust-lang/rust#154808 (Post-attribute ports cleanup pt. 1) - rust-lang/rust#154825 (constify `Step for NonZero<u*>`) - rust-lang/rust#154837 (library: std: motor: use OS' process::exit in abort_internal) - rust-lang/rust#154866 (add regression test for rust-lang/rust#146514) - rust-lang/rust#154922 (c-b: Export inverse hyperbolic trigonometric functions) - rust-lang/rust#154931 (delegation(small cleanup): remove not needed PhantomData) - rust-lang/rust#154950 (library: no `cfg(target_arch)` on scalable intrinsics)

Do not attempt generating imports for extern types
93b960e

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2026

mati865 marked this pull request as ready for review March 20, 2026 18:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2026

rustbot assigned dingxiangfei2009 Mar 20, 2026

mati865 commented Mar 20, 2026
View reviewed changes

rustbot assigned chenyukang and unassigned dingxiangfei2009 Apr 3, 2026

rustbot assigned adwinwhite and unassigned chenyukang Apr 3, 2026

rustbot assigned petrochenkov and unassigned adwinwhite Apr 3, 2026

mati865 changed the title ~~Do not attempt generating imports for extern types~~Do not attempt generating DllImport for extern typesApr 3, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 7, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
Rollup merge ofrust-lang#154147- mati865:raw-dylib-extern-types, r=…
1c9664c
…petrochenkov Do not attempt generating DllImport for extern types Fixesrust-lang#154111

JonathanBrouwer mentioned this pull request Apr 7, 2026
Rollup of 16 pull requests #154952
Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
Rollup merge ofrust-lang#154147- mati865:raw-dylib-extern-types, r=…
d55731a
…petrochenkov Do not attempt generating DllImport for extern types Fixesrust-lang#154111

JonathanBrouwer mentioned this pull request Apr 7, 2026
Rollup of 15 pull requests #154953
Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 7, 2026
Rollup merge ofrust-lang#154147- mati865:raw-dylib-extern-types, r=…
feea138
…petrochenkov Do not attempt generating DllImport for extern types Fixesrust-lang#154111

JonathanBrouwer mentioned this pull request Apr 7, 2026
Rollup of 22 pull requests #154958
Merged

rust-borsBot merged commit edddc21 into rust-lang:mainApr 7, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Apr 7, 2026

rust-timer added a commit that referenced this pull request Apr 7, 2026
Unrolled build for#154147
4cd075f
Rollup merge of #154147 - mati865:raw-dylib-extern-types, r=petrochenkov Do not attempt generating DllImport for extern types Fixes#154111

mati865 deleted the raw-dylib-extern-types branch May 26, 2026 10:31

Navigation Menu

Uh oh!

Uh oh!

Do not attempt generating DllImport for extern types - #154147

Do not attempt generating DllImport for extern types#154147
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
mati865:raw-dylib-extern-types

mati865 commented Mar 20, 2026

Uh oh!

rustbot commented Mar 20, 2026

Uh oh!

mati865Mar 20, 2026

Uh oh!

mati865 commented Apr 3, 2026

Uh oh!

chenyukang commented Apr 3, 2026

Uh oh!

adwinwhite commented Apr 3, 2026

Uh oh!

petrochenkov commented Apr 7, 2026

Uh oh!

rust-borsBot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

mati865 commented Mar 20, 2026

Uh oh!

rustbot commented Mar 20, 2026

Uh oh!

mati865Mar 20, 2026

Choose a reason for hiding this comment

Uh oh!

mati865 commented Apr 3, 2026

Uh oh!

chenyukang commented Apr 3, 2026

Uh oh!

adwinwhite commented Apr 3, 2026

Uh oh!

petrochenkov commented Apr 7, 2026

Uh oh!

rust-borsBot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants