Post-attribute ports cleanup pt. 1 by JonathanBrouwer · Pull Request #154808 · rust-lang/rust

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 1.3%, secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.3%	[1.3%, 1.3%]	1
Regressions ❌ (secondary)	3.0%	[1.8%, 4.1%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.0%	[-2.2%, -1.9%]	3
All ❌✅ (primary)	1.3%	[1.3%, 1.3%]	1

Cycles

Results (secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[3.0%, 7.6%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-3.3%, -2.5%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.0%]	56
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.0%]	25
All ❌✅ (primary)	-0.1%	[-0.1%, -0.0%]	56

Bootstrap: 489.285s -> 487.19s (-0.43%)
Artifact size: 395.03 MiB -> 394.99 MiB (-0.01%)

JonathanBrouwer · 2026-04-05T06:26:08Z

That's just noise :)

jdonszelmann

Some small things, but in general: damn I'm so happy to see this. Been waiting a year an a half to do this. Thanks to everyone who joined the effort to get to this point, and thanks Jonathan for finally starting The Big Clean Up ™️

View changes since this review

jdonszelmann · 2026-04-05T07:51:04Z

 // `TyCtxt::check_mod_attrs`), but by the time that runs the macro
 // is expanded, and it doesn't give an error.
- validate_attr::emit_fatal_malformed_builtin_attribute(&sess.psess, first_path, sym::path);
+ emit_malformed_attribute(&sess.psess, first_path.style, first_path.span, sym::path, template!(


this should maybe also be a parsed attribute 🤔

Agreed, I tried to make it one but then discovered #154781, so it is blocked on that

rustbot · 2026-04-05T07:57:40Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

JonathanBrouwer · 2026-04-05T09:37:15Z

@rustbot ready

Post-attribute ports cleanup pt. 1 try-job: i686-msvc-2

rust-bors · 2026-04-07T09:18:46Z

☀️ Try build successful (CI)
Build commit: bb4de55 (bb4de55f9370d729915bebad8e4b07c8f2fa4646, parent: bcded331651b60a0383b3ff51db4f24c4495ac53)

JonathanBrouwer · 2026-04-07T09:19:34Z

@bors r=jdonszelmann
For now lets merge this without the problematic commit, while I figure out what the problem with that commit is

rust-bors · 2026-04-07T09:19:38Z

📌 Commit 89db636 has been approved by jdonszelmann

It is now in the queue for this repository.

@jdonszelmann

…onszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit

@jdonszelmann

…onszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit

@jdonszelmann

…onszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit

…uwer Rollup of 22 pull requests Successful merges: - #150965 (Fix no results when searching for == in doc) - #153999 (Remove `TaggedQueryKey::def_kind`) - #154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - #154147 (Do not attempt generating DllImport for extern types) - #154812 (Update Fira Mono License Information) - #154880 (bootstrap: minor improvements to download-rustc) - #154886 (Stabilize check-cfg suggestions for symbol) - #154889 (Update wasm-component-ld to 0.5.22) - #154928 (Fix pin docs) - #154942 (delegation: generate more verbose error delegation) - #153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - #154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - #154673 (Use a different name for fast try builds) - #154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - #154795 (Add more info about where autodiff can be applied) - #154808 (Post-attribute ports cleanup pt. 1) - #154825 (constify `Step for NonZero<u*>`) - #154837 (library: std: motor: use OS' process::exit in abort_internal) - #154866 (add regression test for #146514) - #154922 (c-b: Export inverse hyperbolic trigonometric functions) - #154931 (delegation(small cleanup): remove not needed PhantomData) - #154950 (library: no `cfg(target_arch)` on scalable intrinsics)

@jdonszelmann

Rollup merge of #154808 - JonathanBrouwer:attr_cleanup, r=jdonszelmann Post-attribute ports cleanup pt. 1 r? @jdonszelmann This cleans up some checks I could find were for non-parsed attributes, and works towards removing BUILTIN_ATTRIBUTES All commits do one thing and every commit passes tests, so best reviewed commit by commit

…uwer Rollup of 22 pull requests Successful merges: - rust-lang/rust#150965 (Fix no results when searching for == in doc) - rust-lang/rust#153999 (Remove `TaggedQueryKey::def_kind`) - rust-lang/rust#154146 (Split out the creation of `Cycle` to a new `process_cycle` function) - rust-lang/rust#154147 (Do not attempt generating DllImport for extern types) - rust-lang/rust#154812 (Update Fira Mono License Information) - rust-lang/rust#154880 (bootstrap: minor improvements to download-rustc) - rust-lang/rust#154886 (Stabilize check-cfg suggestions for symbol) - rust-lang/rust#154889 (Update wasm-component-ld to 0.5.22) - rust-lang/rust#154928 (Fix pin docs) - rust-lang/rust#154942 (delegation: generate more verbose error delegation) - rust-lang/rust#153269 (GCI: During reachability analysis don't try to evaluate the initializer of overly generic free const items) - rust-lang/rust#154506 (Migrate some tests from `tests/ui/issues` to appropriate directories) - rust-lang/rust#154673 (Use a different name for fast try builds) - rust-lang/rust#154761 (coretests: add argument order regression tests for min_by/max_by/minmax_by) - rust-lang/rust#154795 (Add more info about where autodiff can be applied) - rust-lang/rust#154808 (Post-attribute ports cleanup pt. 1) - rust-lang/rust#154825 (constify `Step for NonZero<u*>`) - rust-lang/rust#154837 (library: std: motor: use OS' process::exit in abort_internal) - rust-lang/rust#154866 (add regression test for rust-lang/rust#146514) - rust-lang/rust#154922 (c-b: Export inverse hyperbolic trigonometric functions) - rust-lang/rust#154931 (delegation(small cleanup): remove not needed PhantomData) - rust-lang/rust#154950 (library: no `cfg(target_arch)` on scalable intrinsics)

This reverts commit 0c94559, reversing changes made to 3352861.

@ghost

Revert "Port lint attributes to attribute parser" This PR reverts the following two PRs: - #154808 - #152369 This was not a clean revert, I manually solved several merge conflicts. Closes#154878Closes#154800Closes#155008 Re-opens #132218 (this was never closed, oops) r? @ghost

@jdonszelmann

Post-attribute ports cleanup pt. 1 (again) This is a re-implementation of most (but not all) of #154808 The code is the same as in that PR, other than a few changes, I'll leave comments where I changed things. I did re-implement most of the commits rather than cherry-picking, so it's probably good to check the entire diff regardless r? @jdonszelmann

@jdonszelmann

Post-attribute ports cleanup pt. 1 (again) This is a re-implementation of most (but not all) of rust-lang/rust#154808 The code is the same as in that PR, other than a few changes, I'll leave comments where I changed things. I did re-implement most of the commits rather than cherry-picking, so it's probably good to check the entire diff regardless r? @jdonszelmann

@jdonszelmann

Post-attribute ports cleanup pt. 1 (again) This is a re-implementation of most (but not all) of rust-lang/rust#154808 The code is the same as in that PR, other than a few changes, I'll leave comments where I changed things. I did re-implement most of the commits rather than cherry-picking, so it's probably good to check the entire diff regardless r? @jdonszelmann

@ghost

Revert "Port lint attributes to attribute parser" This PR reverts the following two PRs: - rust-lang/rust#154808 - rust-lang/rust#152369 This was not a clean revert, I manually solved several merge conflicts. Closesrust-lang/rust#154878Closesrust-lang/rust#154800Closesrust-lang/rust#155008 Re-opens rust-lang/rust#132218 (this was never closed, oops) r? @ghost

@jdonszelmann

Post-attribute ports cleanup pt. 1 (again) This is a re-implementation of most (but not all) of rust-lang/rust#154808 The code is the same as in that PR, other than a few changes, I'll leave comments where I changed things. I did re-implement most of the commits rather than cherry-picking, so it's probably good to check the entire diff regardless r? @jdonszelmann

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 4, 2026

rustbot assigned jdonszelmann Apr 4, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 4, 2026
Auto merge of#154808- JonathanBrouwer:attr_cleanup, r=<try>
643c6fe
Post-attribute ports cleanup pt. 1

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 4, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 4, 2026
Auto merge of#154808- JonathanBrouwer:attr_cleanup, r=<try>
80c2a26
Post-attribute ports cleanup pt. 1

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 5, 2026

jdonszelmann reviewed Apr 5, 2026
View reviewed changes

Comment threadcompiler/rustc_attr_parsing/src/validate_attr.rs Outdated

jdonszelmann requested changes Apr 5, 2026
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2026

JonathanBrouwer force-pushed the attr_cleanup branch from bd51105 to d23c724Compare April 5, 2026 09:36

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 5, 2026

Simplify attribute validation
c324d6e

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Apr 7, 2026
Auto merge of#154808- JonathanBrouwer:attr_cleanup, r=<try>
bb4de55
Post-attribute ports cleanup pt. 1 try-job: i686-msvc-2

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 7, 2026

JonathanBrouwer mentioned this pull request Apr 7, 2026
Remove HashStable impl for [hir::Attribute]. #154924
Merged

JonathanBrouwer mentioned this pull request Apr 7, 2026
Rollup of 10 pull requests #154951
Closed

JonathanBrouwer mentioned this pull request Apr 7, 2026
Rollup of 16 pull requests #154952
Closed

This was referenced Apr 7, 2026
Rollup of 15 pull requests #154953
Closed
Rollup of 22 pull requests #154958
Merged

rust-borsBot merged commit 0c94559 into rust-lang:mainApr 7, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Apr 7, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 9, 2026
Revertrust-lang#154808because it is based onrust-lang#152369
30107e8
This reverts commit 0c94559, reversing changes made to 3352861.

JonathanBrouwer mentioned this pull request Apr 9, 2026
Revert "Port lint attributes to attribute parser" #155056
Merged

JonathanBrouwer mentioned this pull request Apr 12, 2026
Post-attribute ports cleanup pt. 1 (again) #155209
Merged

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Apr 4, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 4, 2026

Uh oh!

Bryntet commented Apr 4, 2026

Uh oh!

JonathanBrouwer commented Apr 4, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

JonathanBrouwer commented Apr 4, 2026

Uh oh!

rust-borsBot commented Apr 4, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Apr 4, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Apr 5, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

JonathanBrouwer commented Apr 5, 2026

Uh oh!

Uh oh!

jdonszelmann left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdonszelmannApr 5, 2026

Choose a reason for hiding this comment

Uh oh!

JonathanBrouwerApr 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 5, 2026

Uh oh!

JonathanBrouwer commented Apr 5, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Apr 7, 2026

Uh oh!

JonathanBrouwer commented Apr 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JonathanBrouwer commented Apr 4, 2026•
edited by rustbot
Loading

jdonszelmann left a comment •
edited by rustbot
Loading

JonathanBrouwer commented Apr 7, 2026•
edited
Loading