resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities by petrochenkov · Pull Request #154149 · rust-lang/rust

petrochenkov · 2026-03-20T17:34:03Z

Continuation of #149596, implementation of this comment #149596 (comment) in particular.
FCP for the lint in general - #149596 (comment).
#152498 is reverted as a part of the change, but fixes are applied to keep the tests added in that PR working.

To implement this we have to have to track the most and the least visible declarations in an ambiguous glob set.

Part of #153961.
r? @yaahc maybe

petrochenkov · 2026-03-20T17:35:35Z

 tcx,
 );
+ if let Some(max_vis_decl) = decl.ambiguity_vis_max.get() {
+ // Avoid the most visible import in an ambiguous glob set being reported as unused.


This is a fix for #152004.

petrochenkov · 2026-03-20T17:36:39Z


 if let Some(binding) = resolution.binding()
- && old_decl != Some(binding)
+ && (old_decl != Some(binding) || old_vis != Some(binding.vis()))


And this is a fix for #152347.
Here we are triggering the glob re-fetching on visibility updates.

petrochenkov · 2026-03-20T17:52:58Z

@bors try

resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities

rust-bors · 2026-03-20T19:59:56Z

☀️ Try build successful (CI)
Build commit: 4907eac (4907eac94165faff6c5e5e015670b1c584275f7b, parent: bfc05d6b072585dfd0c792ec1b8728c08a3511fe)

petrochenkov · 2026-03-20T20:12:39Z

@craterbot check

craterbot · 2026-03-20T20:13:15Z

👌 Experiment pr-154149 created and queued.
🤖 Automatically detected try build 4907eac
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-03-28T10:24:52Z

🚧 Experiment pr-154149 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2026-03-30T08:16:36Z

🎉 Experiment pr-154149 is completed!
📊 136 regressed and 4 fixed (858234 total)
📊 5129 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-154149/retry-regressed-list.txt↩

petrochenkov · 2026-04-30T07:33:32Z

libc is a stress test for imports, and we are now doing more work to check imports for visibility ambiguities.

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

panstromek · 2026-05-05T09:23:07Z

perf triage:

Marking as triaged based on the comment above.

@rustbot label: +perf-regression-triaged

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

@mu001999

Rollup merge of #156014 - petrochenkov:kvak, r=mu001999 resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging #155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from #155257, #155213, #154149, etc. r? @mu001999

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang/rust#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang/rust#155257, rust-lang/rust#155213, rust-lang/rust#154149, etc. r? @mu001999

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every #154149 / #156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every #154149 / #156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every #154149 / #156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixes#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every #154149 / #156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

@rustbot

…biguity, r=petrochenkov resolve: fix effective visibilities for items in ambiguous glob sets Fixesrust-lang#159038 (1.96.1 → 1.97.0 regression; details there). When an item is glob-imported twice at different visibilities, effective visibility was computed from whichever declaration arrived first, not the most visible one. An exported item could then get no MIR encoded, and downstream crates fail with ``missing optimized MIR``. Fix: also walk the most visible declaration's re-export chain (`update_decl_chain`, recursing into `ambiguity_vis_max`). Lint behavior unchanged. Two regression tests added; `tests/ui/{imports,privacy,resolve}` pass with every rust-lang#154149 / rust-lang#156284 test unmodified. @rustbot label +A-resolve +A-visibility +T-compiler +regression-from-stable-to-stable

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2026

rustbot assigned yaahc Mar 20, 2026

petrochenkov commented Mar 20, 2026
View reviewed changes

Comment threadcompiler/rustc_middle/src/middle/privacy.rs

petrochenkov commented Mar 20, 2026
View reviewed changes

petrochenkov force-pushed the globvisglob branch from 171ed29 to 8c30e81Compare March 20, 2026 17:52

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Mar 20, 2026
Auto merge of#154149- petrochenkov:globvisglob, r=<try>
4907eac
resolve: Extend `ambiguous_import_visibilities` deprecation lint to glob-vs-glob ambiguities

petrochenkov added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2026

This comment has been minimized.
Sign in to view

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Mar 30, 2026

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2026

petrochenkov force-pushed the globvisglob branch from 8c30e81 to 9ea5bf0Compare April 8, 2026 16:48

This comment has been minimized.
Sign in to view

petrochenkov force-pushed the globvisglob branch from 9ea5bf0 to 5d4ff02Compare April 9, 2026 16:59

This comment has been minimized.
Sign in to view

petrochenkov force-pushed the globvisglob branch from 5d4ff02 to 3b24e32Compare April 10, 2026 16:21

rustbot added the perf-regression Performance regression. label Apr 30, 2026

petrochenkov mentioned this pull request Apr 30, 2026
resolve: Catch "cannot reexport" errors from macros 2.0 better #156014
Merged

rustbot added the perf-regression-triaged The performance regression has been triaged. label May 5, 2026

coderabbitaiBot mentioned this pull request May 7, 2026
refactor: make hl7v2-network a compatibility shim EffortlessMetrics/hl7v2-rs#425
Merged

orlp mentioned this pull request Jun 4, 2026
1.97 beta regression: Rust claims import is unused but crate doesn't compile with it removed #157420
Closed

mu001999 mentioned this pull request Jun 11, 2026
resolve: Remove exported imports from maybe_unused_trait_imports#157713
Merged

petrochenkov deleted the globvisglob branch June 17, 2026 14:54

This was referenced Jul 9, 2026
Regression 1.96.1 → 1.97.0: "missing optimized MIR" for pub fn glob-reexported alongside a restricted glob duplicate #159038
Open
resolve: fix effective visibilities for items in ambiguous glob sets #159039
Merged

Uh oh!

Uh oh!

Conversation

petrochenkov commented Mar 20, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

petrochenkovMar 20, 2026

Choose a reason for hiding this comment

Uh oh!

petrochenkovMar 20, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

petrochenkov commented Mar 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Mar 20, 2026

Uh oh!

petrochenkov commented Mar 20, 2026

Uh oh!

craterbot commented Mar 20, 2026

Uh oh!

craterbot commented Mar 28, 2026

Uh oh!

craterbot commented Mar 30, 2026

Footnotes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

petrochenkov commented Apr 30, 2026

Uh oh!

panstromek commented May 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

petrochenkov commented Mar 20, 2026•
edited by rustbot
Loading