resolve: Catch "cannot reexport" errors from macros 2.0 better by petrochenkov · Pull Request #156014 · rust-lang/rust

petrochenkov · 2026-04-30T19:46:13Z

After the macro 2.0 related holes are closed we can report span_delayed_bugs in more situations.

Merging #155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time.

This is a continuation of my import & privacy invariant hardening changes from #155257, #155213, #154149, etc.

r? @mu001999

petrochenkov · 2026-05-01T04:29:11Z

error[E0365]: extern crate `rustc_abi` is private and cannot be re-exported
--> src/tools/rust-analyzer/crates/hir-def/src/lib.rs:50:9
|
50 | pub use rustc_abi as layout;
| ^^^^^^^^^^^^^^^^^^^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #127909 <https://github.com/rust-lang/rust/issues/127909>
= note: `#[deny(pub_use_of_private_extern_crate)]` (part of `#[deny(future_incompatible)]`) on by default
help: consider making the `extern crate` item publicly accessible
|
18 | pub extern crate ra_ap_rustc_abi as rustc_abi;
| +++

Hmm, legitimate pub_use_of_private_extern_crate error in rust-analyzer, I wonder why it wasn't caught before.

mu001999 · 2026-05-01T07:21:54Z

lgtm, but I also wonder why the error in ra was not caught before. Seems it just one simple case of the lint.

petrochenkov · 2026-05-01T13:16:29Z

I'll look what's going on with rust-analyzer.
@rustbot author

rustbot · 2026-05-01T13:16:33Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

…rate function

petrochenkov · 2026-05-04T16:56:02Z

The problem is in rustc_abi specifically.
There's actually a built-in attribute with this name, so the pub use rustc_abi as layout; import legally reexports at least the built-in attribute, that's why the logic in finalize_import didn't report it.

So the import itself won't be an error when the pub_use_of_private_extern_crate lint is removed, the private extern crate component in type namespace will just be filtered away.
Users of the reexport will break though, because they definitely wan the crate, not the attribute, so we need to lint this case in advance.

rustbot · 2026-05-04T17:05:10Z

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

rustbot · 2026-05-04T17:05:11Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov · 2026-05-04T17:06:18Z

@rustbot ready

mu001999

@bors r+

View changes since this review

rust-bors · 2026-05-05T02:45:24Z

📌 Commit fadb747 has been approved by mu001999

It is now in the queue for this repository.

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

Rollup of 3 pull requests Successful merges: - #154861 (Add rlib digest to identify Rust object files) - #155341 (generic_const_args: allow paths to non type consts) - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better)

@mu001999

resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging rust-lang#155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from rust-lang#155257, rust-lang#155213, rust-lang#154149, etc. r? @mu001999

…uwer Rollup of 7 pull requests Successful merges: - #156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - #156058 (Print HRTB binders before fn qualifiers) - #156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - #156184 (Revert "remove `MethodReceiverExpr` special-casing") - #155957 (Revert const hacks and use const closures in std) - #156127 (Update `askama` version to `0.16.0`) - #156183 (Remove duplicate debug assert)

@mu001999

Rollup merge of #156014 - petrochenkov:kvak, r=mu001999 resolve: Catch "cannot reexport" errors from macros 2.0 better After the macro 2.0 related holes are closed we can report `span_delayed_bug`s in more situations. Merging #155945 would make changes in this PR simpler, but that PR will probably have to wait for quite some time. This is a continuation of my import & privacy invariant hardening changes from #155257, #155213, #154149, etc. r? @mu001999

JonathanBrouwer · 2026-05-08T09:03:29Z

@rust-timer build 56c6db3

rust-timer · 2026-05-08T10:55:30Z

Finished benchmarking commit (56c6db3): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary -0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.7%	[-0.8%, -0.6%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.5%	[0.4%, 4.5%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 495.494s -> 495.332s (-0.03%)
Artifact size: 394.42 MiB -> 394.38 MiB (-0.01%)

…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#156014 (resolve: Catch "cannot reexport" errors from macros 2.0 better) - rust-lang/rust#156058 (Print HRTB binders before fn qualifiers) - rust-lang/rust#156172 (Implement a new flag `-Zdisable-fast-paths` in trait solving) - rust-lang/rust#156184 (Revert "remove `MethodReceiverExpr` special-casing") - rust-lang/rust#155957 (Revert const hacks and use const closures in std) - rust-lang/rust#156127 (Update `askama` version to `0.16.0`) - rust-lang/rust#156183 (Remove duplicate debug assert)

rustbot assigned mu001999 Apr 30, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 30, 2026

This comment has been minimized.
Sign in to view

petrochenkov force-pushed the kvak branch from 03a7971 to b9af4aaCompare April 30, 2026 20:13

This comment has been minimized.
Sign in to view

mu001999 reviewed May 1, 2026
View reviewed changes

Comment threadcompiler/rustc_resolve/src/imports.rs

mu001999 reviewed May 1, 2026
View reviewed changes

Comment threadtests/ui/imports/private-from-decl-macro.fail.stderr

This comment has been minimized.
Sign in to view

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2026

petrochenkov added 3 commits May 4, 2026 15:51

resolve: Factor out reporting of "cannot reexport" errors into a sepa…
cf636ec
…rate function

resolve: Catch "cannot reexport" errors from macros 2.0 better
65e5bd6

resolve: Harden some invariant checks for visibilities
21c58d8

rust-analyzer: Fix pub_use_of_private_extern_crate lint
fadb747

petrochenkov force-pushed the kvak branch from b9af4aa to fadb747Compare May 4, 2026 17:05

rustbot added the T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. label May 4, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 4, 2026

mu001999 approved these changes May 5, 2026
View reviewed changes

rust-borsBot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 5, 2026

rust-borsBot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 5, 2026

jhpratt mentioned this pull request May 5, 2026
Rollup of 3 pull requests #156179
Closed

GuillaumeGomez mentioned this pull request May 5, 2026
Rollup of 7 pull requests #156189
Closed

JonathanBrouwer mentioned this pull request May 5, 2026
Rollup of 7 pull requests #156190
Merged

rust-borsBot merged commit e35334f into rust-lang:mainMay 5, 2026
11 checks passed

rustbot added this to the 1.97.0 milestone May 5, 2026

This was referenced May 6, 2026
Fix Clippy and CI on current serenity-rs/serenity#3549
Merged
E0365 newly triggers on pub(crate) reexports (cannot be re-exported outside) #156264
Closed

This comment has been minimized.
Sign in to view

petrochenkov deleted the kvak branch June 17, 2026 14:54

This was referenced Jul 9, 2026
Regression 1.96.1 → 1.97.0: "missing optimized MIR" for pub fn glob-reexported alongside a restricted glob duplicate #159038
Open
resolve: fix effective visibilities for items in ambiguous glob sets #159039
Merged

Uh oh!

Uh oh!

Conversation

petrochenkov commented Apr 30, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

petrochenkov commented May 1, 2026

Uh oh!

Uh oh!

mu001999 commented May 1, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented May 1, 2026

Uh oh!

rustbot commented May 1, 2026

Uh oh!

petrochenkov commented May 4, 2026

Uh oh!

rustbot commented May 4, 2026

Uh oh!

rustbot commented May 4, 2026

Uh oh!

petrochenkov commented May 4, 2026

Uh oh!

mu001999 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented May 5, 2026

Uh oh!

Uh oh!

JonathanBrouwer commented May 8, 2026

Uh oh!

This comment has been minimized.

rust-timer commented May 8, 2026

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

mu001999 left a comment •
edited by rustbot
Loading