core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

core: Destabilize beta-stable RangeInclusiveIter::remainder - #154459

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder
Mar 29, 2026
Merged

core: Destabilize beta-stable RangeInclusiveIter::remainder#154459
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
tgross35:destabilize-range-iter-remainder

Conversation

@tgross35

@tgross35tgross35 commented Mar 27, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

View all comments

Destabilize RangeInclusiveIter::remainder and move {RangeIter,RangefromIter}::remainder to the new_range_api feature gate.

Original tracking issue: #125687
New tracking issue: #154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 27, 2026
@rustbot

rustbot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @scottmcm, libs
  • @scottmcm, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt, joboet, scottmcm

@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

@rustbot label +beta-nominated

Only the first commit needs to be backported, though there isn't really any harm in taking the second too.

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 27, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 27, 2026

Copy link
Copy Markdown
MemberAuthor

I'm a bit stuck blessing this until #154408 is resolved. If anyone has a successful build, please feel free to push to my branch or take this over.

@ZuseZ4

ZuseZ4 commented Mar 27, 2026

Copy link
Copy Markdown
Member

@tgross35 I'll revert the PR that caused it till someone with a Mac has more time to debug and land a proper fix. But in the meantime, isn't #154408 (comment) a fix for you?

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I did see that a bit later, I'll try it when I get the change. Thanks for pointing it out

@ZuseZ4

ZuseZ4 commented Mar 28, 2026

Copy link
Copy Markdown
Member

Sounds good. Otherwise, here is the revert PR, in case you want to keep track: #154485

@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

That mentioned revert PR landed, so hopefully we're good now.

I'll take #t-libs-api/api-changes > `RangeFrom::remainder` possible panic @ 💬 as libs-api assent to do this, and personally agree with "let's just unstabilize to give time to think about things". (Since it's not stable yet it's not a breaking change to unstabilize either.)

@bors r+

@rust-bors

rust-borsBot commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bf3d60d has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2026
@scottmcm

scottmcm commented Mar 28, 2026

Copy link
Copy Markdown
Member

Oh, and because we want to get this into beta,
@bors p=1

@tgross35

tgross35 commented Mar 28, 2026

Copy link
Copy Markdown
MemberAuthor

I think I still need to bless, just couldn’t do it locally. I’ll be able to double check in half an hour

@bors r-

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 28, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from bf3d60d to 0537c58CompareMarch 28, 2026 23:34
@rustbot

This comment has been minimized.

Sign in to view
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

Just needed to update some feature gates in tests and add an extra error annotation.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0537c58 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@rust-borsrust-borsBot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 29, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 29, 2026
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0537c58 to 0353e88CompareMarch 29, 2026 05:38
@JonathanBrouwer

JonathanBrouwer commented Mar 29, 2026

Copy link
Copy Markdown
Member

@bors r-
Ci failed

@rust-borsrust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

Auto build was cancelled due to unapproval. Cancelled workflows:

@tgross35
core: Move {RangeIter, RangeFromIter}::remainder to `new_range_rema…
0bb3fe3
…inder`
Split the remainder functions from the rest of `std::range`.
@tgross35
tgross35force-pushed the destabilize-range-iter-remainder branch from 0353e88 to 0bb3fe3CompareMarch 29, 2026 07:11
@tgross35

tgross35 commented Mar 29, 2026

Copy link
Copy Markdown
MemberAuthor

I missed adding the feature gate to the new doctests when I rebased.

@bors r=scottmcm

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 0bb3fe3 has been approved by scottmcm

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#154459- tgross35:destabilize-range-iter-re…
4a0bd10
…mainder, r=scottmcm
core: Destabilize beta-stable `RangeInclusiveIter::remainder`
Destabilize `RangeInclusiveIter::remainder` and move `{RangeIter,RangefromIter}::remainder` to the `new_range_api` feature gate.
Original tracking issue: rust-lang#125687
New tracking issue: rust-lang#154458
Discussion: https://rust-lang.zulipchat.com/#narrow/channel/327149-t-libs-api.2Fapi-changes/topic/.60RangeFrom.3A.3Aremainder.60.20possible.20panic/with/582108913
@JonathanBrouwerJonathanBrouwer mentioned this pull request Mar 29, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
@bors
Auto merge of#154542- JonathanBrouwer:rollup-MDa92ED, r=JonathanBro…
12ec2c4
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
@rust-bors

This comment has been minimized.

Sign in to view
@rust-borsrust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 29, 2026
@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

☀️ Test successful - CI
Approved by: scottmcm
Duration: 3h 14m 12s
Pushing cd14b73 to main...

@rust-bors
rust-borsBot merged commit cd14b73 into rust-lang:mainMar 29, 2026
12 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 29, 2026
@github-actions

github-actionsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 584d32e (parent) -> cd14b73 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard cd14b73b4a41542d921f59e362a5b5005fa4f2ef --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-ohos-x86_64: 1h 14m -> 1h 23m (+12.0%)
  2. dist-x86_64-apple: 1h 44m -> 1h 56m (+11.6%)
  3. dist-aarch64-apple: 1h 45m -> 1h 34m (-10.5%)
  4. x86_64-gnu-distcheck: 2h 14m -> 2h 1m (-9.9%)
  5. i686-msvc-2: 2h 1m -> 2h 13m (+9.8%)
  6. dist-armhf-linux: 1h 26m -> 1h 34m (+8.6%)
  7. x86_64-msvc-ext3: 1h 54m -> 1h 44m (-8.4%)
  8. dist-x86_64-msvc-alt: 2h 32m -> 2h 44m (+8.3%)
  9. dist-i686-msvc: 2h 10m -> 2h 20m (+8.0%)
  10. dist-aarch64-llvm-mingw: 1h 39m -> 1h 47m (+7.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (cd14b73): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.1%, secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.8%, 2.4%]2
Regressions ❌
(secondary)		3.0%[3.0%, 3.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[1.8%, 2.4%]2

Cycles

Results (primary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		3.2%[3.2%, 3.2%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)3.2%[3.2%, 3.2%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 484.385s -> 487.525s (0.65%)
Artifact size: 394.81 MiB -> 394.89 MiB (0.02%)

@tgross35
tgross35 deleted the destabilize-range-iter-remainder branch March 29, 2026 20:31
@AmanieuAmanieu added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 1, 2026
@cuvipercuviper mentioned this pull request Apr 2, 2026
Merged
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 2, 2026
@cuvipercuviper modified the milestones: 1.96.0, 1.95.0Apr 2, 2026
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
94d9a11
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
rust-borsBot pushed a commit that referenced this pull request Apr 3, 2026
@bors
Auto merge of#154725- cuviper:beta-next, r=cuviper
cc969f3
[beta] backports
- stdarch subtree update #153336 (partial)
- aarch64: fix UB in non-power-of-two reads and writes rust-lang/stdarch#2042
- add neon load/store assembly test #154094
- don't drop arguments' temporaries in `dbg!` #154074
- Init self_decl with a correct vis #154313
- Update LLVM to 22.1.2 #154344
- [perf] Revert FastISel patch #154511
- core: Destabilize beta-stable `RangeInclusiveIter::remainder` #154459
- Revert "Fix: On wasm targets, call `panic_in_cleanup` if panic occurs in cleanup" #154700
- core: Update the feature gate on `TryFrom<integer> for bool` #154691
r? cuviper
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joboetjoboet

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

10 participants

@tgross35@rustbot@rust-log-analyzer@ZuseZ4@scottmcm@JonathanBrouwer@rust-timer@cuviper@Amanieu@joboet