Skip to content

Add IoSplit diagnostic item for std::io::Split - #154416

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
vitkyrka:split-diag
Mar 30, 2026
Merged

Add IoSplit diagnostic item for std::io::Split#154416
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
vitkyrka:split-diag

Conversation

@vitkyrka

Copy link
Copy Markdown
Contributor

Similar to the existing IoLines item. It will be used in Clippy to detect uses of Split leading to infinite loops similar to the existing lint for Lines.

Similar to the existing `IoLines` item. It will be used in Clippy to
detect uses of `Split` leading to infinite loops similar to the existing
lint for `Lines`.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 26, 2026
@vitkyrka
vitkyrka marked this pull request as ready for review March 26, 2026 11:44
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2026
@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 26, 2026
@rustbot

Copy link
Copy Markdown
Collaborator

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, jhpratt

@Noratrieb

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-borsBot commented Mar 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit eee01dd has been approved by Noratrieb

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 29, 2026
Add `IoSplit` diagnostic item for `std::io::Split`
Similar to the existing `IoLines` item. It will be used in Clippy to detect uses of `Split` leading to infinite loops similar to the existing lint for `Lines`.
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
…uwer
Rollup of 4 pull requests
Successful merges:
- #154459 (core: Destabilize beta-stable `RangeInclusiveIter::remainder`)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154530 (update zulip link in `std` documentation)
rust-borsBot pushed a commit that referenced this pull request Mar 29, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- #154074 (don't drop arguments' temporaries in `dbg!`)
- #154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer)
- #154540 (Fix invalid type suggestion for item nested in function)
- #154549 (Add regression test for recursive lazy type alias normalization ICE)
- #153373 (Fix LegacyKeyValueFormat report from docker build: powerpc)
- #154322 (feat: reimplement `hash_map!` macro)
- #154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- #154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16)
- #154508 (Fix ambiguous parsing in bootstrap.py)
- #154518 (Panic in Hermit clock_gettime)
- #154530 (update zulip link in `std` documentation)
@rust-bors
rust-borsBot merged commit 46dcf27 into rust-lang:mainMar 30, 2026
11 checks passed
@rustbotrustbot added this to the 1.96.0 milestone Mar 30, 2026
rust-timer added a commit that referenced this pull request Mar 30, 2026
Rollup merge of #154416 - vitkyrka:split-diag, r=Noratrieb
Add `IoSplit` diagnostic item for `std::io::Split`
Similar to the existing `IoLines` item. It will be used in Clippy to detect uses of `Split` leading to infinite loops similar to the existing lint for `Lines`.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Mar 30, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#154074 (don't drop arguments' temporaries in `dbg!`)
- rust-lang/rust#154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer)
- rust-lang/rust#154540 (Fix invalid type suggestion for item nested in function)
- rust-lang/rust#154549 (Add regression test for recursive lazy type alias normalization ICE)
- rust-lang/rust#153373 (Fix LegacyKeyValueFormat report from docker build: powerpc)
- rust-lang/rust#154322 (feat: reimplement `hash_map!` macro)
- rust-lang/rust#154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- rust-lang/rust#154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16)
- rust-lang/rust#154508 (Fix ambiguous parsing in bootstrap.py)
- rust-lang/rust#154518 (Panic in Hermit clock_gettime)
- rust-lang/rust#154530 (update zulip link in `std` documentation)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
…uwer
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#154074 (don't drop arguments' temporaries in `dbg!`)
- rust-lang/rust#154328 (rustdoc: add missing {os,target,target_env} values for cfg pretty printer)
- rust-lang/rust#154540 (Fix invalid type suggestion for item nested in function)
- rust-lang/rust#154549 (Add regression test for recursive lazy type alias normalization ICE)
- rust-lang/rust#153373 (Fix LegacyKeyValueFormat report from docker build: powerpc)
- rust-lang/rust#154322 (feat: reimplement `hash_map!` macro)
- rust-lang/rust#154416 (Add `IoSplit` diagnostic item for `std::io::Split`)
- rust-lang/rust#154486 (std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16)
- rust-lang/rust#154508 (Fix ambiguous parsing in bootstrap.py)
- rust-lang/rust#154518 (Panic in Hermit clock_gettime)
- rust-lang/rust#154530 (update zulip link in `std` documentation)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@vitkyrka@rustbot@Noratrieb@jhpratt