rustdoc: seperate methods and associated functions in sidebar by lolbinarycat · Pull Request #154644 · rust-lang/rust

lolbinarycat · 2026-03-31T17:57:01Z

View all comments

fixes#154602

r? @fmease

before:

after:

example of type with both (Box):

rustbot · 2026-03-31T17:57:05Z

Some changes occurred in GUI tests.

cc @GuillaumeGomez

GuillaumeGomez · 2026-03-31T19:29:32Z

Just want to check perf but otherwise looks good to me, nice improvement!

@bors try @rust-timer queue

…try> rustdoc: seperate methods and associated functions in sidebar

rust-bors · 2026-03-31T21:41:05Z

☀️ Try build successful (CI)
Build commit: c9573e9 (c9573e9d13de5219d9cb386b0546d49f0dcf3326, parent: ba11b1e3f09829428844b74829146fcf7c38d3d0)

rust-timer · 2026-03-31T22:21:26Z

Finished benchmarking commit (c9573e9): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.2%, secondary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[0.9%, 3.4%]	6
Regressions ❌ (secondary)	2.3%	[1.2%, 3.8%]	5
Improvements ✅ (primary)	-2.3%	[-3.6%, -1.2%]	5
Improvements ✅ (secondary)	-2.4%	[-2.9%, -1.5%]	4
All ❌✅ (primary)	0.2%	[-3.6%, 3.4%]	11

Cycles

Results (primary -2.3%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-4.2%	[-4.2%, -4.2%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 488.578s -> 483.261s (-1.09%)
Artifact size: 394.90 MiB -> 395.02 MiB (0.03%)

GuillaumeGomez · 2026-04-01T09:25:03Z

All good, then let's go!

@bors r+ rollup

rust-bors · 2026-04-01T09:25:06Z

📌 Commit 9bdf217 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@fmease

…-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixesrust-lang#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

@fmease

…-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixesrust-lang#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

rust-bors · 2026-04-01T18:47:15Z

⚠️ A new commit 34e07d55553012f02e79a57de3876e471bf33bc1 was pushed.

This pull request was unapproved.

This PR was contained in a rollup (#154688), which was closed.

lolbinarycat · 2026-04-01T21:11:32Z

Ok, I apperently somehow a different local branch got set up so that its upstream is this branch, then trying to rebase the branch to fix things just made them worse. Hopefully everything is resolved now.

@bors r=GuillaumeGomez rollup

rust-bors · 2026-04-01T21:11:35Z

📌 Commit 9bdf217 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@fmease

…-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixesrust-lang#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

Rollup of 11 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)

@fmease

…-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixesrust-lang#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

Rollup of 11 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154213 (tidy-alphabetical: fix line number in error message) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)

@fmease

…-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixesrust-lang#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #154713 (Stop compiling when we get resolving crate failure) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

@fmease

…-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixesrust-lang#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

…uwer Rollup of 21 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153286 (various fixes for scalable vectors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

…uwer Rollup of 20 pull requests Successful merges: - #153105 (Compute the result of a projection type with region errors) - #153532 (Attributes containing rustc) - #153960 (Make `layout_of` cycles fatal errors) - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - #154666 (Remove `StableHashContext` impls) - #154669 (Introduce #[diagnostic::on_move] on `Arc`) - #154710 (opaque_generic_const_args -> generic_const_args) - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - #153614 (`FindParamInClause` handle edge-cases) - #154213 (tidy-alphabetical: fix line number in error message) - #154425 (Migrate transmute tests) - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - #154469 (mGCA: Lower spans for literal const args) - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - #154615 (Moving issues) - #154644 (rustdoc: seperate methods and associated functions in sidebar) - #154660 (Avoid creating async return opaques for foreign async fns) - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - #154709 (Revert `Ty` type alias in `rustc_type_ir`)

@fmease

Rollup merge of #154644 - lolbinarycat:rustdoc-sidebar-assoc-items, r=GuillaumeGomez rustdoc: seperate methods and associated functions in sidebar fixes#154602 r? @fmease before: <img width="340" height="591" alt="image" src="https://github.com/user-attachments/assets/79268155-5260-4bb9-a826-46f459fc81eb" /> after: <img width="514" height="588" alt="image" src="https://github.com/user-attachments/assets/b56b5ca6-28d7-45a7-86a9-ad6bf37f608a" /> example of type with both (`Box`): <img width="410" height="760" alt="image" src="https://github.com/user-attachments/assets/a74dd536-e931-4d8f-af95-275bfcf48285" />

…uwer Rollup of 20 pull requests Successful merges: - rust-lang/rust#153105 (Compute the result of a projection type with region errors) - rust-lang/rust#153532 (Attributes containing rustc) - rust-lang/rust#153960 (Make `layout_of` cycles fatal errors) - rust-lang/rust#154527 (Emit pre-expansion feature gate warnings for negative impls and specialization) - rust-lang/rust#154666 (Remove `StableHashContext` impls) - rust-lang/rust#154669 (Introduce #[diagnostic::on_move] on `Arc`) - rust-lang/rust#154710 (opaque_generic_const_args -> generic_const_args) - rust-lang/rust#154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph") - rust-lang/rust#153614 (`FindParamInClause` handle edge-cases) - rust-lang/rust#154213 (tidy-alphabetical: fix line number in error message) - rust-lang/rust#154425 (Migrate transmute tests) - rust-lang/rust#154442 (Export `derive` at the crate root: `core::derive` and `std::derive`) - rust-lang/rust#154469 (mGCA: Lower spans for literal const args) - rust-lang/rust#154578 (Rename `probe_ty_var` to `try_resolve_ty_var`) - rust-lang/rust#154615 (Moving issues) - rust-lang/rust#154644 (rustdoc: seperate methods and associated functions in sidebar) - rust-lang/rust#154660 (Avoid creating async return opaques for foreign async fns) - rust-lang/rust#154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args) - rust-lang/rust#154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible) - rust-lang/rust#154709 (Revert `Ty` type alias in `rustc_type_ir`)

@GuillaumeGomez

…ode_examples-macro_rules, r=GuillaumeGomez rustdoc_missing_doc_code_examples: lint on macro_rules macros part of rust-lang#154640 accidentally built this on top of rust-lang#154644, but since that PR is already approved it should be fine if we just wait for it to be merged. r? @GuillaumeGomez

@GuillaumeGomez

Rollup merge of #154696 - lolbinarycat:rustdoc-missing_doc_code_examples-macro_rules, r=GuillaumeGomez rustdoc_missing_doc_code_examples: lint on macro_rules macros part of #154640 accidentally built this on top of #154644, but since that PR is already approved it should be fine if we just wait for it to be merged. r? @GuillaumeGomez

nyurik · 2026-05-28T18:13:50Z

note that the typo in seperate title made it into the release docs

rustdoc: seperate methods and associated functions in sidebar
9bdf217

rustbot assigned fmease Mar 31, 2026

GuillaumeGomez approved these changes Mar 31, 2026
View reviewed changes

This comment has been minimized.
Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 31, 2026

This comment has been minimized.
Sign in to view

rust-borsBot pushed a commit that referenced this pull request Mar 31, 2026
Auto merge of#154644- lolbinarycat:rustdoc-sidebar-assoc-items, r=<…
c9573e9
…try> rustdoc: seperate methods and associated functions in sidebar

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 31, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2026

chenyukang mentioned this pull request Apr 1, 2026
Rollup of 6 pull requests #154672
Closed

JonathanBrouwer mentioned this pull request Apr 1, 2026
Rollup of 6 pull requests #154688
Closed

lolbinarycat added the relnotes Marks issues that should be documented in the release notes of the next release. label Apr 1, 2026

rustbot mentioned this pull request Apr 1, 2026
Tracking issue for release notes of #154644: rustdoc: separate methods and associated functions in sidebar #154690
Closed

rust-borsBot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2026

This comment has been minimized.
Sign in to view

lolbinarycat force-pushed the rustdoc-sidebar-assoc-items branch from 6bd7798 to 9bdf217Compare April 1, 2026 21:09

This comment was marked as outdated.
Sign in to view

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 1, 2026

jhpratt mentioned this pull request Apr 2, 2026
Rollup of 11 pull requests #154701
Closed

jhpratt mentioned this pull request Apr 2, 2026
Rollup of 11 pull requests #154705
Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026
Rollup of 21 pull requests #154716
Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026
Rollup of 21 pull requests #154718
Closed

JonathanBrouwer mentioned this pull request Apr 2, 2026
Rollup of 20 pull requests #154727
Merged

rust-borsBot merged commit 878c36b into rust-lang:mainApr 2, 2026
24 of 34 checks passed

rustbot added this to the 1.96.0 milestone Apr 2, 2026

BoxyUwU mentioned this pull request May 12, 2026
Draft release notes for 1.96.0 #156512
Closed

fmease assigned GuillaumeGomez and unassigned fmease Aug 23, 2026

Uh oh!

Uh oh!

Conversation

lolbinarycat commented Mar 31, 2026• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Mar 31, 2026

Uh oh!

GuillaumeGomez commented Mar 31, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-borsBot commented Mar 31, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 31, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

GuillaumeGomez commented Apr 1, 2026

Uh oh!

rust-borsBot commented Apr 1, 2026

Uh oh!

rust-borsBot commented Apr 1, 2026

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

lolbinarycat commented Apr 1, 2026

Uh oh!

rust-borsBot commented Apr 1, 2026

Uh oh!

Uh oh!

nyurik commented May 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

lolbinarycat commented Mar 31, 2026•
edited by rustbot
Loading